[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-15 Thread Amit Shah
On (Mon) Feb 15 2010 [16:07:28], Michael S. Tsirkin wrote: > On Mon, Feb 15, 2010 at 06:51:31PM +0530, Amit Shah wrote: > > On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote: > > > Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all > > > serial devices declare MULTIPORT feature. > >

[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-15 Thread Michael S. Tsirkin
On Mon, Feb 15, 2010 at 06:51:31PM +0530, Amit Shah wrote: > On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote: > > Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all > > serial devices declare MULTIPORT feature. > > To allow 0.12 compatibility, we should clear this when > > max_nr_

[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-15 Thread Amit Shah
On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote: > Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all > serial devices declare MULTIPORT feature. > To allow 0.12 compatibility, we should clear this when > max_nr_ports is 1. > > Signed-off-by: Michael S. Tsirkin Acked-by: Amit S

[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-15 Thread Gerd Hoffmann
On 02/15/10 10:24, Amit Shah wrote: Is there a qdev property for max_nr_ports? Then simply adding a compat property will do the trick. Something like this (I can split it into two patches before submission): Yep, should be splitted. diff --git a/hw/pc.c b/hw/pc.c index 5b29f3b..a975934 100

[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-15 Thread Michael S. Tsirkin
On Mon, Feb 15, 2010 at 02:54:01PM +0530, Amit Shah wrote: > On (Mon) Feb 15 2010 [10:03:34], Gerd Hoffmann wrote: > > On 02/12/10 15:23, Amit Shah wrote: > >> On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote: > >>> Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all > >>> serial de

[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-15 Thread Amit Shah
On (Mon) Feb 15 2010 [10:03:34], Gerd Hoffmann wrote: > On 02/12/10 15:23, Amit Shah wrote: >> On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote: >>> Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all >>> serial devices declare MULTIPORT feature. >>> To allow 0.12 compatibility, we

[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-15 Thread Gerd Hoffmann
On 02/12/10 15:23, Amit Shah wrote: On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote: Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all serial devices declare MULTIPORT feature. To allow 0.12 compatibility, we should clear this when max_nr_ports is 1. In addition to this, set

[Qemu-devel] Re: [PATCH] virtio-serial: don't set MULTIPORT for 1 port dev

2010-02-12 Thread Amit Shah
On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote: > Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all > serial devices declare MULTIPORT feature. > To allow 0.12 compatibility, we should clear this when > max_nr_ports is 1. In addition to this, setting max_nr_ports to 1 is needed