On Wed, Mar 31, 2010 at 09:20:31PM +0300, Michael S. Tsirkin wrote:
> From: David L Stevens
>
> vhost driver in qemu didn't ack features, and this happens
> to work because we don't really require any features. However,
> it's better not to rely on this. This patch passes features to
> vhost as g
On 4/1/10, Aurelien Jarno wrote:
> On Wed, Mar 31, 2010 at 02:24:51PM -0500, Anthony Liguori wrote:
> > On 03/31/2010 02:07 PM, Michael S. Tsirkin wrote:
> >> On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote:
> >>
> >>> On Wed, 31 Mar 2010 13:26:23 -0500
> >>> Anthony Liguori
On 04/01/2010 10:54 AM, Blue Swirl wrote:
On 4/1/10, Anthony Liguori wrote:
On 03/31/2010 05:45 PM, Aurelien Jarno wrote:
While it probably make sense to achieve this goal, it doesn't mean it
should be done the dirty way.
For example it is known for a lot of time that the solution
On 4/1/10, Anthony Liguori wrote:
> On 03/31/2010 05:45 PM, Aurelien Jarno wrote:
>
> > While it probably make sense to achieve this goal, it doesn't mean it
> > should be done the dirty way.
> >
> > For example it is known for a lot of time that the solution for the
> > bswap in the device code i
On Wed, Mar 31, 2010 at 10:38:47PM +0300, Blue Swirl wrote:
> > Maybe it makes sense to revert the compile once patches, and discuss
> > these issues before re-commit?
>
> Maybe I'll try to remember this as your favourite problem solving
> approach if I happen to dislike the changes your patches
> But this makes kvm_enabled() check dynamic and code that was
> eliminated by compiler for !CONFIG_KVM will now be generated.
>
> Wouldn't adding CONFIG_KVM to config-host.h also solve the problem?
CONFIG_KVM is (and should be) a per-target decision.
Paul
On 03/31/2010 09:45 PM, Anthony Liguori wrote:
On 03/31/2010 05:45 PM, Aurelien Jarno wrote:
While it probably make sense to achieve this goal, it doesn't mean it
should be done the dirty way.
For example it is known for a lot of time that the solution for the
bswap in the device code is to add
On 03/31/2010 05:45 PM, Aurelien Jarno wrote:
While it probably make sense to achieve this goal, it doesn't mean it
should be done the dirty way.
For example it is known for a lot of time that the solution for the
bswap in the device code is to add a bus model doing the byteswapping.
Removing th
On Wed, Mar 31, 2010 at 02:24:51PM -0500, Anthony Liguori wrote:
> On 03/31/2010 02:07 PM, Michael S. Tsirkin wrote:
>> On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote:
>>
>>> On Wed, 31 Mar 2010 13:26:23 -0500
>>> Anthony Liguori wrote:
>>>
>>>
On 03/31/2010 01:20 P
On Wed, Mar 31, 2010 at 10:25:53PM +0300, Michael S. Tsirkin wrote:
> On Wed, Mar 31, 2010 at 02:24:51PM -0500, Anthony Liguori wrote:
> > Long term, I think most of us want to see a single qemu executable
> > that works for all architectures and compiling once is an important
> > step in that di
On 3/31/10, Anthony Liguori wrote:
> On 03/31/2010 02:38 PM, Blue Swirl wrote:
>
> > On 3/31/10, Michael S. Tsirkin wrote:
> >
> >
> > > On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote:
> > > > On Wed, 31 Mar 2010 13:26:23 -0500
> > > > Anthony Liguori wrote:
> > > >
> > >
On 03/31/2010 02:54 PM, Blue Swirl wrote:
This refactoring effort isn't really paying attention to improving
interfaces which I think is a bit problematic.
I agree, but with improved memory API, the questionable byte swapping
could be eliminated from devices. Do you plan to finish your
On 3/31/10, Anthony Liguori wrote:
> On 03/31/2010 02:25 PM, Michael S. Tsirkin wrote:
>
> > On Wed, Mar 31, 2010 at 02:24:51PM -0500, Anthony Liguori wrote:
> >
> >
> > > Long term, I think most of us want to see a single qemu executable
> > > that works for all architectures and compiling once
On 3/31/10, Anthony Liguori wrote:
> On 03/31/2010 02:07 PM, Michael S. Tsirkin wrote:
>
> > On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote:
> >
> >
> > > On Wed, 31 Mar 2010 13:26:23 -0500
> > > Anthony Liguori wrote:
> > >
> > >
> > >
> > > > On 03/31/2010 01:20 PM, Michael S.
On 03/31/2010 02:38 PM, Blue Swirl wrote:
On 3/31/10, Michael S. Tsirkin wrote:
On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote:
> On Wed, 31 Mar 2010 13:26:23 -0500
> Anthony Liguori wrote:
>
> > On 03/31/2010 01:20 PM, Michael S. Tsirkin wrote:
> > > From
On 3/31/10, Michael S. Tsirkin wrote:
> On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote:
> > On Wed, 31 Mar 2010 13:26:23 -0500
> > Anthony Liguori wrote:
> >
> > > On 03/31/2010 01:20 PM, Michael S. Tsirkin wrote:
> > > > From: David L Stevens
> > > >
> > > > vhost driver
On 03/31/2010 02:25 PM, Michael S. Tsirkin wrote:
On Wed, Mar 31, 2010 at 02:24:51PM -0500, Anthony Liguori wrote:
Long term, I think most of us want to see a single qemu executable
that works for all architectures and compiling once is an important
step in that direction.
I'm not s
On Wed, Mar 31, 2010 at 02:24:51PM -0500, Anthony Liguori wrote:
> Long term, I think most of us want to see a single qemu executable
> that works for all architectures and compiling once is an important
> step in that direction.
I'm not so sure. It's pretty low on my list of priorities. Most us
On 03/31/2010 02:07 PM, Michael S. Tsirkin wrote:
On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote:
On Wed, 31 Mar 2010 13:26:23 -0500
Anthony Liguori wrote:
On 03/31/2010 01:20 PM, Michael S. Tsirkin wrote:
From: David L Stevens
vhost driver in qemu didn't
On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote:
> On Wed, 31 Mar 2010 13:26:23 -0500
> Anthony Liguori wrote:
>
> > On 03/31/2010 01:20 PM, Michael S. Tsirkin wrote:
> > > From: David L Stevens
> > >
> > > vhost driver in qemu didn't ack features, and this happens
> > > to work b
On Wed, 31 Mar 2010 13:26:23 -0500
Anthony Liguori wrote:
> On 03/31/2010 01:20 PM, Michael S. Tsirkin wrote:
> > From: David L Stevens
> >
> > vhost driver in qemu didn't ack features, and this happens
> > to work because we don't really require any features. However,
> > it's better not to rely
On 03/31/2010 01:20 PM, Michael S. Tsirkin wrote:
From: David L Stevens
vhost driver in qemu didn't ack features, and this happens
to work because we don't really require any features. However,
it's better not to rely on this. This patch passes features to
vhost as guest acks them.
Signed-off-b
22 matches
Mail list logo