Re: [Qemu-devel] Re: [PATCH] usb-msd: Add usb-storage, removable=on|off property

2011-01-17 Thread Stefan Hajnoczi
On Mon, Jan 17, 2011 at 4:01 PM, Christoph Hellwig wrote: > On Mon, Jan 17, 2011 at 10:04:05AM +, Stefan Hajnoczi wrote: >> I was considering not using bdrv_set_removable() and instead adding a >> hint to the BlockDriverState which gets checked when constructing the >> SCSI INQUIRY response.  

Re: [Qemu-devel] Re: [PATCH] usb-msd: Add usb-storage, removable=on|off property

2011-01-17 Thread Christoph Hellwig
On Mon, Jan 17, 2011 at 10:04:05AM +, Stefan Hajnoczi wrote: > I was considering not using bdrv_set_removable() and instead adding a > hint to the BlockDriverState which gets checked when constructing the > SCSI INQUIRY response. If we take that approach, then QEMU doesn't > consider the block

Re: [Qemu-devel] Re: [PATCH] usb-msd: Add usb-storage, removable=on|off property

2011-01-17 Thread Stefan Hajnoczi
On Mon, Jan 17, 2011 at 10:21:26AM +0100, Christoph Hellwig wrote: > The actual removable bit looks fine, but I don't think the connection of > the change callback looks sane. What's the rationale for it? Since we're using bdrv_set_removable(), the user may try to eject the block device from the

[Qemu-devel] Re: [PATCH] usb-msd: Add usb-storage, removable=on|off property

2011-01-17 Thread Christoph Hellwig
The actual removable bit looks fine, but I don't think the connection of the change callback looks sane. What's the rationale for it?