Re: [Qemu-devel] Re: [PATCH] target-arm: fix SMMLA/SMMLS instructions

2011-01-06 Thread Aurelien Jarno
On Thu, Jan 06, 2011 at 07:00:09PM +, Peter Maydell wrote: > On 6 January 2011 18:53, Aurelien Jarno wrote: > > SMMLA and SMMLS are broken on both in normal and thumb mode, that is > > both (different) implementations are wrong. They try to avoid a 64-bit > > add for the rounding, which is not

[Qemu-devel] Re: [PATCH] target-arm: fix SMMLA/SMMLS instructions

2011-01-06 Thread Peter Maydell
On 6 January 2011 18:53, Aurelien Jarno wrote: > SMMLA and SMMLS are broken on both in normal and thumb mode, that is > both (different) implementations are wrong. They try to avoid a 64-bit > add for the rounding, which is not trivial if you want to support both > SMMLA and SMMLS with the same co