Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field

2011-01-12 Thread Sergei Gavrikov
On Wed, 12 Jan 2011, Stefan Hajnoczi wrote: > On Wed, Jan 12, 2011 at 10:22 AM, Sergei Gavrikov > wrote: > > It was good to know. If you mean the below I "merge" that in one. Thank > > you for review. > > > > Sergei > > > > Signed-off-by: Sergei Gavrikov > > Acked-by: Stefan Hajnoczi > > You

Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field

2011-01-12 Thread Stefan Hajnoczi
On Wed, Jan 12, 2011 at 10:22 AM, Sergei Gavrikov wrote: > It was good to know. If you mean the below I "merge" that in one. Thank > you for review. > > Sergei > > Signed-off-by: Sergei Gavrikov > Acked-by: Stefan Hajnoczi Your new patch looks fine. I prefer: Reviewed-by: Stefan Hajnoczi Ste

Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field

2011-01-12 Thread Sergei Gavrikov
On Wed, 12 Jan 2011, Stefan Hajnoczi wrote: > On Wed, Jan 12, 2011 at 7:22 AM, Sergei Gavrikov > wrote: > > diff --git a/slirp/tftp.c b/slirp/tftp.c > > index 55e4692..a455ad1 100644 > > --- a/slirp/tftp.c > > +++ b/slirp/tftp.c > > @@ -311,7 +311,7 @@ static void tftp_handle_rrq(Slirp *slirp, st

Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field

2011-01-12 Thread Stefan Hajnoczi
On Wed, Jan 12, 2011 at 7:22 AM, Sergei Gavrikov wrote: > diff --git a/slirp/tftp.c b/slirp/tftp.c > index 55e4692..a455ad1 100644 > --- a/slirp/tftp.c > +++ b/slirp/tftp.c > @@ -311,7 +311,7 @@ static void tftp_handle_rrq(Slirp *slirp, struct tftp_t > *tp, int pktlen) >     return; >   } > > -  

[Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field

2011-01-11 Thread Sergei Gavrikov
On Mon, 10 Jan 2011, Sergei Gavrikov wrote: > According to RFC 1350 http://www.ietf.org/rfc/rfc1350.txt [Page 5]: > > The mode field contains the string "netascii", "octet", or "mail" > (or any combination of upper and lower case, such as "NETASCII", > NetAscii", etc.) > > Unfortunate