[Qemu-devel] Re: [PATCH] raw/linux-aio: Also initialize POSIX AIO

2009-10-28 Thread Christoph Hellwig
On Mon, Oct 26, 2009 at 09:36:55AM +0100, Kevin Wolf wrote: > Well, my question was not if they are sub-modules of raw-posix - they > clearly are - but rather if they should be. linux-aio is just a trvial wrapper for the native Linux AIO abi to be used by QEMU, I can't see why it wouldn't. posix-

[Qemu-devel] Re: [PATCH] raw/linux-aio: Also initialize POSIX AIO

2009-10-26 Thread Kevin Wolf
Am 25.10.2009 08:19, schrieb Christoph Hellwig: > On Thu, Oct 22, 2009 at 11:05:55AM +0200, Kevin Wolf wrote: >> Yes, it might look like overkill to introduce a abstraction for exactly >> two backends. I felt the same way. But then, the current implementation >> just feels totally wrong. It absolut

[Qemu-devel] Re: [PATCH] raw/linux-aio: Also initialize POSIX AIO

2009-10-25 Thread Christoph Hellwig
On Thu, Oct 22, 2009 at 11:05:55AM +0200, Kevin Wolf wrote: > Yes, it might look like overkill to introduce a abstraction for exactly > two backends. I felt the same way. But then, the current implementation > just feels totally wrong. It absolutely intransparent when we fall back > to paio, and be

[Qemu-devel] Re: [PATCH] raw/linux-aio: Also initialize POSIX AIO

2009-10-22 Thread Kevin Wolf
Am 22.10.2009 10:31, schrieb Christoph Hellwig: > On Tue, Oct 20, 2009 at 12:12:55PM +0200, Kevin Wolf wrote: >> On that note, falling back to POSIX AIO means that paio_submit is called >> with a Linux AIO aio_ctx. Which works because this parameter is unused >> anyway, but am I the only one to fin

[Qemu-devel] Re: [PATCH] raw/linux-aio: Also initialize POSIX AIO

2009-10-22 Thread Christoph Hellwig
On Tue, Oct 20, 2009 at 12:12:55PM +0200, Kevin Wolf wrote: > On that note, falling back to POSIX AIO means that paio_submit is called > with a Linux AIO aio_ctx. Which works because this parameter is unused > anyway, but am I the only one to find this ugly? > > What is the public interface of pai

[Qemu-devel] Re: [PATCH] raw/linux-aio: Also initialize POSIX AIO

2009-10-20 Thread Kevin Wolf
Am 20.10.2009 11:33, schrieb Kevin Wolf: > When using Linux AIO raw still falls back to POSIX AIO sometimes, so we should > initialize it. > > Not initializing it happens to work if POSIX AIO is used by another drive, or > if the format is not specified (probing the format uses POSIX AIO) or by pu