[Qemu-devel] Re: [PATCH] qemu/virtio-net: remove wrong s/g layout assumptions

2009-11-30 Thread Michael S. Tsirkin
On Wed, Nov 25, 2009 at 12:20:05AM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 24, 2009 at 03:57:48PM -0600, Anthony Liguori wrote: > > Michael S. Tsirkin wrote: > >> It's useful because this way I won't have to maintain the fix, and it > >> will make it possible for guests to experiment with la

[Qemu-devel] Re: [PATCH] qemu/virtio-net: remove wrong s/g layout assumptions

2009-11-24 Thread Michael S. Tsirkin
On Tue, Nov 24, 2009 at 03:57:48PM -0600, Anthony Liguori wrote: > Michael S. Tsirkin wrote: >> It's useful because this way I won't have to maintain the fix, and it >> will make it possible for guests to experiment with layouts, without >> hacking qemu. If someone wants to make it a product, that'

[Qemu-devel] Re: [PATCH] qemu/virtio-net: remove wrong s/g layout assumptions

2009-11-24 Thread Anthony Liguori
Michael S. Tsirkin wrote: It's useful because this way I won't have to maintain the fix, and it will make it possible for guests to experiment with layouts, without hacking qemu. If someone wants to make it a product, that's a different thing. Advertising a new feature is not hard. It's one

[Qemu-devel] Re: [PATCH] qemu/virtio-net: remove wrong s/g layout assumptions

2009-11-24 Thread Michael S. Tsirkin
On Tue, Nov 24, 2009 at 03:04:47PM -0600, Anthony Liguori wrote: > Michael S. Tsirkin wrote: >> On Tue, Nov 24, 2009 at 01:50:25PM -0600, Anthony Liguori wrote: >> >>> Michael S. Tsirkin wrote: >>> virtio net currently assumes that the first s/g element it gets is always virtio ne

[Qemu-devel] Re: [PATCH] qemu/virtio-net: remove wrong s/g layout assumptions

2009-11-24 Thread Anthony Liguori
Michael S. Tsirkin wrote: On Tue, Nov 24, 2009 at 01:50:25PM -0600, Anthony Liguori wrote: Michael S. Tsirkin wrote: virtio net currently assumes that the first s/g element it gets is always virtio net header. This is wrong. There should be no assumption on sg boundaries. For example,

[Qemu-devel] Re: [PATCH] qemu/virtio-net: remove wrong s/g layout assumptions

2009-11-24 Thread Michael S. Tsirkin
On Tue, Nov 24, 2009 at 01:50:25PM -0600, Anthony Liguori wrote: > Michael S. Tsirkin wrote: >> virtio net currently assumes that the first s/g element it gets is >> always virtio net header. This is wrong. >> There should be no assumption on sg boundaries. For example, the guest >> should be able

[Qemu-devel] Re: [PATCH] qemu/virtio-net: remove wrong s/g layout assumptions

2009-11-24 Thread Anthony Liguori
Michael S. Tsirkin wrote: virtio net currently assumes that the first s/g element it gets is always virtio net header. This is wrong. There should be no assumption on sg boundaries. For example, the guest should be able to put the virtio_net_hdr in the front of the skbuf data if there is room.