[Qemu-devel] Re: [PATCH] qcow2: don't ignore failed update_refcount

2010-02-08 Thread Jim Meyering
Kevin Wolf wrote: ... > I'm currently working on fixing exactly this, and unfortunaly, no, it's > not that easy. What you introduce looks like proper error handling at > first sight, but what happens in fact is that while the current write > request correctly fails now we're running with corrupted

[Qemu-devel] Re: [PATCH] qcow2: don't ignore failed update_refcount

2010-02-08 Thread Kevin Wolf
Am 08.02.2010 16:01, schrieb Jim Meyering: > update_refcount is marked as a function for which we must use its result, > > static int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs, > > and rightly so, since doing otherwise would amount to ignoring write failure. > However, ther