Re: [Qemu-devel] Re: [PATCH] kvm: x86: Fix initial kvm_has_msr_star

2009-12-07 Thread Anthony Liguori
Avi Kivity wrote: On 12/07/2009 04:47 PM, Anthony Liguori wrote: Don't know when 0.11.2 will happen but I'll also push it to the stable-0.11 branch. I think this is worthy of a 0.11.2 all by itself. Understood. I'll see what I can do today. -- Regards, Anthony Liguori

Re: [Qemu-devel] Re: [PATCH] kvm: x86: Fix initial kvm_has_msr_star

2009-12-07 Thread Avi Kivity
On 12/07/2009 04:47 PM, Anthony Liguori wrote: Don't know when 0.11.2 will happen but I'll also push it to the stable-0.11 branch. I think this is worthy of a 0.11.2 all by itself. -- error compiling committee.c: too many arguments to function

[Qemu-devel] Re: [PATCH] kvm: x86: Fix initial kvm_has_msr_star

2009-12-07 Thread Anthony Liguori
Avi Kivity wrote: On 12/06/2009 04:51 PM, Jan Kiszka wrote: KVM_GET_MSR_INDEX_LIST returns -E2BIG when the provided space is too small for all MSRs. But this is precisely the error we trigger with the initial request in order to obtain that size. Do not fail in that case. This caused a subtle c

[Qemu-devel] Re: [PATCH] kvm: x86: Fix initial kvm_has_msr_star

2009-12-07 Thread Avi Kivity
On 12/07/2009 10:24 AM, Jan Kiszka wrote: I applied this to qemu-kvm since it missed 0.12-rc1. OK, but this part is unused in qemu-kvm as we use our own (unaffected) implementation there so far. #include Will unapply. -- error compiling committee.c: too many arguments to functi

[Qemu-devel] Re: [PATCH] kvm: x86: Fix initial kvm_has_msr_star

2009-12-07 Thread Jan Kiszka
Avi Kivity wrote: > On 12/06/2009 04:51 PM, Jan Kiszka wrote: >> KVM_GET_MSR_INDEX_LIST returns -E2BIG when the provided space is too >> small for all MSRs. But this is precisely the error we trigger with the >> initial request in order to obtain that size. Do not fail in that case. >> >> This caus

[Qemu-devel] Re: [PATCH] kvm: x86: Fix initial kvm_has_msr_star

2009-12-07 Thread Avi Kivity
On 12/06/2009 04:51 PM, Jan Kiszka wrote: KVM_GET_MSR_INDEX_LIST returns -E2BIG when the provided space is too small for all MSRs. But this is precisely the error we trigger with the initial request in order to obtain that size. Do not fail in that case. This caused a subtle corruption of the gu