Re: [Qemu-devel] Re: [PATCH] fix smp with tcg mode and --enable-io-thread

2010-06-23 Thread Anthony Liguori
On 06/23/2010 02:42 AM, Jan Kiszka wrote: Jan Kiszka wrote: Marcelo Tosatti wrote: On Mon, Jun 21, 2010 at 10:58:32PM +0200, Jan Kiszka wrote: Jan Kiszka wrote: Marcelo Tosatti wrote: Clear exit_request when iothread grabs the global lock. Signed-off-

[Qemu-devel] Re: [PATCH] fix smp with tcg mode and --enable-io-thread

2010-06-23 Thread Jan Kiszka
Jan Kiszka wrote: > Marcelo Tosatti wrote: >> On Mon, Jun 21, 2010 at 10:58:32PM +0200, Jan Kiszka wrote: >>> Jan Kiszka wrote: Marcelo Tosatti wrote: > Clear exit_request when iothread grabs the global lock. > > Signed-off-by: Marcelo Tosatti > > diff --git a/cpu-exec.c

[Qemu-devel] Re: [PATCH] fix smp with tcg mode and --enable-io-thread

2010-06-22 Thread Jan Kiszka
Marcelo Tosatti wrote: > On Mon, Jun 21, 2010 at 10:58:32PM +0200, Jan Kiszka wrote: >> Jan Kiszka wrote: >>> Marcelo Tosatti wrote: Clear exit_request when iothread grabs the global lock. Signed-off-by: Marcelo Tosatti diff --git a/cpu-exec.c b/cpu-exec.c index 0269

Re: [Qemu-devel] Re: [PATCH] fix smp with tcg mode and --enable-io-thread

2010-06-22 Thread Jan Kiszka
Alexander Graf wrote: > On 22.06.2010, at 00:13, Jan Kiszka wrote: > >> Jan Kiszka wrote: >>> And there is some race that cause a lock up in qemu_mutex_lock_iothread >>> after a while (the cpu_unlink_tb seems to race with the linking - just a >>> guess so far). >> This seems to fix a long-standing

[Qemu-devel] Re: [PATCH] fix smp with tcg mode and --enable-io-thread

2010-06-21 Thread Marcelo Tosatti
On Mon, Jun 21, 2010 at 10:58:32PM +0200, Jan Kiszka wrote: > Jan Kiszka wrote: > > Marcelo Tosatti wrote: > >> Clear exit_request when iothread grabs the global lock. > >> > >> Signed-off-by: Marcelo Tosatti > >> > >> diff --git a/cpu-exec.c b/cpu-exec.c > >> index 026980a..74cb973 100644 > >> -

Re: [Qemu-devel] Re: [PATCH] fix smp with tcg mode and --enable-io-thread

2010-06-21 Thread Alexander Graf
On 22.06.2010, at 00:13, Jan Kiszka wrote: > Jan Kiszka wrote: >> And there is some race that cause a lock up in qemu_mutex_lock_iothread >> after a while (the cpu_unlink_tb seems to race with the linking - just a >> guess so far). > > This seems to fix a long-standing race between cpu_exec and

[Qemu-devel] Re: [PATCH] fix smp with tcg mode and --enable-io-thread

2010-06-21 Thread Jan Kiszka
Jan Kiszka wrote: > And there is some race that cause a lock up in qemu_mutex_lock_iothread > after a while (the cpu_unlink_tb seems to race with the linking - just a > guess so far). This seems to fix a long-standing race between cpu_exec and signal-driven cpu_unlink_tb: diff --git a/cpu-exec.c

[Qemu-devel] Re: [PATCH] fix smp with tcg mode and --enable-io-thread

2010-06-21 Thread Jan Kiszka
Jan Kiszka wrote: > Marcelo Tosatti wrote: >> Clear exit_request when iothread grabs the global lock. >> >> Signed-off-by: Marcelo Tosatti >> >> diff --git a/cpu-exec.c b/cpu-exec.c >> index 026980a..74cb973 100644 >> --- a/cpu-exec.c >> +++ b/cpu-exec.c >> @@ -236,10 +236,8 @@ int cpu_exec(CPUSt

[Qemu-devel] Re: [PATCH] fix smp with tcg mode and --enable-io-thread

2010-06-21 Thread Jan Kiszka
Marcelo Tosatti wrote: > Clear exit_request when iothread grabs the global lock. > > Signed-off-by: Marcelo Tosatti > > diff --git a/cpu-exec.c b/cpu-exec.c > index 026980a..74cb973 100644 > --- a/cpu-exec.c > +++ b/cpu-exec.c > @@ -236,10 +236,8 @@ int cpu_exec(CPUState *env1) > asm("");