[Qemu-devel] Re: [PATCH] fdc: Fix vmsave/restore regression

2009-11-12 Thread Juan Quintela
Jan Kiszka wrote: > Juan Quintela wrote: >> Jan Kiszka wrote: >>> *** NOTE *** >>> 'git shortlog|grep "reset + vmsd"' shows 10 such conversions. I only >>> briefly checked the first one, and it looks similar broken. Could >>> someone have a second look at them? Maybe it is also better to define a

[Qemu-devel] Re: [PATCH] fdc: Fix vmsave/restore regression

2009-11-12 Thread Jan Kiszka
Juan Quintela wrote: > Jan Kiszka wrote: >> *** NOTE *** >> 'git shortlog|grep "reset + vmsd"' shows 10 such conversions. I only >> briefly checked the first one, and it looks similar broken. Could >> someone have a second look at them? Maybe it is also better to define a >> vmsd opaque in DeviceI

[Qemu-devel] Re: [PATCH] fdc: Fix vmsave/restore regression

2009-11-12 Thread Juan Quintela
Jan Kiszka wrote: > > *** NOTE *** > 'git shortlog|grep "reset + vmsd"' shows 10 such conversions. I only > briefly checked the first one, and it looks similar broken. Could > someone have a second look at them? Maybe it is also better to define a > vmsd opaque in DeviceInfo, which would also allo

[Qemu-devel] Re: [PATCH] fdc: Fix vmsave/restore regression

2009-11-11 Thread Juan Quintela
Jan Kiszka wrote: > This partly reverts 2be3783328: First, the conversion neglected to > update the opaque translation in fdc_pre_save/fdc_post_load which causes > memory corruptions on vmsave/restore. And second, we can't apply a > common translation here as DeviceState->fdctrl_t is different for