[Qemu-devel] Re: [PATCH] e1000: Fix hotplug

2010-08-03 Thread Alex Williamson
On Tue, 2010-08-03 at 08:17 -0400, Glauber Costa wrote: > On Mon, Aug 02, 2010 at 03:15:17PM -0600, Alex Williamson wrote: > > When we hotplug the device, > > we don't go through a reset cycle, which means a hot added e1000 is > > useless until the VM reboots. > > I do guess, however, that this

[Qemu-devel] Re: [PATCH] e1000: Fix hotplug

2010-08-03 Thread Glauber Costa
On Mon, Aug 02, 2010 at 03:15:17PM -0600, Alex Williamson wrote: > When we hotplug the device, > we don't go through a reset cycle, which means a hot added e1000 is > useless until the VM reboots. I do guess, however, that this is true for any device, right? Wouldn't it be better to just call t

[Qemu-devel] Re: [PATCH] e1000: Fix hotplug

2010-08-02 Thread Alex Williamson
rtl8139 has the same problem, except there's a much bigger pile of code in rtl8139_reset()? I think maybe we need to revisit this wholesale remove of reset calls from init functions, unless I'm missing how hotplug is supposed to work. Thanks, Alex On Mon, 2010-08-02 at 15:15 -0600, Alex Willia