[Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-20 Thread Kevin Wolf
Am 19.05.2010 20:53, schrieb Christoph Hellwig: > The difference between the start sectors of two requests can be larger > than the size of the "int" type, which can lead to a not correctly > sorted multiwrite array and thus spurious I/O errors and filesystem > corruption due to incorrect request m

Re: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-20 Thread Avi Kivity
On 05/20/2010 11:19 AM, Kevin Wolf wrote: Am 20.05.2010 08:09, schrieb Avi Kivity: On 05/20/2010 12:09 AM, Kevin Wolf wrote: Actually it's not that obvious. If the actual problem here (besides the mis-comparison) is due to missing barriers or flushes. Avi asked a good questi

Re: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-20 Thread Kevin Wolf
Am 20.05.2010 08:09, schrieb Avi Kivity: > On 05/20/2010 12:09 AM, Kevin Wolf wrote: >> >>> Actually it's not that obvious. If the actual problem >>> here (besides the mis-comparison) is due to missing >>> barriers or flushes. Avi asked a good question in that >>> thread. >>> >> It's obviou

Re: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-19 Thread Avi Kivity
On 05/20/2010 12:09 AM, Kevin Wolf wrote: Actually it's not that obvious. If the actual problem here (besides the mis-comparison) is due to missing barriers or flushes. Avi asked a good question in that thread. It's obvious that it's a hack. It doesn't fix anything, it just disables a

Re: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-19 Thread Kevin Wolf
Am Mittwoch, 19. Mai 2010 21:42 schrieb Michael Tokarev: > 19.05.2010 23:38, Christoph Hellwig wrote: > > On Wed, May 19, 2010 at 11:26:58PM +0400, Michael Tokarev wrote: > >> Now the question is if the previous patch by Avi is actually > >> worth to apply -- I mean this one: > >> [Qemu-devel] [P

[Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-19 Thread Michael Tokarev
19.05.2010 23:38, Christoph Hellwig wrote: On Wed, May 19, 2010 at 11:26:58PM +0400, Michael Tokarev wrote: Now the question is if the previous patch by Avi is actually worth to apply -- I mean this one: [Qemu-devel] [PATCH +stable] block: don't attempt to merge overlapping requests No, th

[Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-19 Thread Christoph Hellwig
On Wed, May 19, 2010 at 11:26:58PM +0400, Michael Tokarev wrote: > Now the question is if the previous patch by Avi is actually > worth to apply -- I mean this one: > [Qemu-devel] [PATCH +stable] block: don't attempt to merge overlapping > requests No, that was just a hack, it shouldn't be appl

[Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare

2010-05-19 Thread Michael Tokarev
19.05.2010 22:53, Christoph Hellwig wrote: The difference between the start sectors of two requests can be larger than the size of the "int" type, which can lead to a not correctly sorted multiwrite array and thus spurious I/O errors and filesystem corruption due to incorrect request merges. So