[Qemu-devel] Re: [PATCH] Use sigwait instead of sigwaitinfo.

2011-02-18 Thread Jan Kiszka
On 2011-02-18 16:50, Tristan Gingold wrote: > > On Feb 18, 2011, at 4:34 PM, Jan Kiszka wrote: >> >> This and the above handling of sigwait return codes changes the error >> handling strategy. > > Did it ? I don't think so. > >> So far we silently skipped errors, now we silently >> terminate th

[Qemu-devel] Re: [PATCH] Use sigwait instead of sigwaitinfo.

2011-02-18 Thread Tristan Gingold
On Feb 18, 2011, at 4:34 PM, Jan Kiszka wrote: > > This and the above handling of sigwait return codes changes the error > handling strategy. Did it ? I don't think so. > So far we silently skipped errors, now we silently > terminate the compatfd thread. I think none of both approaches is good

[Qemu-devel] Re: [PATCH] Use sigwait instead of sigwaitinfo.

2011-02-18 Thread Jan Kiszka
On 2011-02-18 14:17, Tristan Gingold wrote: > Fix compilation failure on Darwin. > > Signed-off-by: Tristan Gingold > --- > compatfd.c | 36 ++-- > 1 files changed, 18 insertions(+), 18 deletions(-) > > diff --git a/compatfd.c b/compatfd.c > index a7cebc4..bd37

[Qemu-devel] Re: [PATCH] Use sigwait instead of sigwaitinfo.

2011-02-18 Thread Paolo Bonzini
On 02/18/2011 02:17 PM, Tristan Gingold wrote: Fix compilation failure on Darwin. Signed-off-by: Tristan Gingold --- compatfd.c | 36 ++-- 1 files changed, 18 insertions(+), 18 deletions(-) diff --git a/compatfd.c b/compatfd.c index a7cebc4..bd377c4 100644 -