[Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-28 Thread Anthony Liguori
On 02/28/2011 03:13 AM, Avi Kivity wrote: On 02/28/2011 10:57 AM, Paolo Bonzini wrote: On 02/28/2011 09:20 AM, Avi Kivity wrote: We should have another abstraction for connection based backend. I'll take a go at this when I'm ready to try to get those patches in. Shouldn't each new connecti

[Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-28 Thread Paolo Bonzini
On 02/28/2011 10:13 AM, Avi Kivity wrote: You would need a kind of "factory" interface that knows how to create a new {monitor,serial port,you name it} for each new connection. Actually it doesn't make much sense except for monitors. Monitors and vnc. True, but vnc is not a chardev and it

[Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-28 Thread Avi Kivity
On 02/28/2011 10:57 AM, Paolo Bonzini wrote: On 02/28/2011 09:20 AM, Avi Kivity wrote: We should have another abstraction for connection based backend. I'll take a go at this when I'm ready to try to get those patches in. Shouldn't each new connection return a chardev? You would need a kin

[Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-28 Thread Paolo Bonzini
On 02/28/2011 09:20 AM, Avi Kivity wrote: We should have another abstraction for connection based backend. I'll take a go at this when I'm ready to try to get those patches in. Shouldn't each new connection return a chardev? You would need a kind of "factory" interface that knows how to cre

Re: [Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-28 Thread Avi Kivity
On 02/28/2011 06:01 AM, Anthony Liguori wrote: It would be a pity to divorce the monitor from chardevs, they're really flexible. Couple considerations: 1) chardevs don't support multiple simultaneous connections. I view this as a blocker for QMP. What do you mean by that? Something l

Re: [Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-27 Thread Anthony Liguori
On 02/27/2011 05:33 AM, Avi Kivity wrote: On 02/24/2011 07:25 PM, Anthony Liguori wrote: Is it really necessary? What's blocking us from initializing chardevs early? Well We initialize all chardevs at once right now and what set of chardevs there are depends on the machine (by the way

Re: [Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-27 Thread Avi Kivity
On 02/24/2011 07:25 PM, Anthony Liguori wrote: Is it really necessary? What's blocking us from initializing chardevs early? Well We initialize all chardevs at once right now and what set of chardevs there are depends on the machine (by the way defaults are applied). You could initiali

Re: [Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-24 Thread Anthony Liguori
On 02/24/2011 10:01 AM, Avi Kivity wrote: On 02/24/2011 01:12 AM, Anthony Liguori wrote: What is the plan from here? 1) Decouple QMP from qemu_machine_init(). This really requires the introduction of the new QAPI server that exists outside of the chardev infrastructure since chardevs are c

Re: [Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-24 Thread Avi Kivity
On 02/24/2011 01:12 AM, Anthony Liguori wrote: What is the plan from here? 1) Decouple QMP from qemu_machine_init(). This really requires the introduction of the new QAPI server that exists outside of the chardev infrastructure since chardevs are currently initialized in qemu_machine_init(

Re: [Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-24 Thread Anthony Liguori
On 02/24/2011 04:19 AM, Stefan Hajnoczi wrote: Any chance of reusing info qtree, QemuOpts, or other existing infrastructure for the config file? I'm nowhere near implementation details like that. I'm still trying to understand whether this is a Good Idea at all. Regards, Anthony Liguo

Re: [Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-24 Thread Stefan Hajnoczi
On Thu, Feb 24, 2011 at 12:36 AM, Anthony Liguori wrote: > On 02/23/2011 05:38 PM, Juan Quintela wrote: >> >> Anthony Liguori  wrote: >> >>> >>> On 02/23/2011 05:00 PM, Juan Quintela wrote: >>> Anthony Liguori   wrote: > > The goal is to enable the monitor to run indepe

Re: [Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-23 Thread Anthony Liguori
On 02/23/2011 05:38 PM, Juan Quintela wrote: Anthony Liguori wrote: On 02/23/2011 05:00 PM, Juan Quintela wrote: Anthony Liguori wrote: The goal is to enable the monitor to run independently of whether the machine has been created such that the monitor can be used to spec

[Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-23 Thread Juan Quintela
Anthony Liguori wrote: > On 02/23/2011 05:00 PM, Juan Quintela wrote: >> Anthony Liguori wrote: >> >>> The goal is to enable the monitor to run independently of whether the >>> machine >>> has been created such that the monitor can be used to specify all of the >>> parameters for machine ini

Re: [Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-23 Thread Anthony Liguori
On 02/23/2011 05:00 PM, Juan Quintela wrote: Anthony Liguori wrote: The goal is to enable the monitor to run independently of whether the machine has been created such that the monitor can be used to specify all of the parameters for machine initialization. Signed-off-by: Anthony Liguori

[Qemu-devel] Re: [PATCH] Split machine creation from the main loop

2011-02-23 Thread Juan Quintela
Anthony Liguori wrote: > The goal is to enable the monitor to run independently of whether the machine > has been created such that the monitor can be used to specify all of the > parameters for machine initialization. > > Signed-off-by: Anthony Liguori I agree that it is one step in the right d