Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Anthony Liguori
On 05/14/2010 10:02 AM, Daniel P. Berrange wrote: On Fri, May 14, 2010 at 09:52:53AM -0500, Anthony Liguori wrote: On 05/14/2010 09:42 AM, Daniel P. Berrange wrote: It is preferable to query the explicit capability wanted, because version numbers are useless when distros backport feat

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Daniel P. Berrange
On Fri, May 14, 2010 at 09:52:53AM -0500, Anthony Liguori wrote: > On 05/14/2010 09:42 AM, Daniel P. Berrange wrote: > > > >It is preferable to query the explicit capability wanted, because > >version numbers are useless when distros backport features, > > Unless distros add their own release numb

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Anthony Liguori
On 05/14/2010 09:42 AM, Daniel P. Berrange wrote: It is preferable to query the explicit capability wanted, because version numbers are useless when distros backport features, Unless distros add their own release number to the version information and libvirt learns about the features they add

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Daniel P. Berrange
On Fri, May 14, 2010 at 09:22:55AM -0500, Anthony Liguori wrote: > On 05/14/2010 08:54 AM, Daniel P. Berrange wrote: > >On Fri, May 14, 2010 at 08:24:09AM -0500, Anthony Liguori wrote: > > > >>On 05/13/2010 08:07 AM, Jes Sorensen wrote: > >> > >>>On 05/13/10 15:04, Cole Robinson wrote: > >>

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Anthony Liguori
On 05/14/2010 08:54 AM, Daniel P. Berrange wrote: On Fri, May 14, 2010 at 08:24:09AM -0500, Anthony Liguori wrote: On 05/13/2010 08:07 AM, Jes Sorensen wrote: On 05/13/10 15:04, Cole Robinson wrote: On 05/13/2010 04:35 AM, Jes Sorensen wrote: On 05/12/10 22:48, C

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Daniel P. Berrange
On Fri, May 14, 2010 at 08:24:09AM -0500, Anthony Liguori wrote: > On 05/13/2010 08:07 AM, Jes Sorensen wrote: > >On 05/13/10 15:04, Cole Robinson wrote: > > > >>On 05/13/2010 04:35 AM, Jes Sorensen wrote: > >> > >>>On 05/12/10 22:48, Cole Robinson wrote: > >>>I think rather than 1, it woul

[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Anthony Liguori
On 05/13/2010 08:07 AM, Jes Sorensen wrote: On 05/13/10 15:04, Cole Robinson wrote: On 05/13/2010 04:35 AM, Jes Sorensen wrote: On 05/12/10 22:48, Cole Robinson wrote: I think rather than 1, it would be better to add a patch to libvirt to catch both formats. I know Chris Lalancette al

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Daniel P. Berrange
On Fri, May 14, 2010 at 08:17:50AM -0500, Anthony Liguori wrote: > On 05/12/2010 03:48 PM, Cole Robinson wrote: > >On 05/12/2010 04:38 PM, Jes Sorensen wrote: > > > >>On 05/12/10 22:29, Cole Robinson wrote: > >> > >>>Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version > >>>s

[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Anthony Liguori
On 05/12/2010 03:48 PM, Cole Robinson wrote: On 05/12/2010 04:38 PM, Jes Sorensen wrote: On 05/12/10 22:29, Cole Robinson wrote: Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version string from: QEMU PC Emulator version x.yy.z to QEMU Emulator version x.yy.z libvirt

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-13 Thread Stuart Brady
On Thu, May 13, 2010 at 10:20:39PM +0300, Blue Swirl wrote: > Fully agree. > > I think even better line would be 'QEMU System Emulator..'. Silly idea perhaps, but why not include the target name, e.g. 'QEMU i386 System Emulator'? It only seems reasonable to me for the different binaries to produ

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-13 Thread Blue Swirl
On 5/13/10, Paul Brook wrote: > > > But that is no different from what we have today. Users who update their > > > qemu and see issues with libvirt can also be asked to update libvirt. I > > > have already had several cases where I needed to do that anyway. > > > > The general policy of QEMU h

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-13 Thread Paul Brook
> > But that is no different from what we have today. Users who update their > > qemu and see issues with libvirt can also be asked to update libvirt. I > > have already had several cases where I needed to do that anyway. > > The general policy of QEMU has been to try and avoid known breakage of

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-13 Thread Luiz Capitulino
On Thu, 13 May 2010 14:21:02 +0100 "Daniel P. Berrange" wrote: > On Thu, May 13, 2010 at 03:07:49PM +0200, Jes Sorensen wrote: > > On 05/13/10 15:04, Cole Robinson wrote: > > > On 05/13/2010 04:35 AM, Jes Sorensen wrote: > > >> On 05/12/10 22:48, Cole Robinson wrote: > > >> I think rather than 1,

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-13 Thread Daniel P. Berrange
On Thu, May 13, 2010 at 03:07:49PM +0200, Jes Sorensen wrote: > On 05/13/10 15:04, Cole Robinson wrote: > > On 05/13/2010 04:35 AM, Jes Sorensen wrote: > >> On 05/12/10 22:48, Cole Robinson wrote: > >> I think rather than 1, it would be better to add a patch to libvirt to > >> catch both formats. I

[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-13 Thread Jes Sorensen
On 05/13/10 15:04, Cole Robinson wrote: > On 05/13/2010 04:35 AM, Jes Sorensen wrote: >> On 05/12/10 22:48, Cole Robinson wrote: >> I think rather than 1, it would be better to add a patch to libvirt to >> catch both formats. I know Chris Lalancette already cooked up a patch >> for this. Combined w

[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-13 Thread Cole Robinson
On 05/13/2010 04:35 AM, Jes Sorensen wrote: > On 05/12/10 22:48, Cole Robinson wrote: >> I agree libvirt's method is a crappy approach. Adding a proper -version >> argument is certainly the way forward, but doesn't help users with >> existing libvirt installations that want to use latest qemu. This

[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-13 Thread Jes Sorensen
On 05/12/10 22:48, Cole Robinson wrote: > I agree libvirt's method is a crappy approach. Adding a proper -version > argument is certainly the way forward, but doesn't help users with > existing libvirt installations that want to use latest qemu. This is the > type of issue that libvirt devs will be

[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-12 Thread Cole Robinson
On 05/12/2010 04:38 PM, Jes Sorensen wrote: > On 05/12/10 22:29, Cole Robinson wrote: >> Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version >> string from: >> >> QEMU PC Emulator version x.yy.z >> >> to >> >> QEMU Emulator version x.yy.z >> >> libvirt is overly sensitive to the for

[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-12 Thread Jes Sorensen
On 05/12/10 22:29, Cole Robinson wrote: > Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version > string from: > > QEMU PC Emulator version x.yy.z > > to > > QEMU Emulator version x.yy.z > > libvirt is overly sensitive to the format of this string, and barfs when > trying to parse