[Qemu-devel] Re: [PATCH, try 2] qemu/tap: add -net tap,dev= option

2009-12-10 Thread Arnd Bergmann
On Wednesday 09 December 2009, Anthony Liguori wrote: > This isn't really a generic thing and I dislike pretending it is. This > is specifically for macvtap. Well, depending how how things work out with VMD-q and SR-IOV, I might move the tap interface stuff into a library module and add more use

[Qemu-devel] Re: [PATCH, try 2] qemu/tap: add -net tap,dev= option

2009-12-09 Thread Anthony Liguori
Arnd Bergmann wrote: In order to support macvtap, we need a way to select the actual tap endpoint. While it would be nice to pass it by network interface name, passing the character device is more flexible, and we can easily do both in the long run. Signed-off-by: Arnd Bergmann This isn't

[Qemu-devel] Re: [PATCH, try 2] qemu/tap: add -net tap,dev= option

2009-12-09 Thread Michael S. Tsirkin
On Wed, Dec 09, 2009 at 01:33:36PM +0100, Arnd Bergmann wrote: > On Wednesday 09 December 2009, Michael S. Tsirkin wrote: > > On Tue, Dec 08, 2009 at 06:41:44PM +0100, Arnd Bergmann wrote: > > > --- a/net/tap-bsd.c > > > +++ b/net/tap-bsd.c > > > @@ -40,7 +40,8 @@ > > > #include > > > #endif > >

Re: [Qemu-devel] Re: [PATCH, try 2] qemu/tap: add -net tap, dev= option

2009-12-09 Thread Christoph Egger
On Wednesday 09 December 2009 13:33:36 Arnd Bergmann wrote: > On Wednesday 09 December 2009, Michael S. Tsirkin wrote: > > On Tue, Dec 08, 2009 at 06:41:44PM +0100, Arnd Bergmann wrote: > > > --- a/net/tap-bsd.c > > > +++ b/net/tap-bsd.c > > > @@ -40,7 +40,8 @@ > > > #include > > > #endif > > >

[Qemu-devel] Re: [PATCH, try 2] qemu/tap: add -net tap,dev= option

2009-12-09 Thread Arnd Bergmann
On Wednesday 09 December 2009, Michael S. Tsirkin wrote: > On Tue, Dec 08, 2009 at 06:41:44PM +0100, Arnd Bergmann wrote: > > --- a/net/tap-bsd.c > > +++ b/net/tap-bsd.c > > @@ -40,7 +40,8 @@ > > #include > > #endif > > > > -int tap_open(char *ifname, int ifname_size, int *vnet_hdr, int > > v

[Qemu-devel] Re: [PATCH, try 2] qemu/tap: add -net tap,dev= option

2009-12-09 Thread Michael S. Tsirkin
On Tue, Dec 08, 2009 at 06:41:44PM +0100, Arnd Bergmann wrote: > In order to support macvtap, we need a way to select the actual > tap endpoint. While it would be nice to pass it by network interface > name, passing the character device is more flexible, and we can > easily do both in the long run.