On Thu, 24 Mar 2011 10:54:05 +0100, Christian Borntraeger
wrote:
> Am 24.03.2011 04:05, schrieb Anthony Liguori:
> >> ie. lguest and S/390 don't trap writes to config space.
> >>
> >> Or perhaps they should? But we should be explicit about needing it...
> > I don't think we ever operated on the
Am 24.03.2011 04:05, schrieb Anthony Liguori:
>> ie. lguest and S/390 don't trap writes to config space.
>>
>> Or perhaps they should? But we should be explicit about needing it...
> I don't think we ever operated on the assumption that config space writes
> would trap.
>
> I don't think adding
On 03/17/2011 09:21 AM, Christoph Hellwig wrote:
On Thu, Mar 17, 2011 at 03:36:08PM +1030, Rusty Russell wrote:
I'm happ to switch strcmp.
Of course, that's assuming buf is nul terminated.
It's the string the user writes into it, which normally should be
nul-terminated.
No, it's intentional.
On 03/17/2011 12:06 AM, Rusty Russell wrote:
On Wed, 16 Mar 2011 15:09:58 +0100, Christoph Hellwig wrote:
On Wed, Mar 16, 2011 at 02:39:39PM +1030, Rusty Russell wrote:
+ if (strncmp(buf, "write through", sizeof("write through") - 1) == 0) {
+ ;
+ } else if (strncmp(b
On Thu, 17 Mar 2011 15:21:22 +0100, Christoph Hellwig wrote:
> On Thu, Mar 17, 2011 at 03:36:08PM +1030, Rusty Russell wrote:
> > OK, under what circumstances could it fail?
> >
> > If you're using this mechanism to indicate that the host doesn't support
> > the feature, that's making an assumpti
On Thu, Mar 17, 2011 at 03:36:08PM +1030, Rusty Russell wrote:
> > I'm happ to switch strcmp.
>
> Of course, that's assuming buf is nul terminated.
It's the string the user writes into it, which normally should be
nul-terminated.
> > No, it's intentional. config space writes can't return errors
On Wed, 16 Mar 2011 15:09:58 +0100, Christoph Hellwig wrote:
> On Wed, Mar 16, 2011 at 02:39:39PM +1030, Rusty Russell wrote:
> > > + if (strncmp(buf, "write through", sizeof("write through") - 1) == 0) {
> > > + ;
> > > + } else if (strncmp(buf, "write back", sizeof("write back") - 1) ==
On Wed, Mar 16, 2011 at 02:39:39PM +1030, Rusty Russell wrote:
> > + if (strncmp(buf, "write through", sizeof("write through") - 1) == 0) {
> > + ;
> > + } else if (strncmp(buf, "write back", sizeof("write back") - 1) == 0) {
>
>Is there a reason we're not letting gcc and/or strc
On Tue, 15 Mar 2011 15:16:44 +0100, Christoph Hellwig wrote:
> Add support for the new dynamic features config space field to allow
> en/disabling the write cache at runtime. The userspace interface is
> a SCSI-compatible sysfs attribute.
>
> Signed-off-by: Christoph Hellwig
Hi Christoph,
