[Qemu-devel] Re: [FOR 0.12][PATCH] target-i386: Fix evaluation of DR7 register

2009-12-15 Thread Jan Kiszka
TeLeMan wrote: >> Now to the content: env already equals single_cpu_env, so there is no >> need in writing it back. That's because break/watchpoints are triggered >> synchronously over the context in which they may raise an exception as >> result. > env in op_help.c is asm(AREG0) not single_cpu_env

[Qemu-devel] Re: [FOR 0.12][PATCH] target-i386: Fix evaluation of DR7 register

2009-12-15 Thread TeLeMan
> Now to the content: env already equals single_cpu_env, so there is no > need in writing it back. That's because break/watchpoints are triggered > synchronously over the context in which they may raise an exception as > result. env in op_help.c is asm(AREG0) not single_cpu_env. Did you test your c

[Qemu-devel] Re: [FOR 0.12][PATCH] target-i386: Fix evaluation of DR7 register

2009-12-15 Thread Jan Kiszka
TeLeMan wrote: > raise_exception() in op_helper.c should not be used outside > op_helper.c because of tcg. This patch uses raise_exception2() instead > of raise_exception(). Please do not post new patches as reply to others if they are not directly related. Please do not attach patches and do not