[Qemu-devel] [RFC] Fix for random Qemu crashes

2007-11-18 Thread J. Mayer
Here's an updated patch to fix the inlining problems that make some Qemu targets crash randomly. As we have at least one broken target in the CVS because of this bug (and maybe more), we have an urgent need of a fix. I'll then commit this patch today if there is no other fix proposed that actually

Re: [Qemu-devel] RFC: fix for random Qemu crashes

2007-11-17 Thread J. Mayer
On Sat, 2007-11-17 at 11:57 +0100, andrzej zaborowski wrote: > On 17/11/2007, J. Mayer <[EMAIL PROTECTED]> wrote: > > > > On Fri, 2007-11-16 at 21:32 +0100, andrzej zaborowski wrote: > > > On 16/11/2007, Jocelyn Mayer <[EMAIL PROTECTED]> wrote: > > > > > > > > On Fri, 2007-11-16 at 15:52 +, Pa

Re: [Qemu-devel] RFC: fix for random Qemu crashes

2007-11-17 Thread andrzej zaborowski
On 17/11/2007, J. Mayer <[EMAIL PROTECTED]> wrote: > > On Fri, 2007-11-16 at 21:32 +0100, andrzej zaborowski wrote: > > On 16/11/2007, Jocelyn Mayer <[EMAIL PROTECTED]> wrote: > > > > > > On Fri, 2007-11-16 at 15:52 +, Paul Brook wrote: > > > > > Then, I choosed to replace 'inline' by 'always_i

Re: [Qemu-devel] RFC: fix for random Qemu crashes

2007-11-16 Thread J. Mayer
On Fri, 2007-11-16 at 21:32 +0100, andrzej zaborowski wrote: > On 16/11/2007, Jocelyn Mayer <[EMAIL PROTECTED]> wrote: > > > > On Fri, 2007-11-16 at 15:52 +, Paul Brook wrote: > > > > Then, I choosed to replace 'inline' by 'always_inline', which is more > > > > invasive but have less risks of

Re: [Qemu-devel] RFC: fix for random Qemu crashes

2007-11-16 Thread andrzej zaborowski
On 16/11/2007, Jocelyn Mayer <[EMAIL PROTECTED]> wrote: > > On Fri, 2007-11-16 at 15:52 +, Paul Brook wrote: > > > Then, I choosed to replace 'inline' by 'always_inline', which is more > > > invasive but have less risks of side effects. The diff is attached in > > > always_inline.diff. > > > Th

Re: [Qemu-devel] RFC: fix for random Qemu crashes

2007-11-16 Thread Jocelyn Mayer
On Fri, 2007-11-16 at 15:59 +, Jamie Lokier wrote: > Heikki Lindholm wrote: > > J. Mayer kirjoitti: > > >Some may have experienced of having some Qemu builds crashing, > > >apparently at random places, but in a reproducable way. > > >I found one reason for this crashes: it appears that with th

Re: [Qemu-devel] RFC: fix for random Qemu crashes

2007-11-16 Thread Jamie Lokier
Heikki Lindholm wrote: > J. Mayer kirjoitti: > >Some may have experienced of having some Qemu builds crashing, > >apparently at random places, but in a reproducable way. > >I found one reason for this crashes: it appears that with the growth of > >the op.c file, there may be cases where we could re

Re: [Qemu-devel] RFC: fix for random Qemu crashes

2007-11-16 Thread Jocelyn Mayer
On Fri, 2007-11-16 at 17:42 +0200, Heikki Lindholm wrote: > Jocelyn Mayer kirjoitti: > > On Fri, 2007-11-16 at 17:06 +0200, Heikki Lindholm wrote: > >> J. Mayer kirjoitti: > >>> Some may have experienced of having some Qemu builds crashing, > >>> apparently at random places, but in a reproducable

Re: [Qemu-devel] RFC: fix for random Qemu crashes

2007-11-16 Thread Jocelyn Mayer
On Fri, 2007-11-16 at 15:52 +, Paul Brook wrote: > > Then, I choosed to replace 'inline' by 'always_inline', which is more > > invasive but have less risks of side effects. The diff is attached in > > always_inline.diff. > > The last thing that helps solve the problem is to change the inlining

Re: [Qemu-devel] RFC: fix for random Qemu crashes

2007-11-16 Thread Heikki Lindholm
Jocelyn Mayer kirjoitti: On Fri, 2007-11-16 at 17:06 +0200, Heikki Lindholm wrote: J. Mayer kirjoitti: Some may have experienced of having some Qemu builds crashing, apparently at random places, but in a reproducable way. I found one reason for this crashes: it appears that with the growth of t

Re: [Qemu-devel] RFC: fix for random Qemu crashes

2007-11-16 Thread Paul Brook
> Then, I choosed to replace 'inline' by 'always_inline', which is more > invasive but have less risks of side effects. The diff is attached in > always_inline.diff. > The last thing that helps solve the problem is to change the inlining > limits of gcc, at least to compile the op.o file. Presumab

Re: [Qemu-devel] RFC: fix for random Qemu crashes

2007-11-16 Thread Jocelyn Mayer
On Fri, 2007-11-16 at 17:06 +0200, Heikki Lindholm wrote: > J. Mayer kirjoitti: > > Some may have experienced of having some Qemu builds crashing, > > apparently at random places, but in a reproducable way. > > I found one reason for this crashes: it appears that with the growth of > > the op.c fi

Re: [Qemu-devel] RFC: fix for random Qemu crashes

2007-11-16 Thread Heikki Lindholm
J. Mayer kirjoitti: Some may have experienced of having some Qemu builds crashing, apparently at random places, but in a reproducable way. I found one reason for this crashes: it appears that with the growth of the op.c file, there may be cases where we could reach the inlining limits of gcc. In

Re: [Qemu-devel] RFC: fix for random Qemu crashes

2007-11-15 Thread J. Mayer
On Fri, 2007-11-16 at 00:49 +0100, andrzej zaborowski wrote: > Hi, > > On 16/11/2007, J. Mayer <[EMAIL PROTECTED]> wrote: > > Some may have experienced of having some Qemu builds crashing, > > apparently at random places, but in a reproducable way. > > I found one reason for this crashes: it appe

Re: [Qemu-devel] RFC: fix for random Qemu crashes

2007-11-15 Thread andrzej zaborowski
Hi, On 16/11/2007, J. Mayer <[EMAIL PROTECTED]> wrote: > Some may have experienced of having some Qemu builds crashing, > apparently at random places, but in a reproducable way. > I found one reason for this crashes: it appears that with the growth of > the op.c file, there may be cases where we c

[Qemu-devel] RFC: fix for random Qemu crashes

2007-11-15 Thread J. Mayer
Some may have experienced of having some Qemu builds crashing, apparently at random places, but in a reproducable way. I found one reason for this crashes: it appears that with the growth of the op.c file, there may be cases where we could reach the inlining limits of gcc. In such a case, gcc would