[Qemu-devel] Re: [kvm-devel] [PATCH] Dynamic ticks

2007-08-16 Thread Dan Kenigsberg
Luca, One more comment on your patch: the logic in the following condition does not fit the comment bellow it. On Mon, Aug 13, 2007 at 10:37:41PM +0200, Luca Tettamanti wrote: > +if (use_dynamic_ticks() && dynticks_create_timer()) { > +/* dynticks disabled or failed to create

[Qemu-devel] RE: [kvm-devel] [PATCH] Dynamic ticks

2007-08-15 Thread Dor Laor
>> I like it ;) I have some comments (and a reworked patch at the end): >> > >And thanks a lot for that. > >> >> Plus, in this way you change the behaviour from "always try RTC under >> Linux" to "don't use RTC is dynticks is enabled". >> Is this what you really want? > >I don't know whether this i

Re: [Qemu-devel] Re: [kvm-devel] [PATCH] Dynamic ticks

2007-08-13 Thread Thiemo Seufer
Luca Tettamanti wrote: [snip] > I've implemented some of my suggestions in the following patch - rebased > to kvm-userspace current git since it's easier to test (...ok, I'm lazy - > but you get the idea): > > > diff --git a/qemu/configure b/qemu/configure > index 365b7fb..38373db 100755 > --- a/

[Qemu-devel] Re: [kvm-devel] [PATCH] Dynamic ticks

2007-08-13 Thread Luca Tettamanti
Il Mon, Aug 13, 2007 at 05:42:55PM +0300, Dan Kenigsberg ha scritto: > "Dynamic ticks" in Qemu: have a SIGALRM generated only when it is > needed, instead of every 1 millisecond. This patch requires that the > host supports high resolution timers, since it arms a POSIX timer to the > nearest Qemu