Re: [Qemu-devel] Question on aio_poll

2013-07-24 Thread Alex Bligh
Stefan, --On 24 July 2013 09:54:39 +0200 Stefan Hajnoczi wrote: I left this how it was in the end (I think), and got round it by creating a bogus pipe for the test to listen to. Doing that requires the changes in my patch series, otherwise you break aio_poll() loops that are waiting for pend

Re: [Qemu-devel] Question on aio_poll

2013-07-24 Thread Stefan Hajnoczi
On Tue, Jul 23, 2013 at 03:46:23PM +0100, Alex Bligh wrote: > --On 23 July 2013 14:18:25 +0200 Stefan Hajnoczi wrote: > >Unfortunately there is an issue with the series which I haven't had time > >to look into yet. I don't remember the details but I think make check > >is failing. > > > >The curr

Re: [Qemu-devel] Question on aio_poll

2013-07-23 Thread Alex Bligh
Stefan, --On 23 July 2013 14:18:25 +0200 Stefan Hajnoczi wrote: Secondly, the tests I am writing for the timer fail because g_poll is not called, because busy is false. This is because I haven't got an fd set up. But in the instance where aio_poll is called with blocking=true and there are no

Re: [Qemu-devel] Question on aio_poll

2013-07-23 Thread Stefan Hajnoczi
On Sat, Jul 20, 2013 at 02:14:43PM +0100, Alex Bligh wrote: > As part of adding timer operations to aio_poll and a clock to AioContext, I > am trying to figure out a couple of points on how aio_poll works. This > primarily revolves around the flag busy. > > Firstly, at the end of aio_poll, it has

[Qemu-devel] Question on aio_poll

2013-07-20 Thread Alex Bligh
As part of adding timer operations to aio_poll and a clock to AioContext, I am trying to figure out a couple of points on how aio_poll works. This primarily revolves around the flag busy. Firstly, at the end of aio_poll, it has assert(progress || busy); This assert in fact checks nothing, be