Re: [Qemu-devel] Question nbd_refresh_filename()

2017-03-27 Thread Stefan Hajnoczi
On Fri, Mar 24, 2017 at 06:48:44PM +0100, Kevin Wolf wrote: > Am 24.03.2017 um 16:47 hat Stefan Hajnoczi geschrieben: > > On Thu, Mar 23, 2017 at 05:48:48PM +0100, Markus Armbruster wrote: > > > BlockdevOptionsNbd has a member SocketAddress, and nbd_config() doesn't > > > restrict variants. Thus,

Re: [Qemu-devel] Question nbd_refresh_filename()

2017-03-24 Thread Kevin Wolf
Am 24.03.2017 um 16:47 hat Stefan Hajnoczi geschrieben: > On Thu, Mar 23, 2017 at 05:48:48PM +0100, Markus Armbruster wrote: > > BlockdevOptionsNbd has a member SocketAddress, and nbd_config() doesn't > > restrict variants. Thus, all four SOCKET_ADDRESS_KIND_ can occur. > > > > Now have a look at

Re: [Qemu-devel] Question nbd_refresh_filename()

2017-03-24 Thread Stefan Hajnoczi
On Thu, Mar 23, 2017 at 05:48:48PM +0100, Markus Armbruster wrote: > BlockdevOptionsNbd has a member SocketAddress, and nbd_config() doesn't > restrict variants. Thus, all four SOCKET_ADDRESS_KIND_ can occur. > > Now have a look at nbd_refresh_filename(). s->saddr->type is If > SOCKET_ADDRESS_KI

[Qemu-devel] Question nbd_refresh_filename()

2017-03-23 Thread Markus Armbruster
BlockdevOptionsNbd has a member SocketAddress, and nbd_config() doesn't restrict variants. Thus, all four SOCKET_ADDRESS_KIND_ can occur. Now have a look at nbd_refresh_filename(). s->saddr->type is If SOCKET_ADDRESS_KIND_VSOCK or SOCKET_ADDRESS_KIND_FD, then @host, @port and @path all remain nu