Re: [Qemu-devel] [Qemu-riscv] [PATCH] riscv: sifive_e: Correct various SoC IP block sizes

On Mon, Jun 22, 2020 at 11:36 PM Bin Meng wrote: > > Hi, > > On Thu, Sep 5, 2019 at 2:34 AM Palmer Dabbelt wrote: > > > > On Tue, 03 Sep 2019 20:41:52 PDT (-0700), bmeng...@gmail.com wrote: > > > Palmer, > > > > > > On Wed, Aug 14, 2019 at 5:34 PM Bin Meng wrote: > > >> > > >> Hi Palmer, > > >>

Re: [Qemu-devel] [Qemu-riscv] [PATCH] riscv: sifive_e: Correct various SoC IP block sizes

Hi, On Thu, Sep 5, 2019 at 2:34 AM Palmer Dabbelt wrote: > > On Tue, 03 Sep 2019 20:41:52 PDT (-0700), bmeng...@gmail.com wrote: > > Palmer, > > > > On Wed, Aug 14, 2019 at 5:34 PM Bin Meng wrote: > >> > >> Hi Palmer, > >> > >> On Wed, Aug 7, 2019 at 10:53 AM Bin Meng wrote: > >> > > >> > On We

FYI: The daily digest email for qemu-devel/qemu-arm didn't go out today

I hope to fix it tomorrow, but I can't be sure. Maybe it will fix itself and I'll just abandon the digest for today. Very few people use the digest feature, normally it goes out at noonish eastern time. All I've had time to do done is grab a stack trace, seems like there's some characters in an em

Re: [Qemu-devel] [Qemu-riscv] [PATCH v1 10/28] target/riscv: Convert mie and mstatus to pointers

On Thu, Sep 19, 2019 at 9:59 AM Jonathan Behrens wrote: > > On Thu, Sep 19, 2019 at 10:50 AM Richard Henderson > wrote: > > > > On 9/18/19 4:47 PM, Alistair Francis wrote: > > > I'm not a fan of the pointer method that I'm using, but to me it seems > > > the least worst in terms of handling futur

Re: [Qemu-devel] [Qemu-block] [PATCH 16/16] nvme: support multiple namespaces

On Wed, Sep 25, 2019 at 11:33:45AM +, Paul Durrant wrote: > Hi Klaus, > > I may have missed something but are you planning a v2 of your > nvme_ns series soon? I just ran into another issue with this version > when trying to use non-consecutive nsid value; the code uses an > array of ns

RE: [Qemu-devel] [Qemu-block] [PATCH 16/16] nvme: support multiple namespaces

> -Original Message- > From: Klaus Jensen > Sent: 25 September 2019 13:15 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; Paul Durrant > Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 16/16] nvme: support multiple > namespaces > > On Wed, Sep 25, 2019 at 11:

Re: [Qemu-devel] [Qemu-block] [PATCH 16/16] nvme: support multiple namespaces

Hi Klaus, I may have missed something but are you planning a v2 of your nvme_ns series soon? I just ran into another issue with this version when trying to use non-consecutive nsid value; the code uses an array of ns indexed by the nsid, and using non-consecutive values causes it to wander of

Re: [Qemu-devel] [Qemu-riscv] [PATCH v1 10/28] target/riscv: Convert mie and mstatus to pointers

On Thu, Sep 19, 2019 at 10:50 AM Richard Henderson wrote: > > On 9/18/19 4:47 PM, Alistair Francis wrote: > > I'm not a fan of the pointer method that I'm using, but to me it seems > > the least worst in terms of handling future code, keeping everythign > > consistnent and avoiding complex access

Re: [Qemu-devel] [Qemu-riscv] [PATCH v1 10/28] target/riscv: Convert mie and mstatus to pointers

On 9/18/19 4:47 PM, Alistair Francis wrote: > I'm not a fan of the pointer method that I'm using, but to me it seems > the least worst in terms of handling future code, keeping everythign > consistnent and avoiding complex access rules. FWIW, I prefer the "banked" register method used by ARM. enu

[Qemu-devel] [qemu-web PATCH] Gemfile: use a fixed version of sassc

Jekyll failed to run with sassc 2.2.0 due to a LoadError, so the Gemfile was requiring an earlier version (2.1.0 in practice). Since the bug has been fixed, remove the workaround and instead require a fixed version. Signed-off-by: Paolo Bonzini --- Gemfile | 2 +- 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options

Le 19/09/2019 à 13:01, Gerd Hoffmann a écrit : > On Thu, Sep 19, 2019 at 12:16:43PM +0200, Laurent Vivier wrote: >> Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit : >>> On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote: Le 14/09/2019 à 16:51, James Le Cuirot a écrit : > This dep

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options

On Thu, Sep 19, 2019 at 12:16:43PM +0200, Laurent Vivier wrote: > Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit : > > On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote: > >> Le 14/09/2019 à 16:51, James Le Cuirot a écrit : > >>> This dependency is currently "automagic", which is bad for

Re: [Qemu-devel] [Qemu-trivial] [PATCH] kvm: Fix typo in header of kvm_device_access()

Le 12/09/2019 à 15:57, Greg Kurz a écrit : > Signed-off-by: Greg Kurz > --- > include/sysemu/kvm.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > index 909bcd77cf82..fd674772ab31 100644 > --- a/include/sysemu/kvm.h > +++

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options

Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit : > On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote: >> Le 14/09/2019 à 16:51, James Le Cuirot a écrit : >>> This dependency is currently "automagic", which is bad for distributions. >>> >>> Signed-off-by: James Le Cuirot >>> --- >>> con

Re: [Qemu-devel] [Qemu-trivial] [PATCH] kvm: Fix typo in header of kvm_device_access()

Le 12/09/2019 à 15:57, Greg Kurz a écrit : > Signed-off-by: Greg Kurz > --- > include/sysemu/kvm.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > index 909bcd77cf82..fd674772ab31 100644 > --- a/include/sysemu/kvm.h > +++

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target/m68k/fpu_helper.c: rename the access arguments

Le 12/09/2019 à 16:02, KONRAD Frederic a écrit : > The "access" arguments clash with a macro under Windows with MinGW: > CC m68k-softmmu/target/m68k/fpu_helper.o > target/m68k/fpu_helper.c: In function 'fmovem_predec': > target/m68k/fpu_helper.c:405:56: error: macro "access" passed 4 arg

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Replace '-machine accel=xyz' with '-accel xyz'

Le 04/09/2019 à 07:27, Thomas Huth a écrit : > We've got a separate option to configure the accelerator nowadays, which > is shorter to type and the preferred way of specifying an accelerator. > Use it in the source and examples to show that it is the favored option. > (However, do not touch the pl

Re: [Qemu-devel] [Qemu-trivial] [PATCH] cutils: Move size_to_str() from "qemu-common.h" to "qemu/cutils.h"

Le 03/09/2019 à 14:05, Philippe Mathieu-Daudé a écrit : > "qemu/cutils.h" contains various qemu_strtosz_*() functions > useful to convert strings to size. It seems natural to have > the opposite usage (from size to string) there too. > > The function definition is already in util/cutils.c. > > Si

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options

On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote: > Le 14/09/2019 à 16:51, James Le Cuirot a écrit : > > This dependency is currently "automagic", which is bad for distributions. > > > > Signed-off-by: James Le Cuirot > > --- > > configure | 5 + > > 1 file changed, 5 insertion

Re: [Qemu-devel] [Qemu-block] [PATCH] block/backup: install notifier during creation

18.09.2019 23:31, John Snow wrote: > > > On 9/10/19 9:23 AM, John Snow wrote: >> >> >> On 9/10/19 4:19 AM, Stefan Hajnoczi wrote: >>> On Wed, Aug 21, 2019 at 04:01:52PM -0400, John Snow wrote: On 8/21/19 10:41 AM, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 23:13, John Sno

Re: [Qemu-devel] [Qemu-riscv] [PATCH v1 10/28] target/riscv: Convert mie and mstatus to pointers

On Tue, Sep 17, 2019 at 7:00 PM Jonathan Behrens wrote: > > I went through the uses of mie in the entire hypervisor patch series and it > seems like it would be much simpler to just have two non-pointer fields in > the CPU struct: mie and vsie. To if an interrupt is pending, you are either > ru

Re: [Qemu-devel] [Qemu-block] [PATCH] block/backup: install notifier during creation

On 9/10/19 9:23 AM, John Snow wrote: > > > On 9/10/19 4:19 AM, Stefan Hajnoczi wrote: >> On Wed, Aug 21, 2019 at 04:01:52PM -0400, John Snow wrote: >>> >>> >>> On 8/21/19 10:41 AM, Vladimir Sementsov-Ogievskiy wrote: 09.08.2019 23:13, John Snow wrote: > Backup jobs may yield prior to

Re: [Qemu-devel] [Qemu-discuss] Segmentation fault on target tricore

Hi Peter, On 9/17/19 3:45 PM, Peter Maydell wrote: On Tue, 17 Sep 2019 at 14:06, Konopik, Andreas wrote: Using gdb and valgrind I found out that: - 'gen_mtcr()' and 'gen_mfcr()' access uninitialized values, i.e. CSFRs, which leads to the Segfault - The uninitialised values were created by stac

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine

On 9/17/19 1:40 PM, David Gibson wrote: > On Tue, Sep 17, 2019 at 12:19:52PM +1000, David Gibson wrote: >> On Mon, Sep 16, 2019 at 11:56:06AM +0200, Philippe Mathieu-Daudé wrote: >>> On 9/16/19 11:52 AM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: > Hi David, > > O

Re: [Qemu-devel] qemu patches

Hi Ilias, On 9/18/19 10:19 AM, Ilias wrote: > Hi, > > Your recent patch > > https://github.com/qemu/qemu/commit/12e9493df9242a2051701e7eb64175d4e904acba#diff-d98f9b48cc332d226892f0db74a86b87 > > to the file > > target/i386/whpx-all.c >

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] trace: Forbid trailing newline in event format

On Mon, Sep 16, 2019 at 11:51:19AM +0200, Philippe Mathieu-Daudé wrote: > Hi Stefan, > > I'v been confused by trailing newline in trace reports, > so this series aims to fix this, by cleaning current > formats and add a check to catch new one introduced. > > v2: > - Use regex format (easier to re

[Qemu-devel] qemu patches

Hi, Your recent patch https://github.com/qemu/qemu/commit/12e9493df9242a2051701e7eb64175d4e904acba#diff-d98f9b48cc332d226892f0db74a86b87 to the file target/i386/whpx-all.c breaks compilation when WHPX is enabled. Please add #i

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

Alex Bennée writes: > You will need to update gdb-xml/$ARCH.xml and the appropriate arch_read/write register functions in gdbstub. For some mysterious reason my previous emails didn't go to the list successfully. Let me try sending this one without including any code or link. The MIPS targe

Re: [Qemu-devel] [Qemu-riscv] [PATCH v1 10/28] target/riscv: Convert mie and mstatus to pointers

I went through the uses of mie in the entire hypervisor patch series and it seems like it would be much simpler to just have two non-pointer fields in the CPU struct: mie and vsie. To if an interrupt is pending, you are either running with V=0 in which case the contents of vsie can be ignored, or y

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine

On Tue, Sep 17, 2019 at 12:19:52PM +1000, David Gibson wrote: > On Mon, Sep 16, 2019 at 11:56:06AM +0200, Philippe Mathieu-Daudé wrote: > > On 9/16/19 11:52 AM, Alex Bennée wrote: > > > > > > Philippe Mathieu-Daudé writes: > > > > > >> Hi David, > > >> > > >> On 9/16/19 2:42 AM, David Gibson wro

Re: [Qemu-devel] [Qemu-riscv] [PATCH v1 10/28] target/riscv: Convert mie and mstatus to pointers

On Wed, Sep 11, 2019 at 7:55 AM Jonathan Behrens wrote: > > Version 0.4 of the hypervisor spec no longer talks about swapping registers. > Instead when running in VS-mode some of the supervisor registers are > "aliased" and actually refer to alternate versions. Implementations are of > course s

Re: [Qemu-devel] [Qemu-discuss] Segmentation fault on target tricore

On Tue, 17 Sep 2019 at 14:06, Konopik, Andreas wrote: > > >> Using gdb and valgrind I found out that: > >> - 'gen_mtcr()' and 'gen_mfcr()' access uninitialized values, i.e. > >> CSFRs, > >> which leads to the Segfault > >> - The uninitialised values were created by stack allocation of > >> DisasCo

Re: [Qemu-devel] [Qemu-discuss] Segmentation fault on target tricore

Using gdb and valgrind I found out that: - 'gen_mtcr()' and 'gen_mfcr()' access uninitialized values, i.e. CSFRs, which leads to the Segfault - The uninitialised values were created by stack allocation of DisasContext in 'gen_intermediate_code()' This definitely sounds like a bug: do you have

Re: [Qemu-devel] [Qemu-discuss] Segmentation fault on target tricore

Hi Andreas, On 9/17/19 2:32 PM, Peter Maydell wrote: On Tue, 17 Sep 2019 at 13:24, Konopik, Andreas wrote: Hello, I am wondering why the "Hello world"-program available in TASKING (v6.2r1) generates a segfault. I compiled the program for the 'TC1796' Processor (Infineon TriCore 1 Family -> A

Re: [Qemu-devel] [Qemu-discuss] Segmentation fault on target tricore

On Tue, 17 Sep 2019 at 13:24, Konopik, Andreas wrote: > > Hello, > > I am wondering why the "Hello world"-program available in TASKING > (v6.2r1) generates a segfault. > > I compiled the program for the 'TC1796' Processor (Infineon TriCore 1 > Family -> AUDO NextGeneration Family). > QEMU was buil

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: fix signal delivery for ppc64abi32

On Mon, Sep 16, 2019 at 08:22:42AM +0100, Alex Bennée wrote: > > David Gibson writes: > > > On Wed, Sep 11, 2019 at 10:33:45AM -0400, Richard Henderson wrote: > >> On 9/11/19 5:39 AM, Alex Bennée wrote: > >> > We were incorrectly setting NIP resulting in a segfault. This fixes > >> > linux-test

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine

On Mon, Sep 16, 2019 at 11:56:06AM +0200, Philippe Mathieu-Daudé wrote: > On 9/16/19 11:52 AM, Alex Bennée wrote: > > > > Philippe Mathieu-Daudé writes: > > > >> Hi David, > >> > >> On 9/16/19 2:42 AM, David Gibson wrote: > >>> On Sun, Sep 15, 2019 at 11:19:34PM +0200, Philippe Mathieu-Daudé wro

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.2 v5 1/2] kvm: s390: split too big memory section on several memslots

On Tue, 3 Sep 2019 08:57:38 +0200 Christian Borntraeger wrote: > On 02.09.19 15:49, Igor Mammedov wrote: > > On Fri, 30 Aug 2019 18:19:29 +0200 > > Christian Borntraeger wrote: > > > >> On 30.08.19 11:41, Igor Mammedov wrote: > >>> On Thu, 29 Aug 2019 14:41:13 +0200 > >>> Christian Borntrae

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] blockdev: release the AioContext at drive_backup_prepare

John Snow writes: > On 9/13/19 11:25 AM, Sergio Lopez wrote: >> do_drive_backup() already acquires the AioContext, so release it >> before the call. >> >> Signed-off-by: Sergio Lopez >> --- >> blockdev.c | 6 +- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/blockde

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] blockdev: release the AioContext at drive_backup_prepare

Kevin Wolf writes: > Am 13.09.2019 um 21:54 hat John Snow geschrieben: >> >> >> On 9/13/19 11:25 AM, Sergio Lopez wrote: >> > do_drive_backup() already acquires the AioContext, so release it >> > before the call. >> > >> > Signed-off-by: Sergio Lopez >> > --- >> > blockdev.c | 6 +- >> >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options

Le 14/09/2019 à 16:51, James Le Cuirot a écrit : > This dependency is currently "automagic", which is bad for distributions. > > Signed-off-by: James Le Cuirot > --- > configure | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/configure b/configure > index 30aad233d1..30544f52e6 10

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] trace: Forbid trailing newline in event format

Am 13.09.2019 um 12:52 hat Philippe Mathieu-Daudé geschrieben: > Hi Stefan, > > I'v been confused by trailing newline in trace reports, > so this series aims to fix this, by cleaning current > formats and add a check to catch new one introduced. Good idea. Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] blockdev: release the AioContext at drive_backup_prepare

Am 13.09.2019 um 21:54 hat John Snow geschrieben: > > > On 9/13/19 11:25 AM, Sergio Lopez wrote: > > do_drive_backup() already acquires the AioContext, so release it > > before the call. > > > > Signed-off-by: Sergio Lopez > > --- > > blockdev.c | 6 +- > > 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [Qemu-riscv] [PATCH v8 18/32] riscv: sifive_u: Set the minimum number of cpus to 2

Hi Jonathan, On Mon, Sep 16, 2019 at 1:40 AM Jonathan Behrens wrote: > > Has there been testing with "-smp 2"? A while back I thought I read that the > included uboot firmware was using a hard-coded device tree that indicated 4+1 > CPUs, which I would have expected to cause Linux boot issues? >

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: fix signal delivery for ppc64abi32

David Gibson writes: > On Wed, Sep 11, 2019 at 10:33:45AM -0400, Richard Henderson wrote: >> On 9/11/19 5:39 AM, Alex Bennée wrote: >> > We were incorrectly setting NIP resulting in a segfault. This fixes >> > linux-test for this ABI. >> >> Perhaps better: >> We were incorrectly using the 64-bi

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: fix signal delivery for ppc64abi32

On Wed, Sep 11, 2019 at 10:33:45AM -0400, Richard Henderson wrote: > On 9/11/19 5:39 AM, Alex Bennée wrote: > > We were incorrectly setting NIP resulting in a segfault. This fixes > > linux-test for this ABI. > > Perhaps better: > We were incorrectly using the 64-bit AIX ABI instead of the 32-bit

Re: [Qemu-devel] [Qemu-riscv] [PATCH v8 18/32] riscv: sifive_u: Set the minimum number of cpus to 2

On Sun, 15 Sep 2019 10:39:38 PDT (-0700), finte...@gmail.com wrote: Has there been testing with "-smp 2"? A while back I thought I read that the included uboot firmware was using a hard-coded device tree that indicated 4+1 CPUs, which I would have expected to cause Linux boot issues? It works f

Re: [Qemu-devel] [Qemu-riscv] [PATCH v8 18/32] riscv: sifive_u: Set the minimum number of cpus to 2

Has there been testing with "-smp 2"? A while back I thought I read that the included uboot firmware was using a hard-coded device tree that indicated 4+1 CPUs, which I would have expected to cause Linux boot issues? Jonathan On Sun, Sep 15, 2019 at 1:31 PM Palmer Dabbelt wrote: > On Sun, 15 Se

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] trace: Forbid event format ending with newline character

On 9/13/19 5:00 PM, Philippe Mathieu-Daudé wrote: > On 9/13/19 10:01 PM, John Snow wrote: >> On 9/13/19 6:52 AM, Philippe Mathieu-Daudé wrote: >>> Event format ending with newlines confuse the trace reports. >>> Forbid them. >>> >>> Add a check to refuse new format added with trailing newline: >

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] trace: Forbid event format ending with newline character

On 9/13/19 10:01 PM, John Snow wrote: > On 9/13/19 6:52 AM, Philippe Mathieu-Daudé wrote: >> Event format ending with newlines confuse the trace reports. >> Forbid them. >> >> Add a check to refuse new format added with trailing newline: >> >> $ make >> [...] >> GEN hw/misc/trace.h >>

Re: [Qemu-devel] [Qemu-block] [PATCH v2] virtio-blk: schedule virtio_notify_config to run on main context

On 9/13/19 6:56 AM, Sergio Lopez wrote: > virtio_notify_config() needs to acquire the global mutex, which isn't > allowed from an iothread, and may lead to a deadlock like this: > > - main thead > * Has acquired: qemu_global_mutex. > * Is trying the acquire: iothread AioContext lock via >

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] trace: Forbid trailing newline in event format

On 9/13/19 6:52 AM, Philippe Mathieu-Daudé wrote: > Hi Stefan, > > I'v been confused by trailing newline in trace reports, > so this series aims to fix this, by cleaning current > formats and add a check to catch new one introduced. > > Regards, > > Phil. > > Philippe Mathieu-Daudé (2): >

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] trace: Forbid event format ending with newline character

On 9/13/19 6:52 AM, Philippe Mathieu-Daudé wrote: > Event format ending with newlines confuse the trace reports. > Forbid them. > > Add a check to refuse new format added with trailing newline: > > $ make > [...] > GEN hw/misc/trace.h > Traceback (most recent call last): > Fi

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] blockdev: release the AioContext at drive_backup_prepare

On 9/13/19 11:25 AM, Sergio Lopez wrote: > do_drive_backup() already acquires the AioContext, so release it > before the call. > > Signed-off-by: Sergio Lopez > --- > blockdev.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/blockdev.c b/blockdev.c > index fbef

Re: [Qemu-devel] [Qemu-block] [PATCH v2 6/7] curl: Handle success in multi_check_completion

On Fri, 2019-09-13 at 13:20 +0200, Max Reitz wrote: > On 10.09.19 18:13, Maxim Levitsky wrote: > > On Tue, 2019-09-10 at 14:41 +0200, Max Reitz wrote: > > > Background: As of cURL 7.59.0, it verifies that several functions are > > > not called from within a callback. Among these functions is > > >

Re: [Qemu-devel] [Qemu-block] [PATCH v2 6/7] curl: Handle success in multi_check_completion

On 10.09.19 18:13, Maxim Levitsky wrote: > On Tue, 2019-09-10 at 14:41 +0200, Max Reitz wrote: >> Background: As of cURL 7.59.0, it verifies that several functions are >> not called from within a callback. Among these functions is >> curl_multi_add_handle(). >> >> curl_read_cb() is a callback from

Re: [Qemu-devel] [Qemu-discuss] Cross-posted : Odd QXL/KVM performance issue with a Windows 7 Guest

On 9/9/19 11:22 pm, Dr. David Alan Gilbert wrote: Oh, hmm. Sorry I don't know too much where to look then; you have any of: a) Windows b) guest graphics drivers c) spice server in qemu and probalby some more. So I think it's going to be a case of profiling on the two different syst

Re: [Qemu-devel] [Qemu-arm] [PATCH 12/13] target/arm/arm-semi: Implement SH_EXT_STDOUT_STDERR extension

On Thu, 12 Sep 2019 at 13:05, Alex Bennée wrote: > > > Peter Maydell writes: > > +/* > > + * We implement SH_EXT_STDOUT_STDERR, so: > > + * open for read == stdin > > + * open for write == stdout > > + * open for append == stderr > >

Re: [Qemu-devel] [Qemu-arm] [PATCH 13/13] target/arm/arm-semi: Implement SH_EXT_EXIT_EXTENDED extension

Peter Maydell writes: > SH_EXT_EXIT_EXTENDED is a v2.0 semihosting extension: it > indicates that the implementation supports the SYS_EXIT_EXTENDED > function. This function allows both A64 and A32/T32 guests to > exit with a specified exit status, unlike the older SYS_EXIT > function which onl

Re: [Qemu-devel] [Qemu-arm] [PATCH 11/13] target/arm/arm-semi: Implement support for semihosting feature detection

Peter Maydell writes: > Version 2.0 of the semihosting specification added support for > allowing a guest to detect whether the implementation supported > particular features. This works by the guest opening a magic > file ":semihosting-features", which contains a fixed set of > data with some

Re: [Qemu-devel] [Qemu-arm] [PATCH 04/13] target/arm/arm-semi: clean up TaskState* usage in non-user-only code

On Thu, 12 Sep 2019 at 12:44, Alex Bennée wrote: > Why not pass cs to set_swi_errno and deal with all the differences in > the helper? Mmm, that might be better. I think I was going for not changing the existing use of TaskState in the code paths that use it. thanks -- PMM

Re: [Qemu-devel] [Qemu-arm] [PATCH 10/13] target/arm/arm-semi: Factor out implementation of SYS_FLEN

Peter Maydell writes: > Factor out the implementation of SYS_FLEN via the new > function tables. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée > --- > target/arm/arm-semi.c | 31 +-- > 1 file changed, 21 insertions(+), 10 deletions(-) > > diff --git

Re: [Qemu-devel] [Qemu-arm] [PATCH 04/13] target/arm/arm-semi: clean up TaskState* usage in non-user-only code

Peter Maydell writes: > The semihosting code has to build for both user-only and softmmu; > for user-only it needs access to the TaskState struct that holds > per-thread information. For softmmu we don't need it. > > Currently the softmmu set_swi_errno() takes a CPUARMState *, > which it doesn'

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

Libo Zhou writes: > Alex Bennée writes: > > >> The gdbstub should allow you do full introspection and adding >> additional registers is fairly easy, see mips_cpu_gdb_read_register function >> in target/mips/gdbstub.c. > > > > Hi Alex and Aleksandar, > > > Now I can connect gdb to qemu success

Re: [Qemu-devel] [Qemu-arm] [PATCH 08/13] target/arm/arm-semi: Factor out implementation of SYS_ISTTY

Peter Maydell writes: > Factor out the implementation of SYS_ISTTY via the new function > tables. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée > --- > target/arm/arm-semi.c | 20 +++- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/target/ar

Re: [Qemu-devel] [Qemu-arm] [PATCH 07/13] target/arm/arm-semi: Factor out implementation of SYS_READ

Peter Maydell writes: > Factor out the implementation of SYS_READ via the > new function tables. "As for SYS_WRITE we need env for lock_user in system emulation."? > > Signed-off-by: Peter Maydell Either way: Reviewed-by: Alex Bennée > --- > target/arm/arm-semi.c | 57 ++

Re: [Qemu-devel] [Qemu-arm] [PATCH 05/13] target/arm/arm-semi: Factor out implementation of SYS_CLOSE

Peter Maydell writes: > Currently for the semihosting calls which take a file descriptor > (SYS_CLOSE, SYS_WRITE, SYS_READ, SYS_ISTTY, SYS_SEEK, SYS_FLEN) > we have effectively two implementations, one for real host files > and one for when we indirect via the gdbstub. We want to add a > third

Re: [Qemu-devel] [Qemu-arm] [PATCH 02/13] target/arm/arm-semi: Always set some kind of errno for failed calls

Peter Maydell writes: > On Thu, 12 Sep 2019 at 11:42, Alex Bennée wrote: >> >> >> Peter Maydell writes: >> >> > If we fail a semihosting call we should always set the >> > semihosting errno to something; we were failing to do >> > this for some of the "check inputs for sanity" cases. >> > >>

Re: [Qemu-devel] [Qemu-arm] [PATCH 03/13] target/arm/arm-semi: Make semihosting code hand out its own file descriptors

Peter Maydell writes: > Currently the Arm semihosting code returns the guest file descriptors > (handles) which are simply the fd values from the host OS or the > remote gdbstub. Part of the semihosting 2.0 specification requires > that we implement special handling of opening a ":semihosting-f

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

Alex Bennée writes: > The gdbstub should allow you do full introspection and adding > additional registers is fairly easy, see mips_cpu_gdb_read_register function > in target/mips/gdbstub.c. Hi Alex and Aleksandar, Now I can connect gdb to qemu successfully. And I can use this command to s

Re: [Qemu-devel] [Qemu-arm] [PATCH 02/13] target/arm/arm-semi: Always set some kind of errno for failed calls

On Thu, 12 Sep 2019 at 11:42, Alex Bennée wrote: > > > Peter Maydell writes: > > > If we fail a semihosting call we should always set the > > semihosting errno to something; we were failing to do > > this for some of the "check inputs for sanity" cases. > > > > Signed-off-by: Peter Maydell > > R

Re: [Qemu-devel] [Qemu-arm] [PATCH 01/13] target/arm/arm-semi: Capture errno in softmmu version of set_swi_errno()

On Thu, 12 Sep 2019 at 11:40, Alex Bennée wrote: > > > Peter Maydell writes: > > > The set_swi_errno() function is called to capture the errno > > from a host system call, so that we can return -1 from the > > semihosting function and later allow the guest to get a more > > specific error code wi

Re: [Qemu-devel] [Qemu-arm] [PATCH 02/13] target/arm/arm-semi: Always set some kind of errno for failed calls

Peter Maydell writes: > If we fail a semihosting call we should always set the > semihosting errno to something; we were failing to do > this for some of the "check inputs for sanity" cases. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée although: > --- > target/arm/arm-semi.c

Re: [Qemu-devel] [Qemu-arm] [PATCH 01/13] target/arm/arm-semi: Capture errno in softmmu version of set_swi_errno()

Peter Maydell writes: > The set_swi_errno() function is called to capture the errno > from a host system call, so that we can return -1 from the > semihosting function and later allow the guest to get a more > specific error code with the SYS_ERRNO function. It comes in > two versions, one for

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Stop overwriting compressed clusters one by one

Am 12.09.2019 um 09:25 hat Alberto Garcia geschrieben: > On Thu 12 Sep 2019 01:33:05 AM CEST, John Snow wrote: > >> This restriction comes from commit 095a9c58ce12afeeb90c2 from 2018. > > > > You accidentally typed a reasonably modern date. It's from *2008*! > > Oh my, and I reviewed the message

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Stop overwriting compressed clusters one by one

On Thu 12 Sep 2019 01:33:05 AM CEST, John Snow wrote: >> This restriction comes from commit 095a9c58ce12afeeb90c2 from 2018. > > You accidentally typed a reasonably modern date. It's from *2008*! Oh my, and I reviewed the message 3 times ... if this one gets committed please correct the date. Be

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Stop overwriting compressed clusters one by one

On 9/11/19 11:16 AM, Alberto Garcia wrote: > handle_alloc() tries to find as many contiguous clusters that need > copy-on-write as possible in order to allocate all of them at the same > time. > > However, compressed clusters are only overwritten one by one, so let's > say that we have an image

Re: [Qemu-devel] [Qemu-block] [PATCH] block/create: Do not abort if a block driver is not available

On 9/11/19 6:08 PM, Philippe Mathieu-Daudé wrote: > The 'blockdev-create' QMP command was introduced as experimental > feature in commit b0292b851b8, using the assert() debug call. > It got promoted to 'stable' command in 3fb588a0f2c, but the > assert call was not removed. > > Some block driver

Re: [Qemu-devel] [Qemu-riscv] [PATCH v2 04/17] RISC-V: add vector extension configure instruction

On Wed, Sep 11, 2019 at 2:38 PM liuzhiwei wrote: > From: LIU Zhiwei > > Signed-off-by: LIU Zhiwei > --- > target/riscv/Makefile.objs | 2 +- > target/riscv/helper.h | 3 + > target/riscv/insn32.decode | 5 ++ > target/riscv/insn_trans/trans_rvv

Re: [Qemu-devel] [Qemu-riscv] [PATCH v2 03/17] RISC-V: support vector extension csr

On Wed, Sep 11, 2019 at 2:38 PM liuzhiwei wrote: > From: LIU Zhiwei > > Signed-off-by: LIU Zhiwei > --- > target/riscv/cpu_bits.h | 15 > target/riscv/csr.c | 65 > ++--- > 2 files changed, 76 insertions(+), 4 deletions(-) > > diff

Re: [Qemu-devel] [Qemu-riscv] [PATCH v1 10/28] target/riscv: Convert mie and mstatus to pointers

Version 0.4 of the hypervisor spec no longer talks about swapping registers. Instead when running in VS-mode some of the supervisor registers are "aliased" and actually refer to alternate versions. Implementations are of course still allowed to do swapping internally if desired, but it adds complex

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

; > > Libo > > > > > > > > > -- Original ------ > > > From: "Alex Bennée";; > > > Send time: Friday, Sep 6, 2019 5:19 PM > > > To: "Libo Zhou"; > > > Cc: "qemu-devel"; "

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 00/28] s390x/tcg: mem_helper: Fault-safe handling

On 06.09.19 09:57, David Hildenbrand wrote: > This is the successor of > "[PATCH v1 0/4] s390x/tcg: MOVE (MVC): Fault-safe handling" > > > > This series fixes a bunch of issues related to some mem helpers and makes > sure that they are fault-safe, meaning no system state is modified in c

Re: [Qemu-devel] [Qemu-block] [PATCH 0/7] Move qtests to a separate folder

On 11/09/2019 10.54, Kevin Wolf wrote: > Am 11.09.2019 um 10:01 hat Thomas Huth geschrieben: >> On 11/09/2019 08.58, Kevin Wolf wrote: >>> Am 10.09.2019 um 21:07 hat Eric Blake geschrieben: On 9/10/19 1:58 PM, Thomas Huth wrote: > Our "tests" directory is very overcrowded - we store the qt

Re: [Qemu-devel] [Qemu-block] [PATCH 0/7] Move qtests to a separate folder

Am 11.09.2019 um 10:01 hat Thomas Huth geschrieben: > On 11/09/2019 08.58, Kevin Wolf wrote: > > Am 10.09.2019 um 21:07 hat Eric Blake geschrieben: > >> On 9/10/19 1:58 PM, Thomas Huth wrote: > >>> Our "tests" directory is very overcrowded - we store the qtests, > >>> unit test and other files ther

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

ginal -- From: "Aleksandar Markovic";; Send time: Wednesday, Sep 11, 2019 1:50 AM To: "Libo Zhou"; Cc: "Alex Bennée"; "qemu-devel"; Subject: Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator) 10.09.2019. 19.26, aleksandar.m.m...@gmail.com ?е написао

Re: [Qemu-devel] [Qemu-block] [PATCH 0/7] Move qtests to a separate folder

On 11/09/2019 08.58, Kevin Wolf wrote: > Am 10.09.2019 um 21:07 hat Eric Blake geschrieben: >> On 9/10/19 1:58 PM, Thomas Huth wrote: >>> Our "tests" directory is very overcrowded - we store the qtests, >>> unit test and other files there. That makes it difficult to >>> determine which file belongs

Re: [Qemu-devel] [Qemu-block] [PATCH 0/7] Move qtests to a separate folder

Am 10.09.2019 um 21:07 hat Eric Blake geschrieben: > On 9/10/19 1:58 PM, Thomas Huth wrote: > > Our "tests" directory is very overcrowded - we store the qtests, > > unit test and other files there. That makes it difficult to > > determine which file belongs to each test subsystem, and the > > wildc

Re: [Qemu-devel] [Qemu-block] [PATCH v2 3/7] curl: Check completion in curl_multi_do()

On 10.09.19 18:11, Maxim Levitsky wrote: > On Tue, 2019-09-10 at 14:41 +0200, Max Reitz wrote: >> While it is more likely that transfers complete after some file >> descriptor has data ready to read, we probably should not rely on it. >> Better be safe than sorry and call curl_multi_check_completio

Re: [Qemu-devel] [Qemu-block] [PATCH v2 3/7] curl: Check completion in curl_multi_do()

On 9/10/19 12:11 PM, Maxim Levitsky wrote: > On Tue, 2019-09-10 at 14:41 +0200, Max Reitz wrote: >> While it is more likely that transfers complete after some file >> descriptor has data ready to read, we probably should not rely on it. >> Better be safe than sorry and call curl_multi_check_comp

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

; Libo > > > > > > -- Original -- > > From: "Alex Bennée";; > > Send time: Friday, Sep 6, 2019 5:19 PM > > To: "Libo Zhou"; > > Cc: "qemu-devel"; "Aleksandar Markovic"< aleksandar.m.m

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

Cheers, > Libo > > > -- Original -- > From: "Alex Bennée";; > Send time: Friday, Sep 6, 2019 5:19 PM > To: "Libo Zhou"; > Cc: "qemu-devel"; "Aleksandar Markovic"< aleksandar.m.m...@gmail.com>; > Subject: Re: [Qemu

Re: [Qemu-devel] [Qemu-block] [PATCH v2 7/7] curl: Check curl_multi_add_handle()'s return code

On Tue, 2019-09-10 at 14:41 +0200, Max Reitz wrote: > If we had done that all along, debugging would have been much simpler. > (Also, I/O errors are better than hangs.) > > Signed-off-by: Max Reitz > --- > block/curl.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --gi

Re: [Qemu-devel] [Qemu-block] [PATCH v2 6/7] curl: Handle success in multi_check_completion

On Tue, 2019-09-10 at 14:41 +0200, Max Reitz wrote: > Background: As of cURL 7.59.0, it verifies that several functions are > not called from within a callback. Among these functions is > curl_multi_add_handle(). > > curl_read_cb() is a callback from cURL and not a coroutine. Waking up > acb->co

Re: [Qemu-devel] [Qemu-block] [PATCH v2 4/7] curl: Pass CURLSocket to curl_multi_do()

On Tue, 2019-09-10 at 14:41 +0200, Max Reitz wrote: > curl_multi_do_locked() currently marks all sockets as ready. That is > not only inefficient, but in fact unsafe (the loop is). A follow-up > patch will change that, but to do so, curl_multi_do_locked() needs to > know exactly which socket is r

Re: [Qemu-devel] [Qemu-block] [PATCH v2 3/7] curl: Check completion in curl_multi_do()

On Tue, 2019-09-10 at 14:41 +0200, Max Reitz wrote: > While it is more likely that transfers complete after some file > descriptor has data ready to read, we probably should not rely on it. > Better be safe than sorry and call curl_multi_check_completion() in > curl_multi_do(), too, just like it is

Re: [Qemu-devel] [Qemu-block] [PATCH v2 5/7] curl: Report only ready sockets

On Tue, 2019-09-10 at 14:41 +0200, Max Reitz wrote: > Instead of reporting all sockets to cURL, only report the one that has > caused curl_multi_do_locked() to be called. This lets us get rid of the > QLIST_FOREACH_SAFE() list, which was actually wrong: SAFE foreaches are > only safe when the curr

Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/7] curl: Keep *socket until the end of curl_sock_cb()

On Tue, 2019-09-10 at 14:41 +0200, Max Reitz wrote: > This does not really change anything, but it makes the code a bit easier > to follow once we use @socket as the opaque pointer for > aio_set_fd_handler(). > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Max Reitz > --- > block/curl.c | 10 +++

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/7] curl: Keep pointer to the CURLState in CURLSocket

On Tue, 2019-09-10 at 14:41 +0200, Max Reitz wrote: > A follow-up patch will make curl_multi_do() and curl_multi_read() take a > CURLSocket instead of the CURLState. They still need the latter, > though, so add a pointer to it to the former. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Max Rei

Re: [Qemu-devel] [Qemu-block] [PATCH] block/backup: install notifier during creation

On 9/10/19 4:19 AM, Stefan Hajnoczi wrote: > On Wed, Aug 21, 2019 at 04:01:52PM -0400, John Snow wrote: >> >> >> On 8/21/19 10:41 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 09.08.2019 23:13, John Snow wrote: Backup jobs may yield prior to installing their handler, because of the job_c

  1   2   3   4   5   6   7   8   9   10   >