Re: [Qemu-devel] QMP accepts double dict keys

2018-12-05 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 12/3/18 1:48 PM, Markus Armbruster wrote: > > Eric Blake writes: > > > > > On 12/3/18 10:30 AM, Max Reitz wrote: > > > > Hi, > > > > > > > > QMP accepts double keys in dicts without complaining. The value it is > > > > using is apparently the last on

Re: [Qemu-devel] QMP accepts double dict keys

2018-12-04 Thread Daniel P . Berrangé
On Mon, Dec 03, 2018 at 01:57:13PM -0600, Eric Blake wrote: > On 12/3/18 1:48 PM, Markus Armbruster wrote: > > Eric Blake writes: > > > > > On 12/3/18 10:30 AM, Max Reitz wrote: > > > > Hi, > > > > > > > > QMP accepts double keys in dicts without complaining. The value it is > > > > using is ap

Re: [Qemu-devel] QMP accepts double dict keys

2018-12-03 Thread Eric Blake
On 12/3/18 1:48 PM, Markus Armbruster wrote: Eric Blake writes: On 12/3/18 10:30 AM, Max Reitz wrote: Hi, QMP accepts double keys in dicts without complaining. The value it is using is apparently the last one specified: JSON says it is undefined what happens when a client passes double ke

Re: [Qemu-devel] QMP accepts double dict keys

2018-12-03 Thread Markus Armbruster
Eric Blake writes: > On 12/3/18 10:30 AM, Max Reitz wrote: >> Hi, >> >> QMP accepts double keys in dicts without complaining. The value it is >> using is apparently the last one specified: > > JSON says it is undefined what happens when a client passes double > keys. We are probably best off if

Re: [Qemu-devel] QMP accepts double dict keys

2018-12-03 Thread Eric Blake
On 12/3/18 10:30 AM, Max Reitz wrote: Hi, QMP accepts double keys in dicts without complaining. The value it is using is apparently the last one specified: JSON says it is undefined what happens when a client passes double keys. We are probably best off if we teach our parser to be strict a

[Qemu-devel] QMP accepts double dict keys

2018-12-03 Thread Max Reitz
Hi, QMP accepts double keys in dicts without complaining. The value it is using is apparently the last one specified: $ qemu-system-x86_64 -qmp stdio {"QMP": {"version": {"qemu": {"micro": 93, "minor": 0, "major": 3}, "package": "v3.1.0-rc3-7-g87a45d86ed"}, "capabilities": []}} {'execute':'qmp_c