Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-08 Thread Anthony Liguori
On 06/06/2011 10:30 AM, Luiz Capitulino wrote: On Mon, 6 Jun 2011 16:27:55 +0100 "Daniel P. Berrange" wrote: On Mon, Jun 06, 2011 at 08:08:51AM -0500, Anthony Liguori wrote: On 06/06/2011 04:25 AM, Kevin Wolf wrote: Am 02.06.2011 20:09, schrieb Luiz Capitulino: I'm ok with either way. But i

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-07 Thread Luiz Capitulino
On Tue, 07 Jun 2011 13:43:27 -0500 Anthony Liguori wrote: > On 06/07/2011 12:43 PM, Luiz Capitulino wrote: > > On Tue, 07 Jun 2011 11:32:14 -0500 > > Anthony Liguori wrote: > > > >> Sorry, I meant to ask, what's the difference between "low level" and > >> "unknown". > > > > "low level" is EIO, "

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-07 Thread Anthony Liguori
On 06/07/2011 12:43 PM, Luiz Capitulino wrote: On Tue, 07 Jun 2011 11:32:14 -0500 Anthony Liguori wrote: Sorry, I meant to ask, what's the difference between "low level" and "unknown". "low level" is EIO, "unknown" is everything else (EINVAL, EPIPE, ...). How can you document this to the u

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-07 Thread Luiz Capitulino
On Tue, 07 Jun 2011 11:32:14 -0500 Anthony Liguori wrote: > On 06/07/2011 10:54 AM, Luiz Capitulino wrote: > > On Tue, 07 Jun 2011 10:39:45 -0500 > > Anthony Liguori wrote: > > > >> On 06/07/2011 09:46 AM, Luiz Capitulino wrote: > >>> On Mon, 06 Jun 2011 08:08:51 -0500 > >>> Anthony Liguori wr

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-07 Thread Anthony Liguori
On 06/07/2011 10:41 AM, Markus Armbruster wrote: Luiz Capitulino writes: On Mon, 06 Jun 2011 08:08:51 -0500 Anthony Liguori wrote: On 06/06/2011 04:25 AM, Kevin Wolf wrote: Am 02.06.2011 20:09, schrieb Luiz Capitulino: I'm ok with either way. But in case you meant the second one, I guess

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-07 Thread Anthony Liguori
On 06/07/2011 10:54 AM, Luiz Capitulino wrote: On Tue, 07 Jun 2011 10:39:45 -0500 Anthony Liguori wrote: On 06/07/2011 09:46 AM, Luiz Capitulino wrote: On Mon, 06 Jun 2011 08:08:51 -0500 Anthony Liguori wrote: On 06/06/2011 04:25 AM, Kevin Wolf wrote: Am 02.06.2011 20:09, schrieb Luiz Ca

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-07 Thread Luiz Capitulino
On Tue, 07 Jun 2011 10:39:45 -0500 Anthony Liguori wrote: > On 06/07/2011 09:46 AM, Luiz Capitulino wrote: > > On Mon, 06 Jun 2011 08:08:51 -0500 > > Anthony Liguori wrote: > > > >> On 06/06/2011 04:25 AM, Kevin Wolf wrote: > >>> Am 02.06.2011 20:09, schrieb Luiz Capitulino: > >> I'm ok with

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-07 Thread Markus Armbruster
Luiz Capitulino writes: > On Mon, 06 Jun 2011 08:08:51 -0500 > Anthony Liguori wrote: > >> On 06/06/2011 04:25 AM, Kevin Wolf wrote: >> > Am 02.06.2011 20:09, schrieb Luiz Capitulino: >> I'm ok with either way. But in case you meant the second one, I guess >> we should make "reason" a

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-07 Thread Anthony Liguori
On 06/07/2011 09:46 AM, Luiz Capitulino wrote: On Mon, 06 Jun 2011 08:08:51 -0500 Anthony Liguori wrote: On 06/06/2011 04:25 AM, Kevin Wolf wrote: Am 02.06.2011 20:09, schrieb Luiz Capitulino: I'm ok with either way. But in case you meant the second one, I guess we should make "reason" a dic

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-07 Thread Luiz Capitulino
On Mon, 06 Jun 2011 08:08:51 -0500 Anthony Liguori wrote: > On 06/06/2011 04:25 AM, Kevin Wolf wrote: > > Am 02.06.2011 20:09, schrieb Luiz Capitulino: > I'm ok with either way. But in case you meant the second one, I guess > we should make "reason" a dictionary so that we can group rel

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-06 Thread Daniel P. Berrange
On Mon, Jun 06, 2011 at 08:08:51AM -0500, Anthony Liguori wrote: > On 06/06/2011 04:25 AM, Kevin Wolf wrote: > >Am 02.06.2011 20:09, schrieb Luiz Capitulino: > I'm ok with either way. But in case you meant the second one, I guess > we should make "reason" a dictionary so that we can group r

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-06 Thread Luiz Capitulino
On Mon, 6 Jun 2011 16:27:55 +0100 "Daniel P. Berrange" wrote: > On Mon, Jun 06, 2011 at 08:08:51AM -0500, Anthony Liguori wrote: > > On 06/06/2011 04:25 AM, Kevin Wolf wrote: > > >Am 02.06.2011 20:09, schrieb Luiz Capitulino: > > I'm ok with either way. But in case you meant the second one, I

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-06 Thread Anthony Liguori
On 06/06/2011 04:25 AM, Kevin Wolf wrote: Am 02.06.2011 20:09, schrieb Luiz Capitulino: I'm ok with either way. But in case you meant the second one, I guess we should make "reason" a dictionary so that we can group related information when we extend the field, for example: "reason": { "no s

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-06 Thread Anthony Liguori
On 06/06/2011 06:27 AM, Markus Armbruster wrote: Kevin Wolf writes: Am 02.06.2011 20:09, schrieb Luiz Capitulino: On Thu, 02 Jun 2011 13:00:04 -0500 Anthony Liguori wrote: On 06/02/2011 12:57 PM, Luiz Capitulino wrote: On Wed, 01 Jun 2011 16:35:03 -0500 Anthony Liguori wrote: On 06/01

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-06 Thread Markus Armbruster
Markus Armbruster writes: > Anthony Liguori writes: [...] >> you can call the reason whatever you want, but don't call it >> stringfied errno name :-) > > Care to explain why? Found a bit of explanation downthread. Sorry for the noise.

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-06 Thread Markus Armbruster
Kevin Wolf writes: > Am 02.06.2011 20:09, schrieb Luiz Capitulino: >> On Thu, 02 Jun 2011 13:00:04 -0500 >> Anthony Liguori wrote: >> >>> On 06/02/2011 12:57 PM, Luiz Capitulino wrote: On Wed, 01 Jun 2011 16:35:03 -0500 Anthony Liguori wrote: > On 06/01/2011 04:12 PM, Luiz C

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-06 Thread Markus Armbruster
Anthony Liguori writes: > On 06/02/2011 08:24 AM, Jiri Denemark wrote: >> On Thu, Jun 02, 2011 at 08:08:35 -0500, Anthony Liguori wrote: >>> On 06/02/2011 04:06 AM, Daniel P. Berrange wrote: >> B. query-stop-reason >> >> >> I also have a simple solution for it

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-06 Thread Markus Armbruster
Anthony Liguori writes: > On 06/01/2011 04:12 PM, Luiz Capitulino wrote: >> Hi there, >> >> There are people who want to use QMP for thin provisioning. That's, the VM is >> started with a small storage and when a no space error is triggered, more >> space >> is allocated and the VM is put to run

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-06 Thread Kevin Wolf
Am 02.06.2011 20:09, schrieb Luiz Capitulino: > On Thu, 02 Jun 2011 13:00:04 -0500 > Anthony Liguori wrote: > >> On 06/02/2011 12:57 PM, Luiz Capitulino wrote: >>> On Wed, 01 Jun 2011 16:35:03 -0500 >>> Anthony Liguori wrote: >>> On 06/01/2011 04:12 PM, Luiz Capitulino wrote: > Hi there

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-03 Thread Daniel P. Berrange
On Fri, Jun 03, 2011 at 08:51:29AM -0500, Anthony Liguori wrote: > On 06/03/2011 08:41 AM, Jan Kiszka wrote: > >On 2011-06-03 15:26, Anthony Liguori wrote: > >>I think what we're getting at is the need for an enumeration. So let's > >>introduce one. Here's what I propose: > >> > >>SQMP > >>query-

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-03 Thread Jan Kiszka
On 2011-06-03 15:51, Anthony Liguori wrote: > On 06/03/2011 08:41 AM, Jan Kiszka wrote: >> On 2011-06-03 15:26, Anthony Liguori wrote: >>> I think what we're getting at is the need for an enumeration. So let's >>> introduce one. Here's what I propose: >>> >>> SQMP >>> query-status >>> ---

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-03 Thread Anthony Liguori
On 06/03/2011 08:44 AM, Luiz Capitulino wrote: On Fri, 3 Jun 2011 14:39:41 +0100 "Daniel P. Berrange" wrote: On Fri, Jun 03, 2011 at 08:26:56AM -0500, Anthony Liguori wrote: On 06/03/2011 07:57 AM, Daniel P. Berrange wrote: On Fri, Jun 03, 2011 at 07:43:24AM -0500, Anthony Liguori wrote: On

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-03 Thread Anthony Liguori
On 06/03/2011 08:41 AM, Jan Kiszka wrote: On 2011-06-03 15:26, Anthony Liguori wrote: I think what we're getting at is the need for an enumeration. So let's introduce one. Here's what I propose: SQMP query-status Return a json-object with the following information: - "running":

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-03 Thread Luiz Capitulino
On Fri, 3 Jun 2011 14:39:41 +0100 "Daniel P. Berrange" wrote: > On Fri, Jun 03, 2011 at 08:26:56AM -0500, Anthony Liguori wrote: > > On 06/03/2011 07:57 AM, Daniel P. Berrange wrote: > > >On Fri, Jun 03, 2011 at 07:43:24AM -0500, Anthony Liguori wrote: > > >>On 06/03/2011 04:26 AM, Daniel P. Berr

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-03 Thread Jan Kiszka
On 2011-06-03 15:26, Anthony Liguori wrote: > I think what we're getting at is the need for an enumeration. So let's > introduce one. Here's what I propose: > > SQMP > query-status > > > Return a json-object with the following information: > > - "running": true if the VM is runnin

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-03 Thread Daniel P. Berrange
On Fri, Jun 03, 2011 at 08:26:56AM -0500, Anthony Liguori wrote: > On 06/03/2011 07:57 AM, Daniel P. Berrange wrote: > >On Fri, Jun 03, 2011 at 07:43:24AM -0500, Anthony Liguori wrote: > >>On 06/03/2011 04:26 AM, Daniel P. Berrange wrote: > >>errors stop a guest) instead of trying to model an inter

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-03 Thread Anthony Liguori
On 06/03/2011 07:57 AM, Daniel P. Berrange wrote: On Fri, Jun 03, 2011 at 07:43:24AM -0500, Anthony Liguori wrote: On 06/03/2011 04:26 AM, Daniel P. Berrange wrote: errors stop a guest) instead of trying to model an internal QEMU concept (vm_stop()). If you have other user visible concepts that

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-03 Thread Daniel P. Berrange
On Fri, Jun 03, 2011 at 07:43:24AM -0500, Anthony Liguori wrote: > On 06/03/2011 04:26 AM, Daniel P. Berrange wrote: > >On Thu, Jun 02, 2011 at 03:01:24PM -0300, Luiz Capitulino wrote: > >>On Thu, 02 Jun 2011 09:02:30 -0500 > >>Anthony Liguori wrote: > >> > >>>On 06/02/2011 08:24 AM, Jiri Denemark

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-03 Thread Anthony Liguori
On 06/03/2011 04:26 AM, Daniel P. Berrange wrote: On Thu, Jun 02, 2011 at 03:01:24PM -0300, Luiz Capitulino wrote: On Thu, 02 Jun 2011 09:02:30 -0500 Anthony Liguori wrote: On 06/02/2011 08:24 AM, Jiri Denemark wrote: On Thu, Jun 02, 2011 at 08:08:35 -0500, Anthony Liguori wrote: On 06/02/2

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-03 Thread Daniel P. Berrange
On Thu, Jun 02, 2011 at 03:01:24PM -0300, Luiz Capitulino wrote: > On Thu, 02 Jun 2011 09:02:30 -0500 > Anthony Liguori wrote: > > > On 06/02/2011 08:24 AM, Jiri Denemark wrote: > > > On Thu, Jun 02, 2011 at 08:08:35 -0500, Anthony Liguori wrote: > > >> On 06/02/2011 04:06 AM, Daniel P. Berrange

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-02 Thread Anthony Liguori
On 06/02/2011 02:13 PM, Luiz Capitulino wrote: On Thu, 02 Jun 2011 13:33:52 -0500 Anthony Liguori wrote: On 06/02/2011 01:09 PM, Luiz Capitulino wrote: On Thu, 02 Jun 2011 13:00:04 -0500 Anthony Liguori wrote: On 06/02/2011 12:57 PM, Luiz Capitulino wrote: On Wed, 01 Jun 2011 16:35:03 -0

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-02 Thread Anthony Liguori
On 06/02/2011 01:57 PM, Luiz Capitulino wrote: On Thu, 02 Jun 2011 13:32:25 -0500 Anthony Liguori wrote: On 06/02/2011 01:01 PM, Luiz Capitulino wrote: On Thu, 02 Jun 2011 09:02:30 -0500 Anthony Liguori wrote: On 06/02/2011 08:24 AM, Jiri Denemark wrote: On Thu, Jun 02, 2011 at 08:08:35

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-02 Thread Luiz Capitulino
On Thu, 02 Jun 2011 13:33:52 -0500 Anthony Liguori wrote: > On 06/02/2011 01:09 PM, Luiz Capitulino wrote: > > On Thu, 02 Jun 2011 13:00:04 -0500 > > Anthony Liguori wrote: > > > >> On 06/02/2011 12:57 PM, Luiz Capitulino wrote: > >>> On Wed, 01 Jun 2011 16:35:03 -0500 > >>> Anthony Liguori wr

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-02 Thread Luiz Capitulino
On Thu, 02 Jun 2011 13:32:25 -0500 Anthony Liguori wrote: > On 06/02/2011 01:01 PM, Luiz Capitulino wrote: > > On Thu, 02 Jun 2011 09:02:30 -0500 > > Anthony Liguori wrote: > > > >> On 06/02/2011 08:24 AM, Jiri Denemark wrote: > >>> On Thu, Jun 02, 2011 at 08:08:35 -0500, Anthony Liguori wrote:

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-02 Thread Anthony Liguori
On 06/02/2011 01:09 PM, Luiz Capitulino wrote: On Thu, 02 Jun 2011 13:00:04 -0500 Anthony Liguori wrote: On 06/02/2011 12:57 PM, Luiz Capitulino wrote: On Wed, 01 Jun 2011 16:35:03 -0500 Anthony Liguori wrote: On 06/01/2011 04:12 PM, Luiz Capitulino wrote: Hi there, There are people who

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-02 Thread Anthony Liguori
On 06/02/2011 01:01 PM, Luiz Capitulino wrote: On Thu, 02 Jun 2011 09:02:30 -0500 Anthony Liguori wrote: On 06/02/2011 08:24 AM, Jiri Denemark wrote: On Thu, Jun 02, 2011 at 08:08:35 -0500, Anthony Liguori wrote: On 06/02/2011 04:06 AM, Daniel P. Berrange wrote: B. query-stop-reason ---

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-02 Thread Luiz Capitulino
On Thu, 02 Jun 2011 13:00:04 -0500 Anthony Liguori wrote: > On 06/02/2011 12:57 PM, Luiz Capitulino wrote: > > On Wed, 01 Jun 2011 16:35:03 -0500 > > Anthony Liguori wrote: > > > >> On 06/01/2011 04:12 PM, Luiz Capitulino wrote: > >>> Hi there, > >>> > >>> There are people who want to use QMP fo

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-02 Thread Anthony Liguori
On 06/02/2011 12:57 PM, Luiz Capitulino wrote: On Wed, 01 Jun 2011 16:35:03 -0500 Anthony Liguori wrote: On 06/01/2011 04:12 PM, Luiz Capitulino wrote: Hi there, There are people who want to use QMP for thin provisioning. That's, the VM is started with a small storage and when a no space err

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-02 Thread Luiz Capitulino
On Wed, 01 Jun 2011 16:35:03 -0500 Anthony Liguori wrote: > On 06/01/2011 04:12 PM, Luiz Capitulino wrote: > > Hi there, > > > > There are people who want to use QMP for thin provisioning. That's, the VM > > is > > started with a small storage and when a no space error is triggered, more > > sp

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-02 Thread Luiz Capitulino
On Thu, 02 Jun 2011 09:02:30 -0500 Anthony Liguori wrote: > On 06/02/2011 08:24 AM, Jiri Denemark wrote: > > On Thu, Jun 02, 2011 at 08:08:35 -0500, Anthony Liguori wrote: > >> On 06/02/2011 04:06 AM, Daniel P. Berrange wrote: > > B. query-stop-reason > > > > > >>

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-02 Thread Anthony Liguori
On 06/02/2011 08:24 AM, Jiri Denemark wrote: On Thu, Jun 02, 2011 at 08:08:35 -0500, Anthony Liguori wrote: On 06/02/2011 04:06 AM, Daniel P. Berrange wrote: B. query-stop-reason I also have a simple solution for item 2. The vm_stop() accepts a reason argument, so we could

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-02 Thread Jiri Denemark
On Thu, Jun 02, 2011 at 08:08:35 -0500, Anthony Liguori wrote: > On 06/02/2011 04:06 AM, Daniel P. Berrange wrote: > >>> B. query-stop-reason > >>> > >>> > >>> I also have a simple solution for item 2. The vm_stop() accepts a reason > >>> argument, so we could store it somewher

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-02 Thread Anthony Liguori
On 06/02/2011 04:06 AM, Daniel P. Berrange wrote: On Wed, Jun 01, 2011 at 04:35:03PM -0500, Anthony Liguori wrote: "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } Valid error reasons could be: "enospc", "eio", etc. No etc :-) Error reasons should we be well known and wel

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-02 Thread Daniel P. Berrange
On Wed, Jun 01, 2011 at 04:35:03PM -0500, Anthony Liguori wrote: > On 06/01/2011 04:12 PM, Luiz Capitulino wrote: > >Hi there, > > > >There are people who want to use QMP for thin provisioning. That's, the VM is > >started with a small storage and when a no space error is triggered, more > >space

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-01 Thread Anthony Liguori
On 06/01/2011 04:12 PM, Luiz Capitulino wrote: Hi there, There are people who want to use QMP for thin provisioning. That's, the VM is started with a small storage and when a no space error is triggered, more space is allocated and the VM is put to run again. QMP has two limitations that preven

[Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-01 Thread Luiz Capitulino
Hi there, There are people who want to use QMP for thin provisioning. That's, the VM is started with a small storage and when a no space error is triggered, more space is allocated and the VM is put to run again. QMP has two limitations that prevent people from doing this today: 1. The BLOCK_IO_