Re: [Qemu-devel] Plan for error handling in QMP

2012-07-27 Thread Luiz Capitulino
On Thu, 26 Jul 2012 17:47:25 -0500 Anthony Liguori wrote: > Luiz Capitulino writes: > > > On Thu, 26 Jul 2012 16:08:54 -0500 > > Anthony Liguori wrote: > > > >> Luiz Capitulino writes: > >> > >> > On Thu, 26 Jul 2012 15:43:58 -0300 > >> > Luiz Capitulino wrote: > >> > > >> >> On Thu, 26 Jul

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-27 Thread Paolo Bonzini
Il 26/07/2012 20:22, anth...@codemonkey.ws ha scritto: > 7. We need to make sure that anything we expose in 1.2 stays that way. >If we're dropping 'InvalidParameterType' as a class code, it should be >dropped in 1.2. This could be achieved by making all existing codes >except for those

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-27 Thread Paolo Bonzini
Il 26/07/2012 22:41, Eric Blake ha scritto: >> > 5. The following errors are used by libvirt: >> >- CommandNotFound: QMP parsing >> >- DeviceNotActive/KVMMissingCap: ballooning >> >- DeviceNotFound: drive_del >> >- MigrationExpected: cont > DeviceInUse, NotSupported: block-stream >

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-27 Thread Markus Armbruster
anth...@codemonkey.ws writes: > Hi, > > We had a violent^Wheated discussion on IRC about how to move forward > with Luiz's proposed error series. I think we reached consensus. This > note attempts to outline that. > > Principles > -- > 1. Errors should be free formed strings with a class

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread Anthony Liguori
Luiz Capitulino writes: > On Thu, 26 Jul 2012 16:08:54 -0500 > Anthony Liguori wrote: > >> Luiz Capitulino writes: >> >> > On Thu, 26 Jul 2012 15:43:58 -0300 >> > Luiz Capitulino wrote: >> > >> >> On Thu, 26 Jul 2012 13:22:15 -0500 >> >> anth...@codemonkey.ws wrote: >> >> >> >> > >> >> > Hi

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread Richard W.M. Jones
On Thu, Jul 26, 2012 at 01:22:15PM -0500, anth...@codemonkey.ws wrote: > We had a violent^Wheated discussion on IRC about how to move forward > with Luiz's proposed error series. I think we reached consensus. This > note attempts to outline that. > > Principles > -- > 1. Errors should be

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread Luiz Capitulino
On Thu, 26 Jul 2012 16:08:54 -0500 Anthony Liguori wrote: > Luiz Capitulino writes: > > > On Thu, 26 Jul 2012 15:43:58 -0300 > > Luiz Capitulino wrote: > > > >> On Thu, 26 Jul 2012 13:22:15 -0500 > >> anth...@codemonkey.ws wrote: > >> > >> > > >> > Hi, > >> > > >> > We had a violent^Wheated

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread Anthony Liguori
Luiz Capitulino writes: > On Thu, 26 Jul 2012 15:43:58 -0300 > Luiz Capitulino wrote: > >> On Thu, 26 Jul 2012 13:22:15 -0500 >> anth...@codemonkey.ws wrote: >> >> > >> > Hi, >> > >> > We had a violent^Wheated discussion on IRC about how to move forward >> > with Luiz's proposed error series.

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread Eric Blake
On 07/26/2012 12:22 PM, anth...@codemonkey.ws wrote: > > Hi, > > We had a violent^Wheated discussion on IRC about how to move forward > with Luiz's proposed error series. I think we reached consensus. This > note attempts to outline that. > > Principles > -- > 1. Errors should be free

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread Luiz Capitulino
On Thu, 26 Jul 2012 15:43:58 -0300 Luiz Capitulino wrote: > On Thu, 26 Jul 2012 13:22:15 -0500 > anth...@codemonkey.ws wrote: > > > > > Hi, > > > > We had a violent^Wheated discussion on IRC about how to move forward > > with Luiz's proposed error series. I think we reached consensus. This >

Re: [Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread Luiz Capitulino
On Thu, 26 Jul 2012 13:22:15 -0500 anth...@codemonkey.ws wrote: > > Hi, > > We had a violent^Wheated discussion on IRC about how to move forward > with Luiz's proposed error series. I think we reached consensus. This > note attempts to outline that. This looks great to me, violent^W heated di

[Qemu-devel] Plan for error handling in QMP

2012-07-26 Thread anthony
Hi, We had a violent^Wheated discussion on IRC about how to move forward with Luiz's proposed error series. I think we reached consensus. This note attempts to outline that. Principles -- 1. Errors should be free formed strings with a class code 2. There should be a small number of cl