Re: [Qemu-devel] Open by references and close on exit

2014-02-13 Thread Max Reitz
Hi Benoît, Hm, opening a reference should only result in the refcount of the respective BDS being incremented through bdrv_ref(). Since no new BDS is created, nothing should be added to bdrv_states. When the BDS “closed” through bdrv_unref(), it is only actually closed/deleted if the refcount

[Qemu-devel] Open by references and close on exit

2014-02-12 Thread Benoît Canet
Hi Max, I have a crash when quorum open it's files by references and close them on exit: It seems that bdrv_close_all tries to close them a second time because they are still registered in bdrv_states. Do you think you have the same problem with blkverify ? Should bdrv_open remove the bs from b