Re: [Qemu-devel] Odd code in cpus.c

2011-07-29 Thread Paolo Bonzini
On 07/29/2011 10:49 AM, Jan Kiszka wrote: > > which seems to set kvm signal twice with same values (taking into > account that in kvm_set_signal_mask the set is copied before the call > to kvm_vcpu_ioctl). Indeed. Harmless fortunately. I suspect the duplicate bits in the #ifdef CONFIG_IOTHREA

Re: [Qemu-devel] Odd code in cpus.c

2011-07-29 Thread Jan Kiszka
On 2011-07-29 10:34, Frediano Ziglio wrote: > I don't know that much this code however qemu_kvm_init_cpu_signals > seems a bit strange and duplicate to me, in cpus.c > > > static void qemu_kvm_init_cpu_signals(CPUState *env) > { > int r; > sigset_t set; > struct sigaction sigact; >

[Qemu-devel] Odd code in cpus.c

2011-07-29 Thread Frediano Ziglio
I don't know that much this code however qemu_kvm_init_cpu_signals seems a bit strange and duplicate to me, in cpus.c static void qemu_kvm_init_cpu_signals(CPUState *env) { int r; sigset_t set; struct sigaction sigact; memset(&sigact, 0, sizeof(sigact)); sigact.sa_handler =