Re: [Qemu-devel] Node deletion in aio_set_fd_handler

2018-08-02 Thread Fam Zheng
On Fri, 08/03 08:13, Paolo Bonzini wrote: > On 03/08/2018 04:42, Fam Zheng wrote: > > Paolo, is this else branch dead code (or bug?): > > > > /* If the lock is held, just mark the node as deleted */ > > if (qemu_lockcnt_count(&ctx->list_lock)) { > > node->deleted = 1; >

Re: [Qemu-devel] Node deletion in aio_set_fd_handler

2018-08-02 Thread Paolo Bonzini
On 03/08/2018 04:42, Fam Zheng wrote: > Paolo, is this else branch dead code (or bug?): > > /* If the lock is held, just mark the node as deleted */ > if (qemu_lockcnt_count(&ctx->list_lock)) { > node->deleted = 1; > node->pfd.revents = 0; > } else {

[Qemu-devel] Node deletion in aio_set_fd_handler

2018-08-02 Thread Fam Zheng
Paolo, is this else branch dead code (or bug?): /* If the lock is held, just mark the node as deleted */ if (qemu_lockcnt_count(&ctx->list_lock)) { node->deleted = 1; node->pfd.revents = 0; } else { /* Otherwise, delete it for real. We c