Re: [Qemu-devel] Monitor brain dump

2016-10-07 Thread Kevin Wolf
Am 06.10.2016 um 13:07 hat Paolo Bonzini geschrieben: > On 05/10/2016 19:43, Dr. David Alan Gilbert wrote: > > > Speaking of the pocket calculator: my recommendation would be "nuke from > > > orbit". It adds surprising corner cases to the HMP language, and > > > provides next to no value. > > > >

Re: [Qemu-devel] Monitor brain dump

2016-10-06 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: > > Thanks for this. > >> In the beginning, there was only monitor.c, and it provided what we >> today call HMP, at just under 500 SLOC. >> >> Since then, most (but not all) HMP commands have moved elsewhere, eithe

Re: [Qemu-devel] Monitor brain dump

2016-10-06 Thread Marc-André Lureau
Hi On Thu, Oct 6, 2016 at 3:14 PM Paolo Bonzini wrote: > > > On 06/10/2016 13:10, Peter Maydell wrote: > > On 6 October 2016 at 12:07, Paolo Bonzini wrote: > >> My hunch is that it would be a drop in the sea if monitor.c were > >> refactored properly. > > > > Speaking of refactoring, is there s

Re: [Qemu-devel] Monitor brain dump

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 13:10, Peter Maydell wrote: > On 6 October 2016 at 12:07, Paolo Bonzini wrote: >> My hunch is that it would be a drop in the sea if monitor.c were >> refactored properly. > > Speaking of refactoring, is there scope for splitting things > up so that if the foo subsystem needs to im

Re: [Qemu-devel] Monitor brain dump

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 12:07, Paolo Bonzini wrote: > My hunch is that it would be a drop in the sea if monitor.c were > refactored properly. Speaking of refactoring, is there scope for splitting things up so that if the foo subsystem needs to implement a monitor command it can just call a function

Re: [Qemu-devel] Monitor brain dump

2016-10-06 Thread Paolo Bonzini
On 05/10/2016 19:43, Dr. David Alan Gilbert wrote: > > Speaking of the pocket calculator: my recommendation would be "nuke from > > orbit". It adds surprising corner cases to the HMP language, and > > provides next to no value. > > Huh, didn't realise that existed - I assume you mean get_expr a

Re: [Qemu-devel] Monitor brain dump

2016-10-05 Thread Dr. David Alan Gilbert
* Laszlo Ersek (ler...@redhat.com) wrote: > On 10/05/16 19:43, Dr. David Alan Gilbert wrote: > > I guess the other thing that should be nuked is util/readline.c if we > > can find a good, suitably licensed alternative. > > http://thrysoee.dk/editline/ > https://github.com/antirez/linenoise > >

Re: [Qemu-devel] Monitor brain dump

2016-10-05 Thread Laszlo Ersek
On 10/05/16 19:43, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > Thanks for this. > >> In the beginning, there was only monitor.c, and it provided what we >> today call HMP, at just under 500 SLOC. >> >> Since then, most (but not all) HMP commands have moved e

Re: [Qemu-devel] Monitor brain dump

2016-10-05 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: Thanks for this. > In the beginning, there was only monitor.c, and it provided what we > today call HMP, at just under 500 SLOC. > > Since then, most (but not all) HMP commands have moved elsewhere, either > to the applicable subsystem, or to hmp.c.

Re: [Qemu-devel] Monitor brain dump

2016-10-05 Thread Luiz Capitulino
On Wed, 05 Oct 2016 18:22:28 +0200 Markus Armbruster wrote: > In the beginning, there was only monitor.c, and it provided what we > today call HMP, at just under 500 SLOC. > > Since then, most (but not all) HMP commands have moved elsewhere, either > to the applicable subsystem, or to hmp.c. Co

[Qemu-devel] Monitor brain dump

2016-10-05 Thread Markus Armbruster
In the beginning, there was only monitor.c, and it provided what we today call HMP, at just under 500 SLOC. Since then, most (but not all) HMP commands have moved elsewhere, either to the applicable subsystem, or to hmp.c. Command declaration moved to hmp-commands.hx and hmp-commands-info.hx. Pl