Re: [Qemu-devel] Missing barriers in hw/virtio.c

2011-08-28 Thread Rusty Russell
On Fri, 26 Aug 2011 15:40:08 +1000, David Gibson wrote: > Near the top of hw/virtio.c we have this: > > /* QEMU doesn't strictly need write barriers since everything runs in > * lock-step. We'll leave the calls to wmb() in though to make it > obvious for > * KVM or if kqemu gets SMP support.

Re: [Qemu-devel] Missing barriers in hw/virtio.c

2011-08-25 Thread Paolo Bonzini
On 08/26/2011 07:40 AM, David Gibson wrote: Near the top of hw/virtio.c we have this: /* QEMU doesn't strictly need write barriers since everything runs in * lock-step. We'll leave the calls to wmb() in though to make it obvious for * KVM or if kqemu gets SMP support. * In any case, we

[Qemu-devel] Missing barriers in hw/virtio.c

2011-08-25 Thread David Gibson
Near the top of hw/virtio.c we have this: /* QEMU doesn't strictly need write barriers since everything runs in * lock-step. We'll leave the calls to wmb() in though to make it obvious for * KVM or if kqemu gets SMP support. * In any case, we must prevent the compiler from reordering the code