Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation

2010-10-05 Thread Edgar E. Iglesias
On Tue, Oct 05, 2010 at 06:42:34PM +0200, Alexander Graf wrote: > > On 02.10.2010, at 20:17, John Clark wrote: > > >> Hi, > >> > >> Alex: > >> I think you've missed the part of the patch that renames the _lo -> _hi. > >> As John says, qemu had the hi/lo parts reversed when reading 4xx TLB regs.

Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation

2010-10-05 Thread Alexander Graf
On 02.10.2010, at 20:17, John Clark wrote: >> Hi, >> >> Alex: >> I think you've missed the part of the patch that renames the _lo -> _hi. >> As John says, qemu had the hi/lo parts reversed when reading 4xx TLB regs. >> >> Except for the comments and the define, the patch looks good to me. >> Jo

Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation

2010-10-02 Thread John Clark
> Hi, > > Alex: > I think you've missed the part of the patch that renames the _lo -> _hi. > As John says, qemu had the hi/lo parts reversed when reading 4xx TLB regs. > > Except for the comments and the define, the patch looks good to me. > John, please also add a Signed-off-by line. > > Cheers

Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation

2010-10-02 Thread Alexander Graf
On 02.10.2010, at 19:06, Edgar E. Iglesias wrote: > On Sat, Oct 02, 2010 at 06:55:36PM +0200, Alexander Graf wrote: >> >> On 02.10.2010, at 18:49, John Clark wrote: >> > /* Check from TLB entry */ > -/* XXX: there is a problem here or in the TLB fill code... */ >>>

Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation

2010-10-02 Thread Edgar E. Iglesias
On Sat, Oct 02, 2010 at 06:55:36PM +0200, Alexander Graf wrote: > > On 02.10.2010, at 18:49, John Clark wrote: > > >>>/* Check from TLB entry */ > >>> -/* XXX: there is a problem here or in the TLB fill code... */ > >>> +/* There is no longer a need to force PA

Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation

2010-10-02 Thread John Clark
-target_ulong helper_4xx_tlbre_hi (target_ulong entry) +target_ulong helper_4xx_tlbre_lo (target_ulong entry) >>> >>> Huh? >> >> To summarize, 'tlbre' has two forms: one to retrieve the high bits of >> a TLB entry (TLBHI), and one to retrieve the low bits (TLBLO) of a TLB >> entry.

Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation

2010-10-02 Thread Alexander Graf
On 02.10.2010, at 18:49, John Clark wrote: >>>/* Check from TLB entry */ >>> -/* XXX: there is a problem here or in the TLB fill code... */ >>> +/* There is no longer a need to force PAGE_EXEC permission >>> here */ >>> +/* because of the tlb->attr

Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation

2010-10-02 Thread John Clark
>> /* Check from TLB entry */ >> -/* XXX: there is a problem here or in the TLB fill code... */ >> +/* There is no longer a need to force PAGE_EXEC permission here >> */ >> +/* because of the tlb->attr fix in helper_4xx_tlbwe_lo() */ > > I guess tha

Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation

2010-10-02 Thread Alexander Graf
On 02.10.2010, at 07:38, John Clark wrote: > Hello, > > I found I had to make a few minor changes to the MMU code for the > PowerPC 40x emulation to get NetBSD to run on a virtual PowerPC 405 > core with qemu-system-ppcemb. The 'tlbre' instruction was not working, > and permission checking for a

[Qemu-devel] Minor MMU fixes for PowerPC 40x emulation

2010-10-01 Thread John Clark
Hello, I found I had to make a few minor changes to the MMU code for the PowerPC 40x emulation to get NetBSD to run on a virtual PowerPC 405 core with qemu-system-ppcemb. The 'tlbre' instruction was not working, and permission checking for a TLB entry was not as strict as it should be. Diffs are i