Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-17 Thread Avi Kivity
On 02/17/2011 03:37 PM, Anthony Liguori wrote: On 02/17/2011 07:25 AM, Avi Kivity wrote: On 02/17/2011 03:10 PM, Anthony Liguori wrote: On 02/17/2011 06:23 AM, Avi Kivity wrote: On 02/17/2011 02:12 PM, Anthony Liguori wrote: (btw what happens in a non-UTF-8 locale? I guess we should just reje

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-17 Thread Anthony Liguori
On 02/17/2011 07:59 AM, Peter Maydell wrote: On 17 February 2011 13:37, Anthony Liguori wrote: An application has to explicitly support an encoding. It is not transparent. UCS2/UTF-16 means that strings are not 'const char *'s but 'const wchar_t *' where typedef unsigned short wchar_t;.

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-17 Thread Peter Maydell
On 17 February 2011 13:37, Anthony Liguori wrote: > An application has to explicitly support an encoding.  It is not > transparent.  UCS2/UTF-16 means that strings are not 'const char *'s but > 'const wchar_t *' where typedef unsigned short wchar_t;. > > QEMU assumes, in lots of places that string

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-17 Thread Anthony Liguori
On 02/17/2011 07:25 AM, Avi Kivity wrote: On 02/17/2011 03:10 PM, Anthony Liguori wrote: On 02/17/2011 06:23 AM, Avi Kivity wrote: On 02/17/2011 02:12 PM, Anthony Liguori wrote: (btw what happens in a non-UTF-8 locale? I guess we should just reject unencodable strings). While QEMU is mostly

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-17 Thread Anthony Liguori
On 02/17/2011 07:25 AM, Avi Kivity wrote: On 02/17/2011 03:10 PM, Anthony Liguori wrote: On 02/17/2011 06:23 AM, Avi Kivity wrote: On 02/17/2011 02:12 PM, Anthony Liguori wrote: (btw what happens in a non-UTF-8 locale? I guess we should just reject unencodable strings). While QEMU is mostly

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-17 Thread Avi Kivity
On 02/17/2011 03:10 PM, Anthony Liguori wrote: On 02/17/2011 06:23 AM, Avi Kivity wrote: On 02/17/2011 02:12 PM, Anthony Liguori wrote: (btw what happens in a non-UTF-8 locale? I guess we should just reject unencodable strings). While QEMU is mostly ASCII internally, for the purposes of the

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-17 Thread Anthony Liguori
On 02/17/2011 06:23 AM, Avi Kivity wrote: On 02/17/2011 02:12 PM, Anthony Liguori wrote: (btw what happens in a non-UTF-8 locale? I guess we should just reject unencodable strings). While QEMU is mostly ASCII internally, for the purposes of the JSON parser, we always encode and decode UTF-8.

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-17 Thread Amit Shah
On (Wed) 16 Feb 2011 [08:41:27], Anthony Liguori wrote: > On 02/16/2011 08:39 AM, Amit Shah wrote: > >On (Tue) 15 Feb 2011 [17:13:13], Anthony Liguori wrote: > >>On 02/15/2011 10:26 AM, Chris Wright wrote: > >>>revisit new -> old migration > >>>- Amit offers virtio-serial patches and some legwork

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-17 Thread Avi Kivity
On 02/17/2011 02:12 PM, Anthony Liguori wrote: (btw what happens in a non-UTF-8 locale? I guess we should just reject unencodable strings). While QEMU is mostly ASCII internally, for the purposes of the JSON parser, we always encode and decode UTF-8. We reject invalid UTF-8 sequences. But

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-17 Thread Anthony Liguori
On 02/17/2011 03:26 AM, Avi Kivity wrote: On 02/16/2011 03:34 PM, Anthony Liguori wrote: On 02/16/2011 04:24 AM, Avi Kivity wrote: On 02/16/2011 01:13 AM, Anthony Liguori wrote: On 02/15/2011 10:26 AM, Chris Wright wrote: QAPI and QMP - Anthony adding a new wiki page to describe all of this

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-17 Thread Avi Kivity
On 02/16/2011 03:34 PM, Anthony Liguori wrote: On 02/16/2011 04:24 AM, Avi Kivity wrote: On 02/16/2011 01:13 AM, Anthony Liguori wrote: On 02/15/2011 10:26 AM, Chris Wright wrote: QAPI and QMP - Anthony adding a new wiki page to describe all of this http://wiki.qemu.org/Features/QAPI [

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-16 Thread Anthony Liguori
On 02/16/2011 08:39 AM, Amit Shah wrote: On (Tue) 15 Feb 2011 [17:13:13], Anthony Liguori wrote: On 02/15/2011 10:26 AM, Chris Wright wrote: revisit new -> old migration - Amit offers virtio-serial patches and some legwork So, to me, migration correctness trumps compatibili

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-16 Thread Amit Shah
On (Tue) 15 Feb 2011 [17:13:13], Anthony Liguori wrote: > On 02/15/2011 10:26 AM, Chris Wright wrote: > > > >revisit new -> old migration > >- Amit offers virtio-serial patches and some legwork > > So, to me, migration correctness trumps compatibility. I don't > think compatibility is useful if

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-16 Thread Anthony Liguori
On 02/16/2011 04:24 AM, Avi Kivity wrote: On 02/16/2011 01:13 AM, Anthony Liguori wrote: On 02/15/2011 10:26 AM, Chris Wright wrote: QAPI and QMP - Anthony adding a new wiki page to describe all of this http://wiki.qemu.org/Features/QAPI [ 'change', {'device': 'str', 'target': 'str'}, {'

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-16 Thread Avi Kivity
On 02/16/2011 01:13 AM, Anthony Liguori wrote: On 02/15/2011 10:26 AM, Chris Wright wrote: QAPI and QMP - Anthony adding a new wiki page to describe all of this http://wiki.qemu.org/Features/QAPI [ 'change', {'device': 'str', 'target': 'str'}, {'arg': 'str'}, 'none' ] -> void qmp_ch

Re: [Qemu-devel] KVM call minutes for Feb 15

2011-02-15 Thread Anthony Liguori
On 02/15/2011 10:26 AM, Chris Wright wrote: QAPI and QMP - Anthony adding a new wiki page to describe all of this http://wiki.qemu.org/Features/QAPI - specified in formal schema using JSON - includes documenation in javadoc-like syntax - can generate api (possibly protocol) docs

[Qemu-devel] KVM call minutes for Feb 15

2011-02-15 Thread Chris Wright
QAPI and QMP - Anthony adding a new wiki page to describe all of this - specified in formal schema using JSON - includes documenation in javadoc-like syntax - can generate api (possibly protocol) docs - documenting each command and expected errors - creates marshalling functions and C interfa