Re: [Qemu-devel] I/O accounting overhaul

2015-06-10 Thread Alberto Garcia
On Mon 08 Jun 2015 03:21:19 PM CEST, Stefan Hajnoczi wrote: > Please structure the patches so that each statistic or group of > statistics has its own patch. Yes, that's the plan. >> uint64_t queue_depth[BLOCK_MAX_IOTYPE]; >> >>Average number of requests. Similar to the previous one. It w

Re: [Qemu-devel] I/O accounting overhaul

2015-06-08 Thread Stefan Hajnoczi
On Wed, Jun 03, 2015 at 03:40:42PM +0200, Alberto Garcia wrote: Please structure the patches so that each statistic or group of statistics has its own patch. That will make it easy to review and possibly merge a subset if some of the statistics prove to be controversial. > uint64_t queue_depth[B

Re: [Qemu-devel] I/O accounting overhaul

2015-06-05 Thread Alberto Garcia
On Wed 03 Jun 2015 04:18:45 PM CEST, Eric Blake wrote: >> The accounting stats are stored in the BlockDriverState, but they're >> actually from the device backed by the BDS, so they could probably be >> moved there. For the interface we could extend BlockDeviceStats and >> add the new fields, but

Re: [Qemu-devel] I/O accounting overhaul

2015-06-03 Thread Eric Blake
On 06/03/2015 07:40 AM, Alberto Garcia wrote: > Hello, > > I would like to retake the work that Benoît was about to start last > year and extend the I/O accounting in QEMU. I was reading the past > discussions and I will try to summarize all the ideas. > > The current accounting code collects the

[Qemu-devel] I/O accounting overhaul

2015-06-03 Thread Alberto Garcia
Hello, I would like to retake the work that Benoît was about to start last year and extend the I/O accounting in QEMU. I was reading the past discussions and I will try to summarize all the ideas. The current accounting code collects the following information: typedef struct BlockAcctStats {