Re: [Qemu-devel] Holding the BQL for emulate_ppc_hypercall

2016-10-25 Thread Alex Bennée
Nikunj A Dadhania writes: > Alex Bennée writes: > >> Hi, >> >> In the MTTCG patch set one of the big patches is to remove the >> requirement to hold the BQL while running code: >> >> tcg: drop global lock during TCG code execution >> >> And this broke the PPC code because emulate_ppc_hypercal

Re: [Qemu-devel] Holding the BQL for emulate_ppc_hypercall

2016-10-25 Thread Alex Bennée
David Gibson writes: > On Mon, Oct 24, 2016 at 03:44:01PM +0100, Alex Bennée wrote: >> >> Alex Bennée writes: >> >> > Hi, >> > >> > In the MTTCG patch set one of the big patches is to remove the >> > requirement to hold the BQL while running code: >> > >> > tcg: drop global lock during TCG co

Re: [Qemu-devel] Holding the BQL for emulate_ppc_hypercall

2016-10-24 Thread Nikunj A Dadhania
Alex Bennée writes: > Hi, > > In the MTTCG patch set one of the big patches is to remove the > requirement to hold the BQL while running code: > > tcg: drop global lock during TCG code execution > > And this broke the PPC code because emulate_ppc_hypercall can cause > changes to the global stat

Re: [Qemu-devel] Holding the BQL for emulate_ppc_hypercall

2016-10-24 Thread David Gibson
On Mon, Oct 24, 2016 at 03:44:01PM +0100, Alex Bennée wrote: > > Alex Bennée writes: > > > Hi, > > > > In the MTTCG patch set one of the big patches is to remove the > > requirement to hold the BQL while running code: > > > > tcg: drop global lock during TCG code execution > > > > And this bro

Re: [Qemu-devel] Holding the BQL for emulate_ppc_hypercall

2016-10-24 Thread Alex Bennée
Alex Bennée writes: > Hi, > > In the MTTCG patch set one of the big patches is to remove the > requirement to hold the BQL while running code: > > tcg: drop global lock during TCG code execution > > And this broke the PPC code because emulate_ppc_hypercall can cause > changes to the global sta

[Qemu-devel] Holding the BQL for emulate_ppc_hypercall

2016-10-24 Thread Alex Bennée
Hi, In the MTTCG patch set one of the big patches is to remove the requirement to hold the BQL while running code: tcg: drop global lock during TCG code execution And this broke the PPC code because emulate_ppc_hypercall can cause changes to the global state. This function just calls spapr_hyp