Re: [Qemu-devel] Error handling in cpu_x86_create

2013-08-02 Thread Jan Kiszka
On 2013-07-30 14:21, Igor Mammedov wrote: > On Tue, 30 Jul 2013 13:00:40 +0200 > Jan Kiszka wrote: > >> Hi Igor, >> >> just noticed by chance that error handling in cpu_x86_create is likely >> broken after your changes. Any error after cpu = ...object_new() will >> not properly release the CPU ob

Re: [Qemu-devel] Error handling in cpu_x86_create

2013-07-30 Thread Igor Mammedov
On Tue, 30 Jul 2013 13:00:40 +0200 Jan Kiszka wrote: > Hi Igor, > > just noticed by chance that error handling in cpu_x86_create is likely > broken after your changes. Any error after cpu = ...object_new() will > not properly release the CPU object again nor report NULL to the caller. > That mea

[Qemu-devel] Error handling in cpu_x86_create

2013-07-30 Thread Jan Kiszka
Hi Igor, just noticed by chance that error handling in cpu_x86_create is likely broken after your changes. Any error after cpu = ...object_new() will not properly release the CPU object again nor report NULL to the caller. That means errors should slip through, no? And cpu_x86_init looks similar.