Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-13 Thread Avi Kivity
On 12/13/2011 03:36 PM, Anthony Liguori wrote: > On 12/13/2011 05:06 AM, Avi Kivity wrote: >> On 12/12/2011 06:26 PM, Anthony Liguori wrote: >>> >>> Nope, it has to be dropped. >>> >>> Commands using CMD_ASYNC may fail in arbitrary ways because of the way >>> error reporting is done. This is an un

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-13 Thread Anthony Liguori
On 12/13/2011 05:06 AM, Avi Kivity wrote: On 12/12/2011 06:26 PM, Anthony Liguori wrote: Nope, it has to be dropped. Commands using CMD_ASYNC may fail in arbitrary ways because of the way error reporting is done. This is an unfixable problem until we eliminate all uses of qerror_report().

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-13 Thread Anthony Liguori
On 12/13/2011 03:03 AM, Alon Levy wrote: On Mon, Dec 12, 2011 at 11:53:28AM -0600, Anthony Liguori wrote: On 12/12/2011 11:22 AM, Alon Levy wrote: On Mon, Dec 12, 2011 at 10:24:53AM -0600, Anthony Liguori wrote: On 12/12/2011 10:00 AM, Alon Levy wrote: On Mon, Dec 12, 2011 at 03:23:35PM +

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-13 Thread Avi Kivity
On 12/12/2011 06:26 PM, Anthony Liguori wrote: > > Nope, it has to be dropped. > > Commands using CMD_ASYNC may fail in arbitrary ways because of the way > error reporting is done. This is an unfixable problem until we > eliminate all uses of qerror_report(). > Why don't we eliminate all uses for

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-13 Thread Gerd Hoffmann
Hi, > We aren't breaking an ABI here. libvirt can detect that this command is > gone and probe for the new command. Please stop this. There are libvirt versions in the wild which can't deal with this and thus will break, no matter how hard you try to wave it away. The question is not wheneve

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-13 Thread Alon Levy
On Mon, Dec 12, 2011 at 11:53:28AM -0600, Anthony Liguori wrote: > On 12/12/2011 11:22 AM, Alon Levy wrote: > >On Mon, Dec 12, 2011 at 10:24:53AM -0600, Anthony Liguori wrote: > >>On 12/12/2011 10:00 AM, Alon Levy wrote: > >>>On Mon, Dec 12, 2011 at 03:23:35PM +, Stefan Hajnoczi wrote: > On

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-12 Thread Anthony Liguori
On 12/12/2011 11:22 AM, Alon Levy wrote: On Mon, Dec 12, 2011 at 10:24:53AM -0600, Anthony Liguori wrote: On 12/12/2011 10:00 AM, Alon Levy wrote: On Mon, Dec 12, 2011 at 03:23:35PM +, Stefan Hajnoczi wrote: On Mon, Dec 12, 2011 at 12:39 PM, Gerd Hoffmann wrote: On 12/12/11 13:10, Stefa

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-12 Thread Alon Levy
On Mon, Dec 12, 2011 at 10:24:53AM -0600, Anthony Liguori wrote: > On 12/12/2011 10:00 AM, Alon Levy wrote: > >On Mon, Dec 12, 2011 at 03:23:35PM +, Stefan Hajnoczi wrote: > >>On Mon, Dec 12, 2011 at 12:39 PM, Gerd Hoffmann wrote: > >>>On 12/12/11 13:10, Stefan Hajnoczi wrote: > On Mon, De

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-12 Thread Anthony Liguori
On 12/12/2011 10:08 AM, Luiz Capitulino wrote: On Mon, 12 Dec 2011 17:50:46 +0200 Alon Levy wrote: On Thu, Dec 08, 2011 at 05:45:44PM -0200, Luiz Capitulino wrote: Hi there, I'm about to completely drop the MONITOR_CMD_ASYNC API, but it turns out that the command client_migrate_info uses it.

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-12 Thread Anthony Liguori
On 12/12/2011 10:00 AM, Alon Levy wrote: On Mon, Dec 12, 2011 at 03:23:35PM +, Stefan Hajnoczi wrote: On Mon, Dec 12, 2011 at 12:39 PM, Gerd Hoffmann wrote: On 12/12/11 13:10, Stefan Hajnoczi wrote: On Mon, Dec 12, 2011 at 11:29 AM, Gerd Hoffmann wrote: On 12/12/11 11:18, Stefan Hajnocz

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-12 Thread Anthony Liguori
On 12/11/2011 04:29 AM, Alon Levy wrote: On Thu, Dec 08, 2011 at 05:45:44PM -0200, Luiz Capitulino wrote: Hi there, I'm about to completely drop the MONITOR_CMD_ASYNC API, but it turns out that the command client_migrate_info uses it. That's a legacy interface and has to be dropped, no command

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-12 Thread Luiz Capitulino
On Mon, 12 Dec 2011 17:50:46 +0200 Alon Levy wrote: > On Thu, Dec 08, 2011 at 05:45:44PM -0200, Luiz Capitulino wrote: > > Hi there, > > > > I'm about to completely drop the MONITOR_CMD_ASYNC API, but it turns out > > that > > the command client_migrate_info uses it. That's a legacy interface a

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-12 Thread Alon Levy
On Mon, Dec 12, 2011 at 03:23:35PM +, Stefan Hajnoczi wrote: > On Mon, Dec 12, 2011 at 12:39 PM, Gerd Hoffmann wrote: > > On 12/12/11 13:10, Stefan Hajnoczi wrote: > >> On Mon, Dec 12, 2011 at 11:29 AM, Gerd Hoffmann wrote: > >>> On 12/12/11 11:18, Stefan Hajnoczi wrote: > On Sun, Dec 11

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-12 Thread Alon Levy
On Thu, Dec 08, 2011 at 05:45:44PM -0200, Luiz Capitulino wrote: > Hi there, > > I'm about to completely drop the MONITOR_CMD_ASYNC API, but it turns out that > the command client_migrate_info uses it. That's a legacy interface and has to > be dropped, no command should be using it... > Why has

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-12 Thread Stefan Hajnoczi
On Mon, Dec 12, 2011 at 12:39 PM, Gerd Hoffmann wrote: > On 12/12/11 13:10, Stefan Hajnoczi wrote: >> On Mon, Dec 12, 2011 at 11:29 AM, Gerd Hoffmann wrote: >>> On 12/12/11 11:18, Stefan Hajnoczi wrote: On Sun, Dec 11, 2011 at 10:29 AM, Alon Levy wrote: > On Thu, Dec 08, 2011 at 05:45:4

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-12 Thread Gerd Hoffmann
On 12/12/11 13:10, Stefan Hajnoczi wrote: > On Mon, Dec 12, 2011 at 11:29 AM, Gerd Hoffmann wrote: >> On 12/12/11 11:18, Stefan Hajnoczi wrote: >>> On Sun, Dec 11, 2011 at 10:29 AM, Alon Levy wrote: On Thu, Dec 08, 2011 at 05:45:44PM -0200, Luiz Capitulino wrote: > Hi there, > >

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-12 Thread Stefan Hajnoczi
On Mon, Dec 12, 2011 at 11:29 AM, Gerd Hoffmann wrote: > On 12/12/11 11:18, Stefan Hajnoczi wrote: >> On Sun, Dec 11, 2011 at 10:29 AM, Alon Levy wrote: >>> On Thu, Dec 08, 2011 at 05:45:44PM -0200, Luiz Capitulino wrote: Hi there, I'm about to completely drop the MONITOR_CMD_ASYNC

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-12 Thread Gerd Hoffmann
On 12/12/11 11:18, Stefan Hajnoczi wrote: > On Sun, Dec 11, 2011 at 10:29 AM, Alon Levy wrote: >> On Thu, Dec 08, 2011 at 05:45:44PM -0200, Luiz Capitulino wrote: >>> Hi there, >>> >>> I'm about to completely drop the MONITOR_CMD_ASYNC API, but it turns out >>> that >>> the command client_migrate

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-12 Thread Stefan Hajnoczi
On Sun, Dec 11, 2011 at 10:29 AM, Alon Levy wrote: > On Thu, Dec 08, 2011 at 05:45:44PM -0200, Luiz Capitulino wrote: >> Hi there, >> >> I'm about to completely drop the MONITOR_CMD_ASYNC API, but it turns out that >> the command client_migrate_info uses it. That's a legacy interface and has to >>

Re: [Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-11 Thread Alon Levy
On Thu, Dec 08, 2011 at 05:45:44PM -0200, Luiz Capitulino wrote: > Hi there, > > I'm about to completely drop the MONITOR_CMD_ASYNC API, but it turns out that > the command client_migrate_info uses it. That's a legacy interface and has to > be dropped, no command should be using it... > > Somethi

[Qemu-devel] Dropping the MONITOR_CMD_ASYNC

2011-12-08 Thread Luiz Capitulino
Hi there, I'm about to completely drop the MONITOR_CMD_ASYNC API, but it turns out that the command client_migrate_info uses it. That's a legacy interface and has to be dropped, no command should be using it... Something tells me that if I just drop it (and change the command to use the regular i