Re: [Qemu-devel] Build Broken?

2014-05-13 Thread Michael Tokarev
13.05.2014 18:17, Tom Musta wrote: > The current origin/master is not building for me: > > LINK qemu-img > qemu-img.o: In function `add_format_to_seq': > /bghome/tmusta/powerisa/qemu/qemu/qemu-img.c:73: undefined reference to > `g_sequence_lookup' > collect2: ld returned 1 exit status > make:

Re: [Qemu-devel] Build Broken?

2014-05-13 Thread Paolo Bonzini
Il 13/05/2014 17:55, Peter Maydell ha scritto: On 13 May 2014 16:34, Michael Tokarev wrote: 13.05.2014 18:17, Tom Musta wrote: The current origin/master is not building for me: LINK qemu-img qemu-img.o: In function `add_format_to_seq': /bghome/tmusta/powerisa/qemu/qemu/qemu-img.c:73: undef

Re: [Qemu-devel] Build Broken?

2014-05-13 Thread Tom Musta
On 5/13/2014 10:55 AM, Peter Maydell wrote: > On 13 May 2014 16:34, Michael Tokarev wrote: >> 13.05.2014 18:17, Tom Musta wrote: >>> The current origin/master is not building for me: >>> >>> LINK qemu-img >>> qemu-img.o: In function `add_format_to_seq': >>> /bghome/tmusta/powerisa/qemu/qemu/qem

Re: [Qemu-devel] Build Broken?

2014-05-13 Thread Peter Maydell
On 13 May 2014 16:34, Michael Tokarev wrote: > 13.05.2014 18:17, Tom Musta wrote: >> The current origin/master is not building for me: >> >> LINK qemu-img >> qemu-img.o: In function `add_format_to_seq': >> /bghome/tmusta/powerisa/qemu/qemu/qemu-img.c:73: undefined reference to >> `g_sequence_l

Re: [Qemu-devel] Build Broken?

2014-05-13 Thread Cornelia Huck
On Tue, 13 May 2014 19:34:53 +0400 Michael Tokarev wrote: > 13.05.2014 18:17, Tom Musta wrote: > > The current origin/master is not building for me: > > > > LINK qemu-img > > qemu-img.o: In function `add_format_to_seq': > > /bghome/tmusta/powerisa/qemu/qemu/qemu-img.c:73: undefined reference

[Qemu-devel] Build Broken?

2014-05-13 Thread Tom Musta
The current origin/master is not building for me: LINK qemu-img qemu-img.o: In function `add_format_to_seq': /bghome/tmusta/powerisa/qemu/qemu/qemu-img.c:73: undefined reference to `g_sequence_lookup' collect2: ld returned 1 exit status make: *** [qemu-img] Error 1 Bisection points me to thi

Re: [Qemu-devel] Build broken for i386-softmmu with --enable-debug

2012-06-28 Thread Dunrong Huang
I also met this problem, I fix it by casting incompatible function type to correct function type. @@ -2950,20 +2950,20 @@ static const SSEFunc_0_pp sse_op_table2[3 * 8][2] = { static const SSEFunc_0_pi sse_op_table3a[4] = { gen_helper_cvtsi2ss, gen_helper_cvtsi2sd, -X86_64_ONLY(gen_

[Qemu-devel] Build broken for i386-softmmu with --enable-debug

2012-06-28 Thread Stefan Weil
Hi Blue, commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table type safety which now raises compiler errors when latest QEMU was configured with --enable-debug. CC i386-softmmu/target-i386/translate.o cc1: warnings being treated as errors /qemu/target-i386/translate.c: In function ‘

Re: [Qemu-devel] Build broken -- linux-user: take RESERVED_VA into account for g2h_valid()

2012-04-12 Thread Peter Maydell
On 12 April 2012 08:41, Peter Maydell wrote: > On 12 April 2012 05:50, Stefan Weil wrote: >> Please use 'uintptr_t' instead of 'unsigned long'. >> >> It does not matter in this special case, but guest_base and >> reserved_va will be changed by my patches for w64 to use >> uintptr_t. The data type

Re: [Qemu-devel] Build broken -- linux-user: take RESERVED_VA into account for g2h_valid()

2012-04-12 Thread Peter Maydell
On 12 April 2012 05:50, Stefan Weil wrote: > Please use 'uintptr_t' instead of 'unsigned long'. > > It does not matter in this special case, but guest_base and > reserved_va will be changed by my patches for w64 to use > uintptr_t. The data types 'long' and 'unsigned long' are > should be avoided.

Re: [Qemu-devel] Build broken -- linux-user: take RESERVED_VA into account for g2h_valid()

2012-04-11 Thread Stefan Weil
Am 11.04.2012 22:55, schrieb Peter Maydell: On 11 April 2012 20:23, Brad Smith wrote: The following commit broke the build.. linux-user: take RESERVED_VA into account for g2h_valid() Whoops. bsd-user is a bit unloved, I'm afraid. Can you try the following one-line fix? If it works then I'll

Re: [Qemu-devel] Build broken -- linux-user: take RESERVED_VA into account for g2h_valid()

2012-04-11 Thread Brad Smith
On 11/04/12 4:55 PM, Peter Maydell wrote: On 11 April 2012 20:23, Brad Smith wrote: The following commit broke the build.. linux-user: take RESERVED_VA into account for g2h_valid() Whoops. bsd-user is a bit unloved, I'm afraid. Can you try the following one-line fix? If it works then I'll su

Re: [Qemu-devel] Build broken -- linux-user: take RESERVED_VA into account for g2h_valid()

2012-04-11 Thread Peter Maydell
On 11 April 2012 20:23, Brad Smith wrote: > The following commit broke the build.. > > linux-user: take RESERVED_VA into account for g2h_valid() Whoops. bsd-user is a bit unloved, I'm afraid. Can you try the following one-line fix? If it works then I'll submit it to the mailing list as a proper p

[Qemu-devel] Build broken -- linux-user: take RESERVED_VA into account for g2h_valid()

2012-04-11 Thread Brad Smith
The following commit broke the build.. linux-user: take RESERVED_VA into account for g2h_valid() When running with -R (RESERVED_VA > 0) all guest virtual addresses are within the [0..RESERVED_VA] range. Reflect this with g2h_valid() too so we can safely check for boundaries of our guest address

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-26 Thread Blue Swirl
On Mon, Mar 26, 2012 at 15:18, Anthony Liguori wrote: > On 03/26/2012 10:15 AM, Michael Roth wrote: >> >> On Mon, Mar 26, 2012 at 09:55:15AM -0500, Anthony Liguori wrote: >> >> Yup, I can't confirm the BSD fix atm though, only that it doesn't break >> builds >> on linux/w32. Send anyway or wait fo

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-26 Thread Michal Privoznik
On 26.03.2012 17:18, Anthony Liguori wrote: > On 03/26/2012 10:15 AM, Michael Roth wrote: >> On Mon, Mar 26, 2012 at 09:55:15AM -0500, Anthony Liguori wrote: >> >> Yup, I can't confirm the BSD fix atm though, only that it doesn't >> break builds >> on linux/w32. Send anyway or wait for confirmation

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-26 Thread Anthony Liguori
On 03/26/2012 10:15 AM, Michael Roth wrote: On Mon, Mar 26, 2012 at 09:55:15AM -0500, Anthony Liguori wrote: Yup, I can't confirm the BSD fix atm though, only that it doesn't break builds on linux/w32. Send anyway or wait for confirmation? Brad/Michal, Can you confirm the fix? Regards, Anth

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-26 Thread Michael Roth
On Mon, Mar 26, 2012 at 09:55:15AM -0500, Anthony Liguori wrote: > On 03/26/2012 09:53 AM, Michael Roth wrote: > >On Mon, Mar 26, 2012 at 11:28:01AM +0200, Michal Privoznik wrote: > >>On 25.03.2012 03:19, Brad Smith wrote: > >>>On 20/03/12 9:28 AM, Brad Smith wrote: > On 20/03/12 6:14 AM, Micha

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-26 Thread Anthony Liguori
On 03/26/2012 09:53 AM, Michael Roth wrote: On Mon, Mar 26, 2012 at 11:28:01AM +0200, Michal Privoznik wrote: On 25.03.2012 03:19, Brad Smith wrote: On 20/03/12 9:28 AM, Brad Smith wrote: On 20/03/12 6:14 AM, Michal Privoznik wrote: On 18.03.2012 02:09, Brad Smith wrote: Michal, http://git.

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-26 Thread Michael Roth
On Mon, Mar 26, 2012 at 11:28:01AM +0200, Michal Privoznik wrote: > On 25.03.2012 03:19, Brad Smith wrote: > > On 20/03/12 9:28 AM, Brad Smith wrote: > >> On 20/03/12 6:14 AM, Michal Privoznik wrote: > >>> On 18.03.2012 02:09, Brad Smith wrote: > Michal, > > http://git.qemu.org/?p=qe

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-26 Thread Michal Privoznik
On 25.03.2012 03:19, Brad Smith wrote: > On 20/03/12 9:28 AM, Brad Smith wrote: >> On 20/03/12 6:14 AM, Michal Privoznik wrote: >>> On 18.03.2012 02:09, Brad Smith wrote: Michal, http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2 >

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-25 Thread Michael Roth
On Sat, Mar 24, 2012 at 09:19:20PM -0400, Brad Smith wrote: > On 20/03/12 9:28 AM, Brad Smith wrote: > >On 20/03/12 6:14 AM, Michal Privoznik wrote: > >>On 18.03.2012 02:09, Brad Smith wrote: > >>>Michal, > >>> > >>>http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-24 Thread Brad Smith
On 20/03/12 9:28 AM, Brad Smith wrote: On 20/03/12 6:14 AM, Michal Privoznik wrote: On 18.03.2012 02:09, Brad Smith wrote: Michal, http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2 This broke the build. Un-break the tree. Can you please be more specific

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-20 Thread Brad Smith
On 20/03/12 6:14 AM, Michal Privoznik wrote: On 18.03.2012 02:09, Brad Smith wrote: Michal, http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2 This broke the build. Un-break the tree. Can you please be more specific? It works for me so I don't have a clue

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-20 Thread Michal Privoznik
On 18.03.2012 02:09, Brad Smith wrote: > Michal, > > http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2 > > > This broke the build. Un-break the tree. > Can you please be more specific? It works for me so I don't have a clue what are you referring to. I mean,

[Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-17 Thread Brad Smith
Michal, http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2 This broke the build. Un-break the tree. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

Re: [Qemu-devel] Build broken

2011-08-08 Thread malc
On Mon, 8 Aug 2011, Kevin Wolf wrote: > Am 05.08.2011 18:49, schrieb malc: > > On Fri, 5 Aug 2011, Stefan Hajnoczi wrote: > > [..snip..] > > Feel free to push it. (Original code was by Anthony, then heavily > modified by me, and after that modified again by Stefan) > > Acked-by: Kevin Wolf

Re: [Qemu-devel] Build broken

2011-08-08 Thread Kevin Wolf
Am 05.08.2011 18:49, schrieb malc: > On Fri, 5 Aug 2011, Stefan Hajnoczi wrote: > >> On Fri, Aug 5, 2011 at 7:22 AM, malc wrote: >>> >>> /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function >>> 'coroutine_new': >>> /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:160:16: error: 'arg.i

Re: [Qemu-devel] Build broken

2011-08-05 Thread Stefan Hajnoczi
On Fri, Aug 5, 2011 at 5:49 PM, malc wrote: > On Fri, 5 Aug 2011, Stefan Hajnoczi wrote: > >> On Fri, Aug 5, 2011 at 7:22 AM, malc wrote: >> > >> > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function >> > 'coroutine_new': >> > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:160:16:

Re: [Qemu-devel] Build broken

2011-08-05 Thread malc
On Fri, 5 Aug 2011, Stefan Hajnoczi wrote: > On Fri, Aug 5, 2011 at 7:22 AM, malc wrote: > > > > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function > > 'coroutine_new': > > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:160:16: error: 'arg.i[1]' > > may be used uninitialized in t

Re: [Qemu-devel] Build broken

2011-08-05 Thread Stefan Hajnoczi
On Fri, Aug 5, 2011 at 10:09 AM, Kevin Wolf wrote: > Am 05.08.2011 10:48, schrieb Stefan Hajnoczi: >> On Fri, Aug 5, 2011 at 8:29 AM, Kevin Wolf wrote: >>> Am 05.08.2011 08:22, schrieb malc: /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function 'coroutine_new': /home

Re: [Qemu-devel] Build broken

2011-08-05 Thread Kevin Wolf
Am 05.08.2011 10:48, schrieb Stefan Hajnoczi: > On Fri, Aug 5, 2011 at 8:29 AM, Kevin Wolf wrote: >> Am 05.08.2011 08:22, schrieb malc: >>> >>> /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function >>> 'coroutine_new': >>> /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:160:16: error:

Re: [Qemu-devel] Build broken

2011-08-05 Thread Stefan Hajnoczi
On Fri, Aug 5, 2011 at 7:22 AM, malc wrote: > > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function > 'coroutine_new': > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:160:16: error: 'arg.i[1]' > may be used uninitialized in this function > /home/malc/x/rcs/git/qemuorg/coroutine-uc

Re: [Qemu-devel] Build broken

2011-08-05 Thread Stefan Hajnoczi
On Fri, Aug 5, 2011 at 8:29 AM, Kevin Wolf wrote: > Am 05.08.2011 08:22, schrieb malc: >> >> /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function >> 'coroutine_new': >> /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:160:16: error: 'arg.i[1]' >> may be used uninitialized in this func

Re: [Qemu-devel] Build broken

2011-08-05 Thread Kevin Wolf
Am 05.08.2011 08:22, schrieb malc: > > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function > 'coroutine_new': > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:160:16: error: 'arg.i[1]' > may be used uninitialized in this function > /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:

[Qemu-devel] Build broken

2011-08-04 Thread malc
/home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function 'coroutine_new': /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:160:16: error: 'arg.i[1]' may be used uninitialized in this function /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:136:18: note: 'arg.i[1]' was declared here dif