Re: [Qemu-devel] Adding Save States menu items

2016-10-07 Thread Peter Maydell
On 7 October 2016 at 15:55, Programmingkid wrote: > This feature could be very helpful to many users. It could help others > to be more productive. Yes, it's worth having. But it should be in the VM management layer, not in QEMU. > http://wiki.qemu.org/Features/SnapshottingImprovements > This pa

Re: [Qemu-devel] Adding Save States menu items

2016-10-07 Thread Daniel P. Berrange
On Fri, Oct 07, 2016 at 10:55:23AM -0400, Programmingkid wrote: > > On Oct 7, 2016, at 5:09 AM, Daniel P. Berrange wrote: > > > On Thu, Oct 06, 2016 at 02:59:49PM -0500, Eric Blake wrote: > >> On 10/06/2016 09:22 AM, Programmingkid wrote: > >>> Would you accept a patch that added "Save State" and

Re: [Qemu-devel] Adding Save States menu items

2016-10-07 Thread Programmingkid
On Oct 7, 2016, at 5:09 AM, Daniel P. Berrange wrote: > On Thu, Oct 06, 2016 at 02:59:49PM -0500, Eric Blake wrote: >> On 10/06/2016 09:22 AM, Programmingkid wrote: >>> Would you accept a patch that added "Save State" and "Restore State" menu >>> items to the cocoa interface? They would allow th

Re: [Qemu-devel] Adding Save States menu items

2016-10-07 Thread Programmingkid
On Oct 7, 2016, at 5:14 AM, Daniel P. Berrange wrote: > On Fri, Oct 07, 2016 at 09:21:36AM +0200, Paolo Bonzini wrote: >> >> >> On 06/10/2016 22:26, Eric Blake wrote: > Doesn't virt-manager already do this? What do we gain by duplicating > GUI functionality at this level that is alread

Re: [Qemu-devel] Adding Save States menu items

2016-10-07 Thread Daniel P. Berrange
On Fri, Oct 07, 2016 at 09:21:36AM +0200, Paolo Bonzini wrote: > > > On 06/10/2016 22:26, Eric Blake wrote: > > > > Doesn't virt-manager already do this? What do we gain by duplicating > > > > GUI functionality at this level that is already implemented at higher > > > > levels? Not that I'm opp

Re: [Qemu-devel] Adding Save States menu items

2016-10-07 Thread Daniel P. Berrange
On Thu, Oct 06, 2016 at 02:59:49PM -0500, Eric Blake wrote: > On 10/06/2016 09:22 AM, Programmingkid wrote: > > Would you accept a patch that added "Save State" and "Restore State" menu > > items to the cocoa interface? They would allow the user to save the running > > state of the emulator. > >

Re: [Qemu-devel] Adding Save States menu items

2016-10-07 Thread Kevin Wolf
Am 06.10.2016 um 21:59 hat Eric Blake geschrieben: > Libvirt also learned that the qemu 'migrate-to-disk' format (used by > 'savevm' or 'migrate') is NOT self-descriptive - in order to fully and > safely revert to an earlier state, you HAVE to store the command line > (or a way to regenerate the co

Re: [Qemu-devel] Adding Save States menu items

2016-10-07 Thread Paolo Bonzini
On 06/10/2016 22:26, Eric Blake wrote: > > > Doesn't virt-manager already do this? What do we gain by duplicating > > > GUI functionality at this level that is already implemented at higher > > > levels? Not that I'm opposed to the idea, but having a solid reason why > > > it is useful is impor

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Programmingkid
On Oct 6, 2016, at 4:47 PM, Peter Maydell wrote: > On 6 October 2016 at 12:59, Eric Blake wrote: >> Libvirt also learned that the qemu 'migrate-to-disk' format (used by >> 'savevm' or 'migrate') is NOT self-descriptive - in order to fully and >> safely revert to an earlier state, you HAVE to sto

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 12:59, Eric Blake wrote: > Libvirt also learned that the qemu 'migrate-to-disk' format (used by > 'savevm' or 'migrate') is NOT self-descriptive - in order to fully and > safely revert to an earlier state, you HAVE to store the command line > (or a way to regenerate the comman

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Eric Blake
On 10/06/2016 03:10 PM, Programmingkid wrote: > > On Oct 6, 2016, at 3:59 PM, Eric Blake wrote: > >> On 10/06/2016 09:22 AM, Programmingkid wrote: >>> Would you accept a patch that added "Save State" and "Restore State" menu >>> items to the cocoa interface? They would allow the user to save the

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Programmingkid
On Oct 6, 2016, at 3:59 PM, Eric Blake wrote: > On 10/06/2016 09:22 AM, Programmingkid wrote: >> Would you accept a patch that added "Save State" and "Restore State" menu >> items to the cocoa interface? They would allow the user to save the running >> state of the emulator. > > Doesn't virt-m

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Eric Blake
On 10/06/2016 11:17 AM, Paolo Bonzini wrote: > > > On 06/10/2016 18:04, Programmingkid wrote: >> 'Save State...' would call something equivalent to the monitor command >> savevm. >> It would display a dialog box asking to give a name to this save. The default >> name would probably be "save stat

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Eric Blake
On 10/06/2016 09:22 AM, Programmingkid wrote: > Would you accept a patch that added "Save State" and "Restore State" menu > items to the cocoa interface? They would allow the user to save the running > state of the emulator. Doesn't virt-manager already do this? What do we gain by duplicating G

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Programmingkid
On Oct 6, 2016, at 1:49 PM, Peter Maydell wrote: > On 6 October 2016 at 18:43, Programmingkid wrote: >> @ Peter I don't know how to implement this in GTK. The GTK GUI maintainer >> doesn't even >> reply to my emails. Could we start this in Cocoa and then port it to GTK? I >> think >> the time

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 18:43, Programmingkid wrote: > @ Peter I don't know how to implement this in GTK. The GTK GUI maintainer > doesn't even > reply to my emails. Could we start this in Cocoa and then port it to GTK? I > think > the time is right. QEMU has progressed to the point that the save a

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Programmingkid
On Oct 6, 2016, at 12:17 PM, Paolo Bonzini wrote: > > > On 06/10/2016 18:04, Programmingkid wrote: >> 'Save State...' would call something equivalent to the monitor command >> savevm. >> It would display a dialog box asking to give a name to this save. The default >> name would probably be "sa

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 18:04, Programmingkid wrote: > 'Save State...' would call something equivalent to the monitor command savevm. > It would display a dialog box asking to give a name to this save. The default > name would probably be "save state mm-dd- - n". The m,d,y stand > for month, day, and y

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Programmingkid
On Oct 6, 2016, at 11:49 AM, Paolo Bonzini wrote: > > > On 06/10/2016 17:48, Programmingkid wrote: >> >> On Oct 6, 2016, at 11:35 AM, Paolo Bonzini wrote: >> >>> >>> >>> On 06/10/2016 16:42, Programmingkid wrote: On Oct 6, 2016, at 10:28 AM, Peter Maydell wrote: > On 6

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 17:48, Programmingkid wrote: > > On Oct 6, 2016, at 11:35 AM, Paolo Bonzini wrote: > >> >> >> On 06/10/2016 16:42, Programmingkid wrote: >>> >>> On Oct 6, 2016, at 10:28 AM, Peter Maydell wrote: >>> On 6 October 2016 at 15:22, Programmingkid wrote: > Would you acce

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Programmingkid
On Oct 6, 2016, at 11:35 AM, Paolo Bonzini wrote: > > > On 06/10/2016 16:42, Programmingkid wrote: >> >> On Oct 6, 2016, at 10:28 AM, Peter Maydell wrote: >> >>> On 6 October 2016 at 15:22, Programmingkid >>> wrote: Would you accept a patch that added "Save State" and "Restore Sta

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 16:42, Programmingkid wrote: > > On Oct 6, 2016, at 10:28 AM, Peter Maydell wrote: > >> On 6 October 2016 at 15:22, Programmingkid wrote: >>> Would you accept a patch that added "Save State" and >>> "Restore State" menu items to the cocoa interface? They would >>> allow the user

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Programmingkid
On Oct 6, 2016, at 10:28 AM, Peter Maydell wrote: > On 6 October 2016 at 15:22, Programmingkid wrote: >> Would you accept a patch that added "Save State" and >> "Restore State" menu items to the cocoa interface? They would >> allow the user to save the running state of the emulator. > > If you

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 15:22, Programmingkid wrote: > Would you accept a patch that added "Save State" and > "Restore State" menu items to the cocoa interface? They would > allow the user to save the running state of the emulator. If you can get consensus on first adding those to one of the other U

[Qemu-devel] Adding Save States menu items

2016-10-06 Thread Programmingkid
Would you accept a patch that added "Save State" and "Restore State" menu items to the cocoa interface? They would allow the user to save the running state of the emulator.