Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2018-12-10 Thread Wanpeng Li
On Fri, 19 May 2017 at 16:10, Jay Zhou wrote: > > Hi Paolo and Wanpeng, > > On 2017/5/17 16:38, Wanpeng Li wrote: > > 2017-05-17 15:43 GMT+08:00 Paolo Bonzini : > >>> Recently, I have tested the performance before migration and after > >>> migration failure > >>> using spec cpu2006 https://www.sp

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-19 Thread Jay Zhou
Hi Xiao, On 2017/5/19 16:32, Xiao Guangrong wrote: I do not know why i was removed from the list. I was CCed to you... Your comments are very valuable to us, and thank for your quick response. On 05/19/2017 04:09 PM, Jay Zhou wrote: Hi Paolo and Wanpeng, On 2017/5/17 16:38, Wanpeng Li wr

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-19 Thread Xiao Guangrong
I do not know why i was removed from the list. On 05/19/2017 04:09 PM, Jay Zhou wrote: Hi Paolo and Wanpeng, On 2017/5/17 16:38, Wanpeng Li wrote: 2017-05-17 15:43 GMT+08:00 Paolo Bonzini : Recently, I have tested the performance before migration and after migration failure using spec cpu2

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-19 Thread Jay Zhou
Hi Paolo and Wanpeng, On 2017/5/17 16:38, Wanpeng Li wrote: 2017-05-17 15:43 GMT+08:00 Paolo Bonzini : Recently, I have tested the performance before migration and after migration failure using spec cpu2006 https://www.spec.org/cpu2006/, which is a standard performance evaluation tool. These

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-17 Thread Wanpeng Li
2017-05-17 15:43 GMT+08:00 Paolo Bonzini : >> Recently, I have tested the performance before migration and after migration >> failure >> using spec cpu2006 https://www.spec.org/cpu2006/, which is a standard >> performance >> evaluation tool. >> >> These are the steps: >> == >> (1) the versio

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-17 Thread Paolo Bonzini
> Recently, I have tested the performance before migration and after migration > failure > using spec cpu2006 https://www.spec.org/cpu2006/, which is a standard > performance > evaluation tool. > > These are the steps: > == > (1) the version of kmod is 4.4.11(with slightly modified) and the

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-17 Thread Jay Zhou
On 2017/5/17 13:47, Wanpeng Li wrote: Hi Zhoujian, 2017-05-17 10:20 GMT+08:00 Zhoujian (jay) : Hi Wanpeng, On 11/05/2017 14:07, Zhoujian (jay) wrote: -* Scan sptes if dirty logging has been stopped, dropping those -* which can be collapsed into a single large-page spte. Lat

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-16 Thread Wanpeng Li
Hi Zhoujian, 2017-05-17 10:20 GMT+08:00 Zhoujian (jay) : > Hi Wanpeng, > >> > On 11/05/2017 14:07, Zhoujian (jay) wrote: >> >> -* Scan sptes if dirty logging has been stopped, dropping those >> >> -* which can be collapsed into a single large-page spte. Later >> >> -* page

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-16 Thread Zhoujian (jay)
Hi Wanpeng, > > On 11/05/2017 14:07, Zhoujian (jay) wrote: > >> -* Scan sptes if dirty logging has been stopped, dropping those > >> -* which can be collapsed into a single large-page spte. Later > >> -* page faults will create the large-page sptes. > >> +* Reset e

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-12 Thread Hailiang Zhang
On 2017/5/12 16:09, Xiao Guangrong wrote: On 05/11/2017 08:24 PM, Paolo Bonzini wrote: On 11/05/2017 14:07, Zhoujian (jay) wrote: -* Scan sptes if dirty logging has been stopped, dropping those -* which can be collapsed into a single large-page spte. Later -* page fau

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-12 Thread Xiao Guangrong
On 05/11/2017 08:24 PM, Paolo Bonzini wrote: On 11/05/2017 14:07, Zhoujian (jay) wrote: -* Scan sptes if dirty logging has been stopped, dropping those -* which can be collapsed into a single large-page spte. Later -* page faults will create the large-page sptes. +

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-11 Thread Wanpeng Li
2017-05-11 22:18 GMT+08:00 Zhoujian (jay) : > Hi Wanpeng, > >> 2017-05-11 21:43 GMT+08:00 Wanpeng Li : >> > 2017-05-11 20:24 GMT+08:00 Paolo Bonzini : >> >> >> >> >> >> On 11/05/2017 14:07, Zhoujian (jay) wrote: >> >>> -* Scan sptes if dirty logging has been stopped, dropping >> those >> >>

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-11 Thread Zhoujian (jay)
Hi Wanpeng, > 2017-05-11 21:43 GMT+08:00 Wanpeng Li : > > 2017-05-11 20:24 GMT+08:00 Paolo Bonzini : > >> > >> > >> On 11/05/2017 14:07, Zhoujian (jay) wrote: > >>> -* Scan sptes if dirty logging has been stopped, dropping > those > >>> -* which can be collapsed into a single large

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-11 Thread Zhoujian (jay)
Hi all, After applying the patch below, the time which memory_global_dirty_log_stop() function takes is down to milliseconds of a 4T memory guest, but I'm not sure whether this patch will trigger other problems. Does this patch make sense? diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c inde

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-11 Thread Wanpeng Li
2017-05-11 21:43 GMT+08:00 Wanpeng Li : > 2017-05-11 20:24 GMT+08:00 Paolo Bonzini : >> >> >> On 11/05/2017 14:07, Zhoujian (jay) wrote: >>> -* Scan sptes if dirty logging has been stopped, dropping those >>> -* which can be collapsed into a single large-page spte. Later >>> -

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-11 Thread Wanpeng Li
2017-05-11 20:24 GMT+08:00 Paolo Bonzini : > > > On 11/05/2017 14:07, Zhoujian (jay) wrote: >> -* Scan sptes if dirty logging has been stopped, dropping those >> -* which can be collapsed into a single large-page spte. Later >> -* page faults will create the large-page spte

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-11 Thread Paolo Bonzini
On 11/05/2017 14:07, Zhoujian (jay) wrote: > -* Scan sptes if dirty logging has been stopped, dropping those > -* which can be collapsed into a single large-page spte. Later > -* page faults will create the large-page sptes. > +* Reset each vcpu's mmu, then page f

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-04-26 Thread Yang Hongyang
Hi Paolo, Dave, On 2017/4/26 23:46, Paolo Bonzini wrote: > > > On 24/04/2017 18:42, Dr. David Alan Gilbert wrote: >> I suppose there's a few questions; >> a) Do we actually need the BQL - and if so why Enable/disable dirty log tracking are operations on memory regions. That's why they need to

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-04-26 Thread Paolo Bonzini
On 24/04/2017 18:42, Dr. David Alan Gilbert wrote: > I suppose there's a few questions; > a) Do we actually need the BQL - and if so why > b) What actually takes 13s? It's probably worth figuring > out where it goes, the whole bitmap is only 1GB isn't it > even on a 4TB machine, and even th

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-04-24 Thread Dr. David Alan Gilbert
* Yang Hongyang (yanghongy...@huawei.com) wrote: > > > On 2017/4/24 20:06, Juan Quintela wrote: > > Yang Hongyang wrote: > >> Hi all, > >> > >> We found dirty log switch costs more then 13 seconds while migrating > >> a 4T memory guest, and dirty log switch is currently protected by QEMU > >> BQ

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-04-24 Thread Yang Hongyang
On 2017/4/24 20:06, Juan Quintela wrote: > Yang Hongyang wrote: >> Hi all, >> >> We found dirty log switch costs more then 13 seconds while migrating >> a 4T memory guest, and dirty log switch is currently protected by QEMU >> BQL. This causes guest freeze for a long time when switching dirty lo

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-04-24 Thread Juan Quintela
Yang Hongyang wrote: > Hi all, > > We found dirty log switch costs more then 13 seconds while migrating > a 4T memory guest, and dirty log switch is currently protected by QEMU > BQL. This causes guest freeze for a long time when switching dirty log on, > and the migration downtime is unacceptable

[Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-04-24 Thread Yang Hongyang
Hi all, We found dirty log switch costs more then 13 seconds while migrating a 4T memory guest, and dirty log switch is currently protected by QEMU BQL. This causes guest freeze for a long time when switching dirty log on, and the migration downtime is unacceptable. Are there any chance to optimiz