Re: [Qemu-devel] 9pfs-proxy: -retval vs errno vs -1

Michael Tokarev writes: > Another interesting tidbit is in hw/9pfs/virtio-9p-proxy.c. > > All filesystem methods use common v9fs_request() function, > which returns -errno. So far so good. > > Now, *all* places which call this function, does this: > > retval = v9fs_request(...); > if (re

[Qemu-devel] 9pfs-proxy: -retval vs errno vs -1

Another interesting tidbit is in hw/9pfs/virtio-9p-proxy.c. All filesystem methods use common v9fs_request() function, which returns -errno. So far so good. Now, *all* places which call this function, does this: retval = v9fs_request(...); if (retval < 0) { errno = -retval;