Re: [Qemu-devel] 2 issues with qemu-master / 1.2 ehci code

2012-08-17 Thread Hans de Goede
Hi, On 08/17/2012 09:07 AM, Gerd Hoffmann wrote: Hi, 2) happens when a packet fails, and the queue should be halted, in this case Should we just cancel all queued packets on endpoint halts then? If the guest decides to go on we'll easily re-queue everything (with the existing code). If

Re: [Qemu-devel] 2 issues with qemu-master / 1.2 ehci code

2012-08-17 Thread Gerd Hoffmann
Hi, > 2) happens when a packet fails, and the queue should be halted, in > this case Should we just cancel all queued packets on endpoint halts then? If the guest decides to go on we'll easily re-queue everything (with the existing code). If the guest does something else we don't have to do a

Re: [Qemu-devel] 2 issues with qemu-master / 1.2 ehci code

2012-08-16 Thread Hans de Goede
Hi, On 08/16/2012 09:26 PM, Gerd Hoffmann wrote: I can get things working by turning ehci_fill_queue() into a nop... Investigating this further. But if you've any insights they would be appreciated. I'm thinking this may be caused by packets completing out of order, which could be caused by t

Re: [Qemu-devel] 2 issues with qemu-master / 1.2 ehci code

2012-08-16 Thread Gerd Hoffmann
Hi, > Ok, I've managed to significantly narrow this down, this is caused > by ehci_fill_queue() adding packets to the queue with different > qtdaddr values then the first one already queued up, this is of > course more or less fully expected, Yes. > but does trigger the assert in question ...

Re: [Qemu-devel] 2 issues with qemu-master / 1.2 ehci code

2012-08-16 Thread Hans de Goede
Hi, On 08/14/2012 06:12 PM, Hans de Goede wrote: Hi, 2) I'm hitting: qemu-system-x86_64: /home/hans/projects/qemu/hw/usb/hcd-ehci.c:2075: ehci_state_executing: Assertion `p->qtdaddr == q->qtdaddr' failed. When trying to redirect a microsoft lifecam, since this is a device with multiple i

Re: [Qemu-devel] 2 issues with qemu-master / 1.2 ehci code

2012-08-15 Thread Gerd Hoffmann
On 08/15/12 13:22, Hans de Goede wrote: > Hi, > > On 08/14/2012 06:12 PM, Hans de Goede wrote: >> Hi, >> >> While testing qemu-master I've encountered 2 problems caused by the >> ehci changes >> made since 1.1: >> >> 1) Newly plugged in devices don't get recognized by the guest >> This seems to be

Re: [Qemu-devel] 2 issues with qemu-master / 1.2 ehci code

2012-08-15 Thread Hans de Goede
Hi, On 08/14/2012 06:12 PM, Hans de Goede wrote: Hi, While testing qemu-master I've encountered 2 problems caused by the ehci changes made since 1.1: 1) Newly plugged in devices don't get recognized by the guest This seems to be a case of no interrupt getting generated while it should, doing

[Qemu-devel] 2 issues with qemu-master / 1.2 ehci code

2012-08-14 Thread Hans de Goede
Hi, While testing qemu-master I've encountered 2 problems caused by the ehci changes made since 1.1: 1) Newly plugged in devices don't get recognized by the guest This seems to be a case of no interrupt getting generated while it should, doing lsusb in a linux guest makes the device show up (af