Re: [Qemu-devel] snapshot:create snapshot for rbd disk failed.

2018-04-03 Thread Stefan Hajnoczi
On Thu, Mar 22, 2018 at 03:44:00AM +, Zhangzijian wrote: > Hello, CCing Sheepdog block driver maintainers. You can find maintainers for a source file using: $ scripts/get_maintainers -f block/sheepdog.c > > In 'bdrv_all_create_snapshot', each block will create snapshot in a for loop. >

[Qemu-devel] snapshot:create snapshot for rbd disk failed.

2018-03-21 Thread Zhangzijian
Hello, In 'bdrv_all_create_snapshot', each block will create snapshot in a for loop. If a domain configured disk mixed with qcow2 and rbd. In 'qcow2_snapshot_create', sn_info->id_str will be set. But in 'qemu_rbd_snap_create' the 'id_str' is checked. On this condition, 'id_str' check will be fa