Re: [Qemu-devel] [PATCH V2 0/4] machine: QemuOpts per machine

2014-05-27 Thread Marcel Apfelbaum
On Mon, 2014-05-26 at 18:42 +0200, Andreas Färber wrote: > Am 26.05.2014 14:48, schrieb Michael S. Tsirkin: > > On Mon, May 26, 2014 at 03:40:54PM +0300, Marcel Apfelbaum wrote: > >> V1 -> V2: > >> - Rebased on qom-next queue. > >> - Patch 1/4: > >>- Since there are a lot of discussions on t

Re: [Qemu-devel] [PATCH V2 0/4] machine: QemuOpts per machine

2014-05-26 Thread Michael Roth
Quoting Andreas Färber (2014-05-26 11:42:45) > Am 26.05.2014 14:48, schrieb Michael S. Tsirkin: > > On Mon, May 26, 2014 at 03:40:54PM +0300, Marcel Apfelbaum wrote: > >> V1 -> V2: > >> - Rebased on qom-next queue. > >> - Patch 1/4: > >>- Since there are a lot of discussions on the correct >

Re: [Qemu-devel] [PATCH V2 0/4] machine: QemuOpts per machine

2014-05-26 Thread Andreas Färber
Am 26.05.2014 14:48, schrieb Michael S. Tsirkin: > On Mon, May 26, 2014 at 03:40:54PM +0300, Marcel Apfelbaum wrote: >> V1 -> V2: >> - Rebased on qom-next queue. >> - Patch 1/4: >>- Since there are a lot of discussions on the correct >> way to do the fix, added a FIXME comment to find a

Re: [Qemu-devel] [PATCH V2 0/4] machine: QemuOpts per machine

2014-05-26 Thread Michael S. Tsirkin
On Mon, May 26, 2014 at 03:40:54PM +0300, Marcel Apfelbaum wrote: > V1 -> V2: > - Rebased on qom-next queue. > - Patch 1/4: >- Since there are a lot of discussions on the correct > way to do the fix, added a FIXME comment to find a better way. > - Patch 2/4: >- Addressed Michael Ro

[Qemu-devel] [PATCH V2 0/4] machine: QemuOpts per machine

2014-05-26 Thread Marcel Apfelbaum
V1 -> V2: - Rebased on qom-next queue. - Patch 1/4: - Since there are a lot of discussions on the correct way to do the fix, added a FIXME comment to find a better way. - Patch 2/4: - Addressed Michael Roth's comments: - Added output visitor test - Tweaked it as advised -