Re: [Qemu-devel] [PATCH 2/3] hw/rdma: modify struct initialization

2019-01-14 Thread Marcel Apfelbaum
On 1/13/19 9:36 PM, Yuval Shaia wrote: On Sun, Jan 13, 2019 at 09:24:40PM +0200, Yuval Shaia wrote: On Sat, Jan 12, 2019 at 05:02:24PM +0200, Marcel Apfelbaum wrote: Do not initialize structs with {0} since some CLANG versions do not support it. Use memset instead. It is easier than patchi

Re: [Qemu-devel] [PATCH 2/3] hw/rdma: modify struct initialization

2019-01-14 Thread Marcel Apfelbaum
Hi Cornelia, On 1/14/19 1:47 PM, Cornelia Huck wrote: On Sat, 12 Jan 2019 17:02:24 +0200 Marcel Apfelbaum wrote: Do not initialize structs with {0} since some CLANG versions do not support it. Use memset instead. Can't you use {} instead? (See, for example, commit ebf2a499a5c). I'll try i

Re: [Qemu-devel] [PATCH 2/3] hw/rdma: modify struct initialization

2019-01-14 Thread Cornelia Huck
On Sat, 12 Jan 2019 17:02:24 +0200 Marcel Apfelbaum wrote: > Do not initialize structs with {0} since some > CLANG versions do not support it. > > Use memset instead. Can't you use {} instead? (See, for example, commit ebf2a499a5c). > > Signed-off-by: Marcel Apfelbaum > --- > contrib/rdmacm

Re: [Qemu-devel] [PATCH 2/3] hw/rdma: modify struct initialization

2019-01-13 Thread Yuval Shaia
On Sun, Jan 13, 2019 at 09:24:40PM +0200, Yuval Shaia wrote: > On Sat, Jan 12, 2019 at 05:02:24PM +0200, Marcel Apfelbaum wrote: > > Do not initialize structs with {0} since some > > CLANG versions do not support it. > > > > Use memset instead. > > It is easier than patching CLANG ha? :) > > >

Re: [Qemu-devel] [PATCH 2/3] hw/rdma: modify struct initialization

2019-01-13 Thread Yuval Shaia
On Sat, Jan 12, 2019 at 05:02:24PM +0200, Marcel Apfelbaum wrote: > Do not initialize structs with {0} since some > CLANG versions do not support it. > > Use memset instead. It is easier than patching CLANG ha? :) > > Signed-off-by: Marcel Apfelbaum > --- > contrib/rdmacm-mux/main.c | 12

[Qemu-devel] [PATCH 2/3] hw/rdma: modify struct initialization

2019-01-12 Thread Marcel Apfelbaum
Do not initialize structs with {0} since some CLANG versions do not support it. Use memset instead. Signed-off-by: Marcel Apfelbaum --- contrib/rdmacm-mux/main.c | 12 +--- hw/rdma/rdma_backend.c| 16 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/c