Re: [Qemu-devel] [PATCH] Create libqemutrace.a for all trace.o

2017-04-03 Thread Stefan Hajnoczi
On Tue, Mar 28, 2017 at 07:00:34PM +, Xu, Anthony wrote: > > >>> ./trace.o, ./qapi/trace.o and ./util/trace.o are added into > > >>> libqemuutil.a to avoid recursive dependencies between > > >>> libqemuutil.a and libqemutrace.a. > > >> Why would libqemutrace.a depend on libqemuutil.a? > > > Ea

Re: [Qemu-devel] [PATCH] Create libqemutrace.a for all trace.o

2017-04-03 Thread Daniel P. Berrange
On Tue, Mar 28, 2017 at 07:00:34PM +, Xu, Anthony wrote: > > >>> ./trace.o, ./qapi/trace.o and ./util/trace.o are added into > > >>> libqemuutil.a to avoid recursive dependencies between > > >>> libqemuutil.a and libqemutrace.a. > > >> Why would libqemutrace.a depend on libqemuutil.a? > > > Ea

Re: [Qemu-devel] [PATCH] Create libqemutrace.a for all trace.o

2017-03-28 Thread Xu, Anthony
> >>> ./trace.o, ./qapi/trace.o and ./util/trace.o are added into > >>> libqemuutil.a to avoid recursive dependencies between > >>> libqemuutil.a and libqemutrace.a. > >> Why would libqemutrace.a depend on libqemuutil.a? > > Each trace.c calls trace_event_register_group to register events, > > tra

Re: [Qemu-devel] [PATCH] Create libqemutrace.a for all trace.o

2017-03-28 Thread Paolo Bonzini
On 27/03/2017 20:21, Xu, Anthony wrote: >>> ./trace.o, ./qapi/trace.o and ./util/trace.o are added into >>> libqemuutil.a to avoid recursive dependencies between >>> libqemuutil.a and libqemutrace.a. >> Why would libqemutrace.a depend on libqemuutil.a? > Each trace.c calls trace_event_register_g

Re: [Qemu-devel] [PATCH] Create libqemutrace.a for all trace.o

2017-03-27 Thread Xu, Anthony
> > ./trace.o, ./qapi/trace.o and ./util/trace.o are added into > > libqemuutil.a to avoid recursive dependencies between > > libqemuutil.a and libqemutrace.a. > > Why would libqemutrace.a depend on libqemuutil.a? Each trace.c calls trace_event_register_group to register events, trace_event_reg

Re: [Qemu-devel] [PATCH] Create libqemutrace.a for all trace.o

2017-03-27 Thread Stefan Hajnoczi
On Fri, Mar 24, 2017 at 04:28:32PM +, Xu, Anthony wrote: > Create libqemutrace.a for all trace.o > Currently all trace.o are linked into qemu-system, qemu-img, > qemu-nbd, qemu-io etc., even the corresponding components > are not included. > Create a libqemutrace.a that the linker would only

[Qemu-devel] [PATCH] Create libqemutrace.a for all trace.o

2017-03-24 Thread Xu, Anthony
Create libqemutrace.a for all trace.o Currently all trace.o are linked into qemu-system, qemu-img, qemu-nbd, qemu-io etc., even the corresponding components are not included. Create a libqemutrace.a that the linker would only pull in .o files containing symbols that are actually referenced by th