Re: [Qemu-devel] [v5 08/12] migration: Add the core code of multi-thread compression

2015-03-01 Thread Li, Liang Z
> I thihnk this would make the code work, but not the locking. You are using > here: > > quit_comp_thread: global, and not completely clear what protects it > comp_done_lock: global > comp_done_cond: global > > param[i].busy: I would suggest renaming to pending work > param[i].mutex: > param[i]

Re: [Qemu-devel] [v5 08/12] migration: Add the core code of multi-thread compression

2015-02-11 Thread Li, Liang Z
> -Original Message- > From: Juan Quintela [mailto:quint...@redhat.com] > Sent: Wednesday, February 11, 2015 7:45 PM > To: Li, Liang Z > Cc: qemu-devel@nongnu.org; ebl...@redhat.com; amit.s...@redhat.com; > lcapitul...@redhat.com; arm...@redhat.com; dgilb...@redhat.com; Zhang, > Yang Z > Su

Re: [Qemu-devel] [v5 08/12] migration: Add the core code of multi-thread compression

2015-02-11 Thread Juan Quintela
Liang Li wrote: > Implement the core logic of the multiple thread compression. At this > point, multiple thread compression can't co-work with xbzrle yet. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- a/arch_init.c > +++ b/arch_init.c > @@ -363,18 +363,44 @@ static QemuMutex *c

[Qemu-devel] [v5 08/12] migration: Add the core code of multi-thread compression

2015-02-10 Thread Liang Li
Implement the core logic of the multiple thread compression. At this point, multiple thread compression can't co-work with xbzrle yet. Signed-off-by: Liang Li Signed-off-by: Yang Zhang --- arch_init.c | 193 +--- 1 file changed, 185 insert