Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2018-01-03 Thread Halil Pasic
On 12/30/2017 08:57 AM, Longpeng (Mike) wrote: >> What you actually do is the following. You define a >> 'VIRTIO_CRYPTO_F__STATELESS_MODE feature bit is negotiated' >> (A) mode and a '... bit is not negotiated (B)' mode for each service. > >> In >> mode A the driver has to use type A sateful re

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-29 Thread Longpeng (Mike)
On 2017/12/21 0:44, Halil Pasic wrote: > Meta: Updated Connie's email. > > On 12/06/2017 08:37 AM, Longpeng(Mike) wrote: >> From: Gonglei >> >> The virtio crypto device is a virtual crypto device (ie. hardware >> crypto accelerator card). Currently, the virtio crypto device provides >> the fol

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-20 Thread Halil Pasic
Meta: Updated Connie's email. On 12/06/2017 08:37 AM, Longpeng(Mike) wrote: > From: Gonglei > > The virtio crypto device is a virtual crypto device (ie. hardware > crypto accelerator card). Currently, the virtio crypto device provides > the following crypto services: CIPHER, MAC, HASH, and AEAD.

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-11 Thread Halil Pasic
On 12/11/2017 03:09 PM, Michael S. Tsirkin wrote: > On Mon, Dec 11, 2017 at 02:54:25PM +0100, Halil Pasic wrote: >> * I assume one request is supposed to correspond to one descriptor chain. >> Right? If yes, could you tell me, where is this expressed in the spec. >> >> Halil > > That's always th

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-11 Thread Halil Pasic
On 12/11/2017 01:56 PM, Longpeng (Mike) wrote: > > > On 2017/12/6 19:01, Halil Pasic wrote: > >> >> >> On 12/06/2017 08:37 AM, Longpeng(Mike) wrote: >>> +\field{outcome_len} is the size of struct virtio_crypto_session_input or >>> +ZERO for the session-destroy operation. >> >> This ain't corre

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-11 Thread Michael S. Tsirkin
On Mon, Dec 11, 2017 at 02:54:25PM +0100, Halil Pasic wrote: > * I assume one request is supposed to correspond to one descriptor chain. > Right? If yes, could you tell me, where is this expressed in the spec. > > Halil That's always the default for all virtio devices, exceptions have to be noted

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-11 Thread Longpeng (Mike)
On 2017/12/6 19:01, Halil Pasic wrote: > > > On 12/06/2017 08:37 AM, Longpeng(Mike) wrote: >> +\field{outcome_len} is the size of struct virtio_crypto_session_input or >> +ZERO for the session-destroy operation. > > This ain't correct. It should have been something like > virtio_crypto_destr

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-07 Thread Gonglei (Arei)
> > On 12/06/2017 08:37 AM, Longpeng(Mike) wrote: > > +\field{outcome_len} is the size of struct virtio_crypto_session_input or > > +ZERO for the session-destroy operation. > > This ain't correct. It should have been something like > virtio_crypto_destroy_session_input. > Right, will fix it. >

Re: [Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-06 Thread Halil Pasic
On 12/06/2017 08:37 AM, Longpeng(Mike) wrote: > +\field{outcome_len} is the size of struct virtio_crypto_session_input or > +ZERO for the session-destroy operation. This ain't correct. It should have been something like virtio_crypto_destroy_session_input. > + > + > +\paragraph{Session operati

[Qemu-devel] [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-05 Thread Longpeng(Mike)
From: Gonglei The virtio crypto device is a virtual crypto device (ie. hardware crypto accelerator card). Currently, the virtio crypto device provides the following crypto services: CIPHER, MAC, HASH, and AEAD. In this patch, CIPHER, MAC, HASH, AEAD services are introduced. VIRTIO-153 Signed-o