Re: [Qemu-devel] [v2 2/3] qom/object.c: fix string_output_get_string() memory leak

2014-08-04 Thread Peter Crosthwaite
On Mon, Aug 4, 2014 at 2:21 PM, Chen Fan wrote: > string_output_get_string() uses g_string_free(str, false) to > transfer the 'str' pointer to callers and never free it. > > Signed-off-by: Chen Fan Reviewed-by: Peter Crosthwaite > --- > hmp.c| 6 -- > qom/object.c | 12 ++

Re: [Qemu-devel] [v2 2/3] qom/object.c: fix string_output_get_string() memory leak

2014-08-04 Thread Hu Tao
On Mon, Aug 04, 2014 at 12:21:18PM +0800, Chen Fan wrote: > string_output_get_string() uses g_string_free(str, false) to > transfer the 'str' pointer to callers and never free it. > > Signed-off-by: Chen Fan Reviewed-by: Hu Tao > --- > hmp.c| 6 -- > qom/object.c | 12 ++-

[Qemu-devel] [v2 2/3] qom/object.c: fix string_output_get_string() memory leak

2014-08-03 Thread Chen Fan
string_output_get_string() uses g_string_free(str, false) to transfer the 'str' pointer to callers and never free it. Signed-off-by: Chen Fan --- hmp.c| 6 -- qom/object.c | 12 ++-- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/hmp.c b/hmp.c index 4d1838e.